August 2017 - Koha-bugs - lists.koha-community.org

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '17

21 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #57 from Julian Maurice <julian.maurice(a)biblibre.com> --- All patches rebased on master. The last patch should fix comment 52 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '17

21 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #56 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 66270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66270&action=ed… Bug 11999: Remove the "biblio already reserved" check in CanItemBeReserved -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '17

21 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63595|0 |1 is obsolete| | --- Comment #55 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 66269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66269&action=ed… Bug 11999: Remove 'alreadyReserved' check in CanBookBeReserved Since bug 14695 it is possible to reserve more than one item per biblio Also fix bad use of $item -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '17

21 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63594|0 |1 is obsolete| | --- Comment #54 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 66268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66268&action=ed… Bug 11999: Check for age restriction in CanBookBeReserved + improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '17

21 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63593|0 |1 is obsolete| | --- Comment #53 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 66267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66267&action=ed… Bug 11999: Add two checks in CanBookBeReserved and CanItemBeReserved - Check if borrower already has reserved the same biblio (or item). - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower 3/ Try to hold the same biblio/item with the same borrower through ILS-DI and note that you can Apply the patch 4/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 5/ Try to hold the same biblio/item with the same borrower through ILS-DI. You shouldn't be able to do that. 6/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '17

21 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #64 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 66266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66266&action=ed… Bug 7317: Only allow cancellation request when status is new. * Koha/Illrequest.pm (_core_status_graph): Update status graph. * koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt: Only show button when status is NEW. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '17

21 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '17

21 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66252|0 |1 is obsolete| | --- Comment #20 from Marc Véron <veron(a)veron.ch> --- Created attachment 66265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66265&action=ed… Bug 12691: [FOLLOW-UP] Missing bracket Patch adds bracket to template file (Comment 16) Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '17

21 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65528|0 |1 is obsolete| | --- Comment #19 from Marc Véron <veron(a)veron.ch> --- Created attachment 66264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66264&action=ed… Bug 12691: [FOLLOW-UP] Follow-up patch This patch fixes merge conflicts and fixes the problems in Comment 7 QA tools complain about missing bracket, will be fixed in next followup Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '17

21 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65529|0 |1 is obsolete| | --- Comment #18 from Marc Véron <veron(a)veron.ch> --- Created attachment 66263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66263&action=ed… Bug 12691: Use Koha.Preference in Self-Checkout For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns, OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0