August 2017 - Koha-bugs - lists.koha-community.org

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '17

20 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65871|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 66253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66253&action=ed… Bug 4461: [FOLLOW-UP] Problem Report feature This patch: - uses a pull down menu to switch the recipient instead of tabs - if the library has no email or the administrator has no email, this error message has been moved to be down by the Submit button - includes use of branchreplyto and ReplytoDefault for branch email - disables use of the feature if the user is not logged in - adds a syspref to hide or show the feature - provides support for if JS is disabled Additional testing: - using the message_queue table, check that the correct recipient receives a problem report when switching in the drop down menu - check appropriate error message shows next to the submit button if an email is not provided. this should dynamically change as you select a different recipient from the drop down menu - check that when the library is the recipient, the feature sends the report to the branchreplyto, then the ReplytoDefault, then the branch email in that priority order - log out of the OPAC and confirm that you can't submit a report without logging in. the submit button should be disabled - disable the OPACReportProblem syspref. the Report a Problem link in the footer should be gone. if you force the URL (/cgi-bin/koha/opac-reportproblem.pl) the form should be hidden and replaced with an error message. - disable JS in your browser. confirm that you are still able to send problem reports to library and administrator. remove the administrator email address. confirm the error message shows next to the submit button and that clicking the submit button returns an error. check in the message_queue that the email was never sent. After this feature is passed: - i would like to add a staff-side feature where staff can see the problem reports and mark them as 'read'. i'll work on that once this gets through :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '17

20 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '17

20 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 --- Comment #17 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 66252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66252&action=ed… Bug 12691: [FOLLOW-UP] Missing bracket Patch adds bracket to template file (Comment 16) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '17

20 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2093] Add OPAC dashboard for logged-in users
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '17

20 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 --- Comment #12 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- patches apply without conflicts, ready to test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '17

20 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #21 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Sorry about all that - looks like the patches apply without conflicts now. Ready to test. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '17

20 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66246|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 66250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66250&action=ed… Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '17

20 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64249|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 66249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66249&action=ed… Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '17

20 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58604|0 |1 is obsolete| | --- Comment #18 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 66248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66248&action=ed… Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '17

20 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58603|0 |1 is obsolete| | --- Comment #17 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 66247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66247&action=ed… Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0