August 2017 - Koha-bugs - lists.koha-community.org

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Marc Véron <veron(a)veron.ch> --- Tested on top of Bug 19048 Template process failed: file error - parse error - (...)/home/marc/koha/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt line 205: unexpected end of directive [% IF ( Koha.Preference('ShowPatronImageInWebBasedSelfCheck') %] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19048 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19048 [Bug 19048] Self checkout: Internal server error in sco-main.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10306] Allow multiple Koha to Marc mappings ( say publication info in MARC21 260 or RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10306] Allow multiple Koha to Marc mappings ( say publication info in MARC21 260 or RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #27 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- This is not ready yet. Needs some feedback about a decision to make on viewing Default as authoritative for these mappings. See mail on dev list. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10306] Allow multiple Koha to Marc mappings ( say publication info in MARC21 260 or RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #26 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 65545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65545&action=ed… Bug 10306: Do not allow changes to kohafield within MARC frameworks This patch makes two changes to support making the Default authoritative as for Koha to MARC mappings: [1] Disable the kohafield select combo. Add a hidden input to save value. [2] When a new subfield is added, the kohafield is still empty and should be overwritten with its Default counterpart. Test plan: [1] Add a new tag and subfield in Default. [2] Map it to a kohafield in koha2marclinks.pl [3] Add the same tag and subfield in another framework. Verify that the kohafield is updated after you saved the subfield. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10306] Allow multiple Koha to Marc mappings ( say publication info in MARC21 260 or RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #25 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 65544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65544&action=ed… Bug 10306: Adjusted online help text for koha2marclinks Test plan: Click on Help. Read the text. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10306] Allow multiple Koha to Marc mappings ( say publication info in MARC21 260 or RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #24 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 65543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65543&action=ed… Bug 10306: Support for multiple mappings in koha2marclinks This actually refactors koha2marclinks.pl in order to support multiple mappings per kohafield. Instead of three separate mapping pages for biblio, biblioitems and items, the script now lists them together. This gives a complete overview of all mappings rightaway. Changes are applied immediately across all frameworks. Note: This report builds on the assumption that we do not keep mappings per framework, but consider the Default framework as authoritative. A change to Default is applied to the other frameworks though to keep them in sync. On each line two buttons are provided, Add and Remove, in order to add or remove an individual mapping. We do no longer provide a separate form with the names of MARC tags. Since this form is targeted for administrators, it should be enough to ask for a field tag and subfield code. Note: The mappings for biblionumber, biblioitemnumber and itemnumber are so vital that this form marks them as readonly. It is not recommended to change them. Test plan: [1] Add a mapping. Verify via Frameworks or mysql command line that the kohafield is saved to the other frameworks too. [2] Remove the mapping again. Check Frameworks or mysql cl again. [3] Test adding a second mapping. For instance map copyrightdate to 260c and 264c. Check Frameworks or mysql cl again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10306] Allow multiple Koha to Marc mappings ( say publication info in MARC21 260 or RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #23 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 65542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65542&action=ed… Bug 10306: Restructure TransformMarcToKoha and update some POD lines This patch makes the following changes: [1] Added POD for CountItemsIssued, GetBiblioItemData [2] Moved TransformMarcToKohaOneField closer to TransformMarcToKoha (before sub CountItemsIssued) [3] Restructured TransformMarcToKoha by extracting individual kohafields via TransformMarcToKohaOneField. The latter does no longer call the former. This small optimization avoids traversing the whole MARC record again and again. [4] Moved adjusting copyrightdate/publicationyear to separate helper routine _adjust_pubyear [5] Removed obsolete sub _get_inverted_marc_field_map. Test plan: Run t/db_dependent/Biblio/TransformMarcToKoha.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10306] Allow multiple Koha to Marc mappings ( say publication info in MARC21 260 or RDA 264)
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #22 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 65541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65541&action=ed… Bug 10306: Add tests for module changes GetMarcSubfieldStructure: In Biblio.t we are adding a subtest that checks the structure returned by this routine. Is it a hashref pointing to arrayrefs of hashrefs? ;) In Search.t this routine was mocked. The change in the returned structure is now applied to this mock too (moving the marc tag hashes into arrayrefs). GetMarcFromKohaField: In Biblio.t we add a subtest for it. We are checking if it returns multiple mappings (per kohafield) and calling it in scalar context too. GetMarcSubfieldStructureFromKohaField: The existing subtest in Biblio.t is expanded to also test the call in list context. TransformKohaToMarc: This sub has its own test script. We are adding a subtest in TransformKohaToMarc.t for a test with multiple mappings, and for mapping to a control field in another framework. This also tests the additional framework parameter. Additionally, we add a test for the new no_split option used for items. TransformMarcToKoha: This implicitly tests its helper sub _get_inverted. This patch adds a new test script for this routine. TransformMarcToKohaOneField: A few tests are added to the previous new test script. Test plan: [1] Run t/db_dependent/Biblio.t [2] Run t/db_dependent/Biblio/TransformKohaToMarc.t [3] Run t/db_dependent/Biblio/TransformMarcToKoha.t [4] Run t/db_dependent/Search.t -- You are receiving this mail because: You are watching all bug changes.

1 0