August 2017 - Koha-bugs - lists.koha-community.org

[Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19049 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12412 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10407 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19049 --- Comment #56 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #55) > Hm, I don't agree with saying that plugins are not part of the codebase and > people are 'lucky' if they work. Hmm, this is definitely not what I said! Specific plugins are simply not part of the codebase. Just a fact. I was not aware of the statement in the 3.20 release notes btw. Without that statement you were lucky if you got excel files into Koha. Do not take these words out of their context please. > We highlighted creating plugins to convert arbitrary files as a new feature > in the release notes of 3.20: > > https://koha-community.org/koha-3-20-0-released/ > Add ability for plugins to convert arbitrary files to MARC from record > staging tool (bug 12412) The conversion from arbitrary files should have been incorporated much more clearly in the interface and the code imo. The format option of the interface does not show Arbitrary only MARC or MARCXML. It is not mentioned in the online Help too. The code passes variable $marcrecords to BatchStageMarcRecords. Inside BatchStageMarcRecords the to_marc plugin is called. Again the same variable name $marcrecords is used. No mention of any arbitrary file type! No comment whatsoever, etc. So I can imagine that when Olli wrote the initial patches, he was not aware of this. Neither was I when I rescued these patches and got them further. At this point, we can only open a new report to add e.g. Arbitrary to the formats when we have a plugin, or some other description from the plugin. And call to_marc on these lines before passing them to BatchStageMarcRecords. See bug 19049. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19049 [Bug 19049] Recover the Arbitrary file type on stage-marc-import with plugin to_marc -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 --- Comment #15 from Marc Véron <veron(a)veron.ch> --- Can not test ATM because of Bug 19048 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #55 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hm, I don't agree with saying that plugins are not part of the codebase and people are 'lucky' if they work. We have introduced the plugin system as an official part of Koha and the hooks that we have added, should be maintained. If something needs to be changed, we should note that in the release notes or even should try to keep backwards compatibility when it's possible. We highlighted creating plugins to convert arbitrary files as a new feature in the release notes of 3.20: https://koha-community.org/koha-3-20-0-released/ Add ability for plugins to convert arbitrary files to MARC from record staging tool (bug 12412) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 --- Comment #54 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Pete Edwards from comment #45) Hi Pete, > 1. Was I doing something I shouldn't have been able to and this fix has not > broken anything as sch - just done what it always intended? Until we added the marcxml input format, the codebase only allowed you to import marc records. If you imported excel records and it worked with your plugin, you were just lucky. This was not intended to work at all. But it could certainly be an interesting third input format for the codebase ! > 2. Whatever the answer to the (1) it does seem to have changed the data > being passed to to_marc from scalar to array - surely that could break other > people's plugins? Since a plugin is not part of the codebase, the author should tell its users for which Koha version it is intended. It is not guaranteed to work with higher versions of Koha. Yes, behavior changed here. Before a string was sent consisting of multiple marc records separated by linefeed (no excel expected here). Now an array is passed with MARC::Record objects. I agree that this was not [clearly] communicated. If possible, such interface changes should be avoided. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 --- Comment #14 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- There we go, merge conflicts fixed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65527|0 |1 is obsolete| | --- Comment #13 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 65529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65529&action=ed… Bug 12691: Use Koha.Preference in Self-Checkout For calls to SCOUserJS, SCOUserCSS, OPACUserCSS, AllowSelfCheckReturns, OpacFavicon, ShowPatronImageInWebBasedSelfCheck, SelfCheckoutByLogin Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> https://bugs.koha-community.org/show_bug.cgi?id=12601 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '17

07 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63903|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 65528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65528&action=ed… Bug 12691: [FOLLOW-UP] Follow-up patch This patch fixes merge conflicts and fixes the problems in Comment 7 -- You are receiving this mail because: You are watching all bug changes.

1 0