August 2017 - Koha-bugs - lists.koha-community.org

[Bug 18977] New: Rollback branch in t/db_dependent/SIP/Message.t
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18977 Bug ID: 18977 Summary: Rollback branch in t/db_dependent/SIP/Message.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: lari.taskula(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org Test t/db_dependent/SIP/Message.t generates a Branch via TestBuilder outside $schema->storage->txn_begin and it stays in database when test is over. Move generation inside transaction so that it gets rolled back. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #51 from M. Tompsett <mtompset(a)hotmail.com> --- Follow the test plan in comment #32 and add a prove t/db_dependent/Search.t to complete it. :) Run QA Test tools, and all should be good. Read the code, make sure all the searchResults() and GetHiddenItemnumbers() calls were tweaked with the new parameters. Thanks to Aleisha Amohia for dealing with the searchResult() issues that I had failed to handle in my previous attempt on bug 10589, which will now become dependent on this patch, as I seek to add PatronEveryBranch (which this is), vs. PatronSingleBranch (which will be added). I have signed off all the code (including Catalyst's), and so if anyone else could sign off all the code, I would consider this signed off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65377|0 |1 is obsolete| | --- Comment #50 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65389&action=ed… Bug 14385: Fix QA Test tool failures C4/Search.pm had some tabs. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65376|0 |1 is obsolete| | --- Comment #49 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65388&action=ed… Bug 14385: Properly trigger all changes in C4/Search.pm Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65325|0 |1 is obsolete| | --- Comment #48 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65387&action=ed… Bug 14385: Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65324|0 |1 is obsolete| | --- Comment #47 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65386&action=ed… Bug 14385: Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65323|0 |1 is obsolete| | --- Comment #46 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65385&action=ed… Bug 14385: Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65322|0 |1 is obsolete| | --- Comment #45 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65384&action=ed… Bug 14385: Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64693|0 |1 is obsolete| | --- Comment #44 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65383&action=ed… Bug 14385: Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '17

01 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64692|0 |1 is obsolete| | --- Comment #43 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 65382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65382&action=ed… Bug 14385: Always use mocks, not set_preference Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0