September 2017 - Koha-bugs - lists.koha-community.org

[Bug 10132] MarcOrgCode would be useful on branch level
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '17

19 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10132 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67208|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 67211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67211&action=ed… Bug 10132: Simplify code, call the method only once -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10132] MarcOrgCode would be useful on branch level
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '17

19 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10132 --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 67208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67208&action=ed… Bug 10132: Simplify code, call the method only once -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13912] Add syspref for default place of publication (country code) for field 008, range 15-17
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '17

19 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13912 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Why do we default to xxu? There is no ref to "MARC21 only" in the pref description. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '17

19 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '17

19 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65133|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 67207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67207&action=ed… Bug 15486: Modify request.tt to handle the new error string This patch makes reserve/request.pl display a convenient error description when a hold cannot be placed due to the new daily limit configuration. To test: - Apply this patchset - Upgrade - Configure your circulation rules so there's a daily limit for holds - Place holds so the patron reaches the maximum - Place one more hold - Notice the hold cannot be placed and a convenient error message is displayed. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '17

19 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65132|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 67206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67206&action=ed… Bug 15486: Extend CanItemBeReserved so it handles daily holds limits This patch implements the required changes in C4::Reserves::CanItemBeReserved so it implements a daily limit on holds. It returns the 'tooManyReservesToday' string if the policy doesn't allow placing the hold. It returns 'OK' (current behaviour) otherwise. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: Tests fail because the error condition is not making CanItemBeReserved return the desired error code. - Apply this patch - Run: k$ prove t/db_dependent/Holds.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '17

19 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65131|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 67205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67205&action=ed… Bug 15486: Unit tests This patch introduces unit tests for the new circulation rules option that allows setting a max holds per day limit. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: CanItemBeReserved doesn't check the amount of holds per day and the introduced error code is not returned. OK is returned instead. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '17

19 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65130|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 67204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67204&action=ed… Bug 15486: Make circ rules UI handle holds_per_day This patch makes the staff UI correctly handle the holds_per_day configuration. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '17

19 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65129|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 67203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67203&action=ed… Bug 15486: DBIC update schema -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 19 Sep '17

19 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65128|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 67202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67202&action=ed… Bug 15486: DB structure change This patch adds a new column __max_holds_per_day__ to the issuingrules table. It's going to be used to set a daily limit for holds. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0