September 2017 - Koha-bugs - lists.koha-community.org

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '17

18 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 --- Comment #2 from David Bourgault <david.bourgault(a)inlibro.com> --- Created attachment 67184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67184&action=ed… Bug 7468 - Print barcodes by range Adds an option to the label creator to print a range of barcodes. Only allows printing to PDF. C4/Label.pm had to get minor changes to override database-based barcode generation. Same with labels/label-create-pdf.pl. By default, the barcode is fetched from the database using the itemnumber, but when printing ranges, you might not have a corresponding database entry. Test plan : 1) Apply patch 2) Print a range of barcodes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '17

18 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 David Bourgault <david.bourgault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14438] RTF / CSV /ODS format in Download cart option
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '17

18 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14438 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard(a)myacpl.org |koha-bugs(a)lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '17

18 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495 leire(a)scanbit.net changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '17

18 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495 leire(a)scanbit.net changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67182|1 |0 is obsolete| | --- Comment #5 from leire(a)scanbit.net --- Comment on attachment 67182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67182 Bug 9495 - split NotesBlacklist in to two prefs for staff and OPAC >From e37502012c17f4d000b0e8298124afea6cf23ea8 Mon Sep 17 00:00:00 2001 >From: Leire Diez <leire(a)scanbit.net> >Date: Mon, 18 Sep 2017 13:10:49 +0200 >Subject: [PATCH] Bug 9495 - split NotesBlacklist in to two prefs for staff and > OPAC > >Create the new preference NotesOPACBlacklist, it works like NotesBlacklist but these fields will not appear in the OPAC detail and will appear in the staff > >Test plan: >1) Add the fields to hide in the OPAC in the new preference NotesOPACBlacklist >2) Check in the Opac detail if these fields don't appear >3) Check in the staff detail if these fields appear > >Sponsored-by: Scanbit >--- > C4/Biblio.pm | 39 ++++++++++++++++++++++ > installer/data/mysql/sysprefs.sql | 1 + > installer/data/mysql/updatedatabase.pl | 9 +++++ > .../en/modules/admin/preferences/cataloguing.pref | 5 +++ > opac/opac-detail.pl | 2 +- > 5 files changed, 55 insertions(+), 1 deletion(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 12e6e7f..1ed6960 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -1715,6 +1715,45 @@ sub GetMarcNotes { > return \@marcnotes; > } > >+=head2 GetOPACMarcNotes >+ >+ $marcnotesarray = GetOPACMarcNotes( $record, $marcflavour ); >+ >+ Get all notes from the MARC record and returns them in an array. >+ The notes are stored in different fields depending on MARC flavour. >+ MARC21 field 555 gets special attention for the $u subfields. >+ >+=cut >+ >+sub GetOPACMarcNotes { >+ my ( $record, $marcflavour ) = @_; >+ if (!$record) { >+ carp 'GetMarcNotes called on undefined record'; >+ return; >+ } >+ >+ my $scope = $marcflavour eq "UNIMARC"? '3..': '5..'; >+ my @marcnotes; >+ my %blacklist = map { $_ => 1 } >+ split( /,/, C4::Context->preference('NotesOPACBlacklist')); >+ foreach my $field ( $record->field($scope) ) { >+ my $tag = $field->tag(); >+ next if $blacklist{ $tag }; >+ if( $marcflavour ne 'UNIMARC' && $tag =~ /555/ ) { >+ # Field 555$u contains URLs >+ # We first push the regular subfields and all $u's separately >+ # Leave further actions to the template >+ push @marcnotes, { marcnote => $field->as_string('abcd') }; >+ foreach my $sub ( $field->subfield('u') ) { >+ push @marcnotes, { marcnote => $sub }; >+ } >+ } else { >+ push @marcnotes, { marcnote => $field->as_string() }; >+ } >+ } >+ return \@marcnotes; >+} >+ > =head2 GetMarcSubjects > > $marcsubjcts = GetMarcSubjects($record,$marcflavour); >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 5155fe7..928d1ac 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -280,6 +280,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('NorwegianPatronDBPassword','',NULL,'Password for communication with the Norwegian national patron database.','Free'), > ('NorwegianPatronDBSearchNLAfterLocalHit','0',NULL,'Search NL if a search has already given one or more local hits?.','YesNo'), > ('NotesBlacklist','',NULL,'List of notes fields that should not appear in the title notes/description separator of details','free'), >+('NotesOPACBlacklist','',NULL,'List of notes fields that should not appear in the title notes/description separator of details','free'), > ('NotHighlightedWords','and|or|not',NULL,'List of words to NOT highlight when OpacHitHighlight is enabled','free'), > ('NoticeBcc','','','Email address to bcc outgoing notices sent by email','free'), > ('NoticeCSS','',NULL,'Notices CSS url.','free'), >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 698eb32..d5dd064 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -14617,6 +14617,15 @@ if( CheckVersion( $DBversion ) ) { > SetVersion( $DBversion ); > print "Upgrade to $DBversion done (Bug 18718 - Language selector in staff header menu similar to OPAC )\n"; > } >+$DBversion = '17.06.00.006'; >+if( CheckVersion( $DBversion ) ) { >+ $dbh->do(q{ >+ INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('NotesOPACBlacklist','','List of notes fields that should not appear in the title notes/description separator of details',NULL,'free') >+ }); >+ >+ SetVersion( $DBversion ); >+ print "Upgrade to $DBversion done (Bug 9495 - split NotesBlacklist in to two prefs for staff and OPAC )\n"; >+} > > $DBversion = '17.06.00.006'; > if( CheckVersion( $DBversion ) ) { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref >index 1aeadf9..06382d0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref >@@ -202,6 +202,11 @@ Cataloging: > class: multi > - note fields in title notes separator (OPAC record details) and in the description separator (Staff client record details). The fields should appear separated with commas and according with the Koha MARC format (eg 3.. for UNIMARC, 5.. for MARC21) > - >+ - Don't show these >+ - pref: NotesOPACBlacklist >+ class: multi >+ - note fields in title notes separator (OPAC record details). The fields should appear separated with commas and according with the Koha MARC format (eg 3.. for UNIMARC, 5.. for MARC21) >+ - > - pref: AcquisitionDetails > choices: > yes: Display >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 8252e50..5459c2b 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -748,7 +748,7 @@ if (!C4::Context->preference("OPACXSLTDetailsDisplay") ) { > ); > } > >-my $marcnotesarray = GetMarcNotes ($record,$marcflavour); >+my $marcnotesarray = GetOPACMarcNotes ($record,$marcflavour); > my $subtitle = GetRecordValue('subtitle', $record, GetFrameworkCode($biblionumber)); > > $template->param( >-- >2.1.4 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '17

18 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495 leire(a)scanbit.net changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67182|0 |1 is obsolete| | --- Comment #4 from leire(a)scanbit.net --- Created attachment 67183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67183&action=ed… Bug 9495 - split NotesBlacklist in to two prefs for staff and OPAC Fixed: Undefined subroutine &main::GetOPACMarcNotes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '17

18 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495 --- Comment #3 from leire(a)scanbit.net --- Created attachment 67182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67182&action=ed… Bug 9495 - split NotesBlacklist in to two prefs for staff and OPAC Create the new preference NotesOPACBlacklist, it works like NotesBlacklist but these fields will not appear in the OPAC detail and will appear in the staff Test plan: 1) Add the fields to hide in the OPAC in the new preference NotesOPACBlacklist 2) Check in the Opac detail if these fields don't appear 3) Check in the staff detail if these fields appear Sponsored-by: Scanbit -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '17

18 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com --- Comment #12 from Josef Moravec <josef.moravec(a)gmail.com> --- I just had to fix small conflict in Holds.t (number of tests), so now this is rebased on master and signed off ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '17

18 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #11 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 67181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67181&action=ed… Bug 15524 - Update Schema Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 18 Sep '17

18 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64707|0 |1 is obsolete| | Attachment #64708|0 |1 is obsolete| | --- Comment #10 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 67180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67180&action=ed… Bug 15524 - Set limit on maximum possible holds per patron by category It's possible to set a limit on the maximum number of holds for a particular branch/category/itemtype, but not on the total number of holds for a given patron (by branch/category). This new rule works in conjunction with the existing branch/borrower/item rules in that Koha will use the lower of the two limits. This new rule counts all holds of all types, which prevents bib-level holds from not being counted for the purpose of these limits. This makes the most sense and was also requested by the sponsor. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Go to the circ rules editor, note the new max holds rules by patron category in the "Checkout limit by patron category". ( Should we rename this section? ) 4) Create find a patron that is allowed to place a hold, count the number of holds that patron has. Lets make that number 'X'. 5) Set the new max holds rule to X for "All libraries" 6) Note the patron can no longer place another hold 7) Set the new max holds rule to X + 1 for the patron's home library 8) Note the patron can again place another hold 9) Set the new max holds rule to X for the patron's home library 10) Note the patron can no longer place another hold Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0