September 2017 - Koha-bugs - lists.koha-community.org

[Bug 17864] New: Increase coverage on admin pages
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '17

01 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17864 Bug ID: 17864 Summary: Increase coverage on admin pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mtompset(a)hotmail.com QA Contact: gmcharlt(a)gmail.com Bug 17793 corrects tabs visible in the search area. These tests will check those. -- You are receiving this mail because: You are watching all bug changes.

1 21

[Bug 9857] Did you mean? from authorities uses incorrect punctuation
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '17

01 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #15) > Created attachment 66781 [details] [review] > Bug 9857: Fix failing tests > > Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Patch pushed to master! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15336] Script for merging vendors
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '17

01 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I do not understand why you put the transaction in the pl and not in the method, are there any good reasons? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11580] returnBeforeExpiry and closed day
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '17

01 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I think the correct change is: + my $calendar = Koha::Calendar->new( branchcode => $branch ); + if ( $calendar->is_holiday($datedue) ) { + # Don't return on a closed day + $datedue = $calendar->prev_open_day($datedue); + } Because if expiry date is not a close day, the date due must be the expiry date. But then tests from t/db_dependent/Circulation/CalcDateDue.t are failing -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9857] Did you mean? from authorities uses incorrect punctuation
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '17

01 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 66781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66781&action=ed… Bug 9857: Fix failing tests Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9857] Did you mean? from authorities uses incorrect punctuation
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '17

01 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9857 --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 66780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66780&action=ed… Bug 9857: Fix failing test Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11580] returnBeforeExpiry and closed day
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '17

01 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- This change breaks test, please fix ASAP: t/db_dependent/Circulation/CalcDateDue.t .. 1/5 # Failed test 'date expiry' # at t/db_dependent/Circulation/CalcDateDue.t line 54. # got: '2012-12-31T23:59:00' # expected: '2013-01-01T23:59:00' # Looks like you failed 1 test of 5. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8451] Confusing and problematic double prompt for processing transfers
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '17

01 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 --- Comment #13 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- Not know this was being addressed, I tried my hand at it in 18503. I think unless someone can clearly present a scenario that would involve a hold an separate transfer in which both prompts need to be displayed, I have a hard time justifying keeping it in this state. If there is a legitimate need, then lets spell it out and make it work better for that scenario. Can someone come up with a scenario in which both are needed? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8451] Confusing and problematic double prompt for processing transfers
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '17

01 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18503 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13796] Alert in OPAC when renewing an item with a rental charge
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '17

01 Sep '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 --- Comment #26 from Marc Véron <veron(a)veron.ch> --- (In reply to Kyle M Hall from comment #25) > Minor issue, the renewals remaining have been moved into the conditional so > they will only show if the patron can renew the item themselves. Can be > solved easily with an ELSE on canrenew. Sorry, I have no time ATM. Can you provide a counter patch? -- You are receiving this mail because: You are watching all bug changes.

1 0