January 2018 - Koha-bugs - lists.koha-community.org

[Bug 15876] New: Removing a course-reserved item with no initial shelving location does not revert items.location to NULL
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '18

01 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15876 Bug ID: 15876 Summary: Removing a course-reserved item with no initial shelving location does not revert items.location to NULL Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs(a)lists.koha-community.org Reporter: theod(a)lib.auth.gr QA Contact: testopia(a)bugs.koha-community.org (This happens only when one changes the shelving location while the item is on a course_reserve) Steps to replicate: 1) Find an item with NO shelving location info (ie one that has items.location=items.permanent_location=NULL in the DB and the OPAC/Intranet shows an empty string) 2) Add this item to a course reserve 3) Either when adding the item in the course reserve, or at a later stage CHANGE (from the course reserve screen!) the 'temporary' shelving location info that will be used by that course reserve, by selecting a value from the drop-down list. Let's say 'On Display' 4) Find the item in the OPAC or Intranet, the change is displayed (as expected) 5) REMOVE this specific item from the course reserve 6) Find the item again in the OPAC or Intranet. All the course-reserve related information is reverted back to the original values as expected, except the shelving location, which is NOT reverted back to 'empty'. The old value (in our example 'On Display') is still shown!. FYI, NULL is added from items.location to course_items.location in step 2 as expected However, that NULL value in NOT copied back to items.location or items.permanent_location in step 5 as expected, but instead the value from step 3 is retained. (I have verified this behavior both with 3.20 and 3.22) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 20117] New: Need to store SMS notices in patron notices
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '18

31 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20117 Bug ID: 20117 Summary: Need to store SMS notices in patron notices Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org We should have a record of the SMS notices that are sent out in the patron accounts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '18

31 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #127 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Christopher Brannon from comment #126) > (In reply to Jonathan Druart from comment #125) > > (In reply to Kelly McElligott from comment #124) > > > We had a question about what email this note would be emailed to- the > > > Kohaadminemail set up in System preferences or the Item's Home Branch's > > > email set up in Libraries and Groups. However, when testing this new system > > > preference "allowcheckoutnotes' it appears that the patron that left the > > > note receives the email not the librarian. Can you verify that this is the > > > case.? > > > > Yes that sounds like a bug, could you report it? > > I can confirm this is the case. :/ I believe this has been fixed in Bug 19496! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '18

31 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Christopher Brannon <cbrannon(a)cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon(a)cdalibrary.org --- Comment #126 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- (In reply to Jonathan Druart from comment #125) > (In reply to Kelly McElligott from comment #124) > > We had a question about what email this note would be emailed to- the > > Kohaadminemail set up in System preferences or the Item's Home Branch's > > email set up in Libraries and Groups. However, when testing this new system > > preference "allowcheckoutnotes' it appears that the patron that left the > > note receives the email not the librarian. Can you verify that this is the > > case.? > > Yes that sounds like a bug, could you report it? I can confirm this is the case. :/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20094] New: gather_print_notices.pl uses first language in opaclanguages syspref bit first cannot be configured
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '18

31 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20094 Bug ID: 20094 Summary: gather_print_notices.pl uses first language in opaclanguages syspref bit first cannot be configured Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org We saw this problem on a site with multiple opaclanguages selected, all notices were defaulting to arabic template and printed as RTL. The cronjob gets the template which calls C4::Languages::getlanguage() The interface is read as 'opac' and no language is selected (no cookie, etc.) We eventually grab the first from the pref (bug 10560) The languages in the pref are loaded randomly into the admin view, try searching for 'opaclanguages' a few times or refreshing page, the order is random. Uncheck and recheck a language and save, note the pref is filled in the display order Run gather_print_notices.pl with different languages as first in the pref, note that a different template is used for each. I think the solution is just to allow for passing a specified language to the cron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '18

31 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- This is the idea. Will finish up tomorrow. No refactoring of the complete script here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '18

31 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #9 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71093&action=ed… Bug 20100: Disallow access to superlibrarian privileges at client side This last patch activates the check at client side. If the pref ProtectSuperlibPrivs is enabled, non-superlibs should not be able to change superlibrarian privileges via the interface. Test plan: [1] Enable the pref. [2] Login as superlib and add/remove superlib privs to a staff user. [3] Login as another user (no superlib, but having borrowers, permissions and staff_access). Verify that you cannot add or remove superlib privs. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '18

31 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71092&action=ed… Bug 20100: Disallow access to superlib privileges at server side Depends on pref ProtectSuperlibPrivs. If enabled, script member-flags.pl will not allow you to add or remove superlib privs when you are no superlibrarian. The follow-up patch will enable the check at client side. Test plan: [1] Enable the pref. Do not apply the third patch (client side). [2] Login as superlib and add/remove superlib privs to a staff user. [3] Login as another user (no superlib, but having borrowers, permissions and staff_access). Verify that you have an internal server error when you add or remove superlib privs. The log contains a warning. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '18

31 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71091&action=ed… Bug 20100: Introduce preference ProtectSuperlibPrivs This pref allows you to block changes to superlibrarian privileges at client and server side for non-superlibrarians. This patch only contains the db rev and the preference description. Test plan: Run dbrev or new install. Check pref value. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin
by bugzilla-daemon＠bugs.koha-community.org 31 Jan '18

31 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard(a)myacpl.org> --- This looks fine, and works correctly. I request one small fix: Our capitalization rules (https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_low…) say that only the first letter of the first word should be capitalized. I realize that the patch matches what the plugin has in its code, but we should follow the rules if we're adding it to our template. -- You are receiving this mail because: You are watching all bug changes.

1 0