January 2018 - Koha-bugs - lists.koha-community.org

[Bug 4319] waiting and in transit items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '18

12 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #79 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 70457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70457&action=ed… Bug 4319 - [QA follow-up] Rename hasItemswaitingOrInTransit to has_items_waiting_or_intransit and update pod -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '18

12 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #67 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Marcel de Rooy from comment #66) > (In reply to Katrin Fischer from comment #65) > > I think it should work like this: Check the framework for the authority type > > linked to a field and check for authorities of that type to link it with > > automatically. Fields not linked to an authority type, should not be > > auto-linked. > > Currently this is hardcoded in Heading somewhere. Hm, yeah, I seem to remember that this was used for importing authorities in order to assign the correct framework. Maybe this could be seen as a separate bug? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '18

12 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #66 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #65) > I think it should work like this: Check the framework for the authority type > linked to a field and check for authorities of that type to link it with > automatically. Fields not linked to an authority type, should not be > auto-linked. Currently this is hardcoded in Heading somewhere. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '18

12 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #65 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think it should work like this: Check the framework for the authority type linked to a field and check for authorities of that type to link it with automatically. Fields not linked to an authority type, should not be auto-linked. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '18

12 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #64 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Marcel, > In the editor we normally work with the authority popup. You completely go > around that here, but I still need to undo the plugin assignments before I > can really get your function working. I didn't do that in my testing. I still could use the normal plugin with the link on $a IIRC. I know I didn't change the frameworks. > If I disconnect 600, you still assume that it is a personal name. But I may > not want to work with your approach? If I enter an incorrect authid into $9, > it accepts the name in $a and does not create an authority. > But in another field (650), I see one is not accepted with an invalid > authid, and another one with invalid authid is accepted. This is not stable. > > To get short, I would recommend to remove the link button, move your > function to a plugin and minimize the changes to existing code to get it > working. In that way we can choose which plugin we want to use. It might > provide evidence for being stable and making a transition. I think you can't achieve the same functionality with a plugin, a button to check all fields at the same time and give you a summary report of the ones linked/unlinked. And you shouldn't have to choose - both should always be possible, manual (with search) and automatic linking. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '18

12 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #63 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Please squash the patches and correct the bug titles. See guidelines. We need them to be of the form Bug 12345: What does this patch do? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '18

12 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #62 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Thx for submitting your work. But I am still having serious doubts about this development. In the editor we normally work with the authority popup. You completely go around that here, but I still need to undo the plugin assignments before I can really get your function working. If I disconnect 600, you still assume that it is a personal name. But I may not want to work with your approach? If I enter an incorrect authid into $9, it accepts the name in $a and does not create an authority. But in another field (650), I see one is not accepted with an invalid authid, and another one with invalid authid is accepted. This is not stable. To get short, I would recommend to remove the link button, move your function to a plugin and minimize the changes to existing code to get it working. In that way we can choose which plugin we want to use. It might provide evidence for being stable and making a transition. tests for LinkBibHeadingsToAuthorities ? new sub AddAuthorityFromHeading Please note that the RM does no longer want to add C4 routines. What about UNIMARC btw? And adding an authority should not be in C4::Biblio! + # Get the first heading found in the biblio informations + foreach my $field ( $record->fields() ) { + my $heading = C4::Heading->new_from_bib_field($field); + next unless defined $heading; Isn't there a smarter way than just passing each field to Heading ? +is(C4::Biblio::AddAuthorityFromHeading(), 0, 'AddAuthorityFromHeading returns zero if not passed heading, field or bib'); This is not enough to test a new sub. Double eval (comment 59) There are enough reasons listed to postpone further QA for now. I am sorry for the amount of work here, but imo it needs larger adjustments. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19951] New: ; Literary form: not translated on search results with de-DE installed
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '18

12 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19951 Bug ID: 19951 Summary: ; Literary form: not translated on search results with de-DE installed Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: elias.dehler(a)thulb.uni-jena.de QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Created attachment 70420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70420&action=ed… Shows the bug "; Literary form:" isn't translated on the search results when the german is selected. steps to reproduce: 1. install the german translation de-DE 2. switch to german on the opac 3. make a search for something (as long as it has a literary form) 4. on the results everything is translated except ; Literary form: -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '18

12 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #61 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #60) > Bouzid: I will still continue on this one. But how do you make sure that you > do not save a personal name into say field 610 that should only include > corporate names ? QA: Looking here again little bit. Bouzid: A response would have been helpful to expedite QA now.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '18

12 Jan '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- The manual team is still small, maybe write something up and send it to them? ;) -- You are receiving this mail because: You are watching all bug changes.

1 0