October 2018 - Koha-bugs - lists.koha-community.org

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #18 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 81541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81541&action=ed… Bug 13098: Do not compare with precision Formating will be done TT side Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #17 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 81540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81540&action=ed… Bug 13098: Make _FixAccountForLostAndReturned refund the right thing This patch changes the logic inside the method, to make it match the behaviour described on the tests. It uses the existing offsets on the account_offsets table to gather information about the right things to refund. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests don't pass! - Apply this patch - Run k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D Followed test plan, patch works as described. All three patches pass QA test tool Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #16 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 81539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81539&action=ed… Bug 13098: Tests for all _FixAccountForLostAndReturned use cases This patch introduces tests for all the use cases for _FixAccountForLostAndReturned. This includes the following scenarios before _FixAccountForLostAndReturned is called: - Full write off (the original issue) - Full payment - No payment or write off - Partial payment and partial write off Written off debts (L lines) are just skipped, any kind of payment is added and then refund as a single credit (CR). Amount outstanding is set to 0. Offsets need to be generated for paper trail of this decisions. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because _FixAccountForLostAndReturned is not doing the right thing :-D Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81105|0 |1 is obsolete| | Attachment #81106|0 |1 is obsolete| | Attachment #81107|0 |1 is obsolete| | Attachment #81194|0 |1 is obsolete| | Attachment #81195|0 |1 is obsolete| | Attachment #81354|0 |1 is obsolete| | --- Comment #15 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 81538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81538&action=ed… Bug 13098: Add Koha::Account::Offsets->total This patch introduces this trivial method for returning the sum0 result of the amount columns of a Koha::Account::Offsets set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account/Offsets.t - Sign off :-D Followed test plan, patch worked as described Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #127 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Julian Maurice from comment #124) > I wrote > https://wiki.koha-community.org/wiki/Internationalization,_plural_forms, > _context,_and_more_(RFC) > > and initiated a thread on Framavox to gather opinions: > https://framavox.org/d/2juWqIMz/internationalization-plural-forms-context- > and-more > (feel free to not use it but please give your opinion either on the wiki > page or directly here on the bug report) Can you please send out to the maliing list too? More devs to see it then. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19550] New: Add links to related authorities for UNIMARC
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 Bug ID: 19550 Summary: Add links to related authorities for UNIMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Links exist in search results for MARC21 but not for UNIMARC. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #71 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Thanks for the swift followup. Looks great, works great, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81305|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 81523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81523&action=ed… Bug 14716: Fix more unencoded url parameters. Fixes issues found during QA and unifies the SubfieldSelect function across the utils xsl's. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81054|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 81522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81522&action=ed… Bug 14716: URI-encode URLs in NORMARC xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14716 Test plan: 1. Catalog a record with series name "Series & more" 2. Find the record 3. Make sure clicking the "Series & more" link works and the ampersand is properly encoded in the URL. Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Works as advertised. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0