October 2018 - Koha-bugs - lists.koha-community.org

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81053|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 81521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81521&action=ed… Bug 14716: URI-encode URLs in UNIMARC xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14716 Test plan: 1. Catalog a record with series name "Series & more" 2. Find the record 3. Make sure clicking the "Series & more" link works and the ampersand is properly encoded in the URL. 4. Also try the attached test records and make sure their links work. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81052|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 81520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81520&action=ed… Bug 14716: URI-encode URLs in MARC21 xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14716 Test plan: 1. Catalog a record with series name "Series & more" 2. Find the record 3. Make sure clicking the "Series & more" link works and the ampersand is properly encoded in the URL. 4. Also try the attached test records and make sure their links work. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21694 [Bug 21694] Add the Koha::Account->lines method -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #34 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to David Cook from comment #33) > (In reply to Jonathan Druart from comment #26) > > I do not think your Koha::Daemon will work for the background jobs. > > > > To me, the best way to fix this would be to provide a Koha daemon, instead. > > But it would watch a DB table, which would allow us to build a view on top > > of it to manage the different jobs (and history). > > > > We could also have different daemons for different needs (a param of the > > daemon matching a column in the DB table). > > > > The question behind that is security, we will have to list the different > > operations the daemon is allowed to process (and so we will loose > > flexibility). > > > > I have spent a *lot* of time trying to fix this issue by forking, etc. And > > my conclusion is: it's not feasible (see discussions and tries on related > > bug reports) > > > > See also bug 1993. > > I just realized that I misread your comment, Jonathan... > > Take a look at line 106 of "Harvester.pm" at > https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter. > html&bug=10662&attachment=79039. > > Using POE::Component::JobQueue, I check a DB table called > "oai_harvester_import_queue" for "new" import jobs. > > You could do the same thing. > > In my case, the job in "oai_harvester_import_queue" actually has a field > containing a JSON array of record identifiers, and the import task fetches > those records from the file system and then works on them as a batch. Going > 1 by 1 for each record would be way too slow (both in terms of retrieving > tasks and importing records). > > But yeah the web interface could upload the records, store their location, > put that in a job, and then store that data in the database. The import > daemon would poll the database (which isn't super efficient but efficient > enough for Koha's purposes I imagine), and then work on batches as it could. > > -- > > (One thing to keep in mind here is import matching rules that use Zebra... > if you have high performance importing, Zebra won't be able to keep up, and > it means that you could wind up with duplicate records if someone tries to > import the same record too quickly... ) This is worth discussing in koha-devel, and IRC meeting or Marseille, but I think we should have a job queue in the lines of what David proposes. And I would add maybe the use of ZeroMQ to possibly notify other services. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #150 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I couldn't find any other occurrences where Koha::Email wasn't used either. I've added a QA follow-up to try and catch any future uses of Bcc fields by moving the code to Koha::Email for that and updating the calling code appropriately. It looks like this has been signed off a few times, so I've reset signed-off and asked another QAer to do a final pass to double check my followup more than anything else. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #149 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 81488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81488&action=ed… Bug 8000: (QA follow-up) Centralise Bcc too -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80370|0 |1 is obsolete| | --- Comment #148 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 81487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81487&action=ed… Bug 8000: Redirect all emails to SendAllEmailsTo Rebased and squashed after changes to master. Only difference from previous patches are small adjustements to conflicts in t/db_dependent/Letters.t Test plan: 1) Apply path 2) Run updatedatabase.pl 3) Clear all SendAllEmailsTo system preference 4) Send mail to a patron of your choosing, email will go to patron's email address as usual. 5) Set SendAllEmailsTo to a test email address 6) Send mail to the patron, email will be redirected to the email set in the systempreference. 7) Run prove -v t/db_dependent/Letters.t It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) Signed-off-by: Ed Veal <eveal(a)mckinneytexas.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #147 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Wouldn't this be a little cleaner if the Bcc was also handled within Koha::Email the way Cc is with this patch? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0