October 2018 - Koha-bugs - lists.koha-community.org

[Bug 20538] New: Remove the need of writing [% KOHA_VERSION %] everywhere
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '18

17 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20538 Bug ID: 20538 Summary: Remove the need of writing [% KOHA_VERSION %] everywhere Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Having to write [% KOHA_VERSION %] for each url is bad because: - It's easily forgettable when adding new <script> or <link> - It prevents grep'ing for the full filename - It violates the DRY principle - If at some point we want to change the "force js and css reload" mechanism, it will be tedious -- You are receiving this mail because: You are watching all bug changes.

1 37

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '18

17 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78809|0 |1 is obsolete| | --- Comment #58 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 80701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80701&action=ed… Bug 14716: URI-encode URLs in NORMARC xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14716 Test plan: 1. Catalog a record with series name "Series & more" 2. Find the record 3. Make sure clicking the "Series & more" link works and the ampersand is properly encoded in the URL. Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Works as advertised. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '18

17 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '18

17 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #256 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches rebased + another patch of QA fixes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '18

17 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #255 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 80700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80700&action=ed… Bug 11708: Add missing TT filters and fix perlcritic errors -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '18

17 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78664|0 |1 is obsolete| | --- Comment #254 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 80699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80699&action=ed… Bug 11708: Fix QA issues - Change how closedate is set in database update - Reword bookseller to vendor in Koha::Acquisition::Basketgroup - Do not "cache" baskets in Koha::Acquisition::Basketgroup - Remove useless IF in basketgroup.tt - Move JS to bottom in basketgroups.tt - Fix some links to basketgroup.pl - Remove useless use in acqui/basketgroup.pl - Remove useless sub displaybasketgroups in acqui/basketgroup.pl - Remove useless code in C4::Acquisition -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '18

17 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78663|0 |1 is obsolete| | --- Comment #253 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 80698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80698&action=ed… Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. This patch also adds 3 columns: - No. of ordered titles - No. of received titles - Date closed It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '18

17 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78662|0 |1 is obsolete| | --- Comment #252 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 80697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80697&action=ed… Bug 11708: Change aqbasketgroups.closed to closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18480] New: Get rid of unwanted / distracting link in patron search for fund owner
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '18

17 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18480 Bug ID: 18480 Summary: Get rid of unwanted / distracting link in patron search for fund owner Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org To reproduce: - Go to Home > Administration > Budgets > Funds > Modify fund ... - Click "Select owner" - In pop up window, search for patrons In the result list, the patron's name etc. is linked to the patron's detail page. If you accidentally click on the link, their detail screen is displayed inside the pop up. No way to get back to the selection screen. (You have to close the pop up and start over adding.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 37

[Bug 15139] Show non-public item note in overdues report
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '18

17 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #16 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.

1 0