October 2018 - Koha-bugs - lists.koha-community.org

[Bug 13618] Add additional template filter methods and a filter presence test to Koha
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '18

15 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21576 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576 [Bug 21576] Add a developer script to automatically fix missing filters -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15184] Ability to duplicate existing order lines to a given basket
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '18

15 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 --- Comment #95 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 80638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80638&action=ed… Bug 15184: Add missing html filters -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '18

15 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #10 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Jonathan Druart from comment #9) > Maybe we could keep the link to recover the password? > > - [% IF Koha.Preference('OpacResetPassword') > %] > - <a > href="/cgi-bin/koha/opac-password-recovery.pl">You must reset your > password</a>. > - [% ELSE %] Do you want people to be able to unlock locked accounts? Perhaps a wording change would be required so as to not let the person know whether or not the account is locked. And does the reset password reset the failed log in attempts? I thought there was another bug related to this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '18

15 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Maybe we could keep the link to recover the password? - [% IF Koha.Preference('OpacResetPassword') %] - <a href="/cgi-bin/koha/opac-password-recovery.pl">You must reset your password</a>. - [% ELSE %] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21553] New: Javascript error on rota page
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '18

15 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21553 Bug ID: 21553 Summary: Javascript error on rota page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Turn on StockRotation system preference 1) Go to a staff detail page 2) Switch to rota page 3) Check web developer tools: ReferenceError: _ is not defined[Learn More] stockrotation.pl:61:9 <anonymous> http://localhost:8081/cgi-bin/koha/catalogue/stockrotation.pl:61:9 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 21536] New: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '18

15 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21536 Bug ID: 21536 Summary: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled if WebService::ILS is not available. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '18

15 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com --- Comment #8 from M. Tompsett <mtompset(a)hotmail.com> --- The only thing that may be in question is whether or not we change the other part of the message. A simple "Access Denied" without reasons is clearer in that it doesn't say what was wrong. The failure to mention the possibility of lock out seems wrong to me, but I'm not hung up on it. I'll let QA decide that quandary with a follow up patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15139] Show non-public item note in overdues report
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '18

15 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '18

15 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #79 from Nick Clemens <nick(a)bywatersolutions.com> --- This is not perfect, but it reduces the scope of the problem here greatly. We probably should decide if there is a valid reason to have "" vs. undef for some of the values in items. Awesome work all on getting this moved along. Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 15 Oct '18

15 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80388|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 80623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80623&action=ed… Bug 21311: Remove locked message from opac-auth.tt We should not expose more information than needed when someone tries to login with invalid credentials. Saying that an account is locked reveals that the account exists (or perhaps an email address). Trivial fix. Keeping the var too_many_login_attempts for staff. Note: We do not remove this distinction for the staff client here (in the assumption that a library may well have additional security measures in place for staff client). But it could be done too (on another report). Test plan: Enable lockout feature. Enter invalid credentials until account locks out (on OPAC !!) Note that message does no longer change to 'Account is locked'. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0