October 2018 - Koha-bugs - lists.koha-community.org

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '18

11 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20797 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '18

11 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #176 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Marcel de Rooy from comment #175) > (In reply to Katrin Fischer from comment #173) > > Please rebase. > > > > Apply? [(y)es, (n)o, (i)nteractive] y > > Applying: Bug 14385: Extend OpacHiddenItems to allow specifying exempt > > borrower categories > > Applying: Bug 14385 Followup: C4::Borrowers not found > > Applying: Bug 14385: Followup: changes to sysprefs.sql and atomicupdate > > Applying: Bug 14385: Squash of a lot of patches rebased > > fatal: sha1 information is lacking or useless (C4/Search.pm). > > Repository lacks necessary blobs to fall back on 3-way merge. > > Cannot fall back to three-way merge. > > Patch failed at 0001 Bug 14385: Squash of a lot of patches rebased > > The copy of the patch that failed is found in: > > /home/vagrant/kohaclone/.git/rebase-apply/patch > > When you have resolved this problem run "git bz apply --continue". > > If you would prefer to skip this patch, instead run "git bz apply --skip". > > To restore the original branch and stop patching run "git bz apply --abort". > > Patch left in /tmp/Bug-14385-Squash-of-a-lot-of-patches-rebased-PmRtSL.patch > > cait: Are you working on this one ? Haven't started yet to look beyong applying, happy to hand over! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '18

11 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #175 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #173) > Please rebase. > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 14385: Extend OpacHiddenItems to allow specifying exempt > borrower categories > Applying: Bug 14385 Followup: C4::Borrowers not found > Applying: Bug 14385: Followup: changes to sysprefs.sql and atomicupdate > Applying: Bug 14385: Squash of a lot of patches rebased > fatal: sha1 information is lacking or useless (C4/Search.pm). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 14385: Squash of a lot of patches rebased > The copy of the patch that failed is found in: > /home/vagrant/kohaclone/.git/rebase-apply/patch > When you have resolved this problem run "git bz apply --continue". > If you would prefer to skip this patch, instead run "git bz apply --skip". > To restore the original branch and stop patching run "git bz apply --abort". > Patch left in /tmp/Bug-14385-Squash-of-a-lot-of-patches-rebased-PmRtSL.patch cait: Are you working on this one ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '18

11 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78828|0 |1 is obsolete| | --- Comment #174 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 80411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80411&action=ed… Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! - Rebased t/db_dependent/Items.t conflict. The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '18

11 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21448] New: Field 606 doesn't add multiple x subfields
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '18

11 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21448 Bug ID: 21448 Summary: Field 606 doesn't add multiple x subfields Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: joseanjos(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl On field 606, if I use an Authority with multiple "x" subfields, it will add just the first "x" This is a bug from recent koha versions because it was working with our Koha until now. I've tested with BibLibre demo (http://intranet-demo.biblibre.com/) and it works fine (Ver 17.11) With 18.05 doesn't work. This is happening with MARC 21 as reported by Elaine Bradtke here: http://koha.1045719.n5.nabble.com/Field-606-doesnt-add-multiple-x-subfields… -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 13272] Many inputs lack a type attribute
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '18

11 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13272 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m --- Comment #32 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '18

11 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #14 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Test plan: - Go to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it is NOT possible to select this item - Enable the "AllowRenewalLimitOverride" syspref - Enable the "AllowRenewalOnHoldOverride" syspref - Return to the Patron Details page for a patron who has an item on loan that would fulfil an outstanding loan request. - TEST: Observe that it IS possible to select this item - Select the item - TEST: Observe that an additional "On hold due date" input box is displayed - De-select the item - TEST: Observe that an additional "On hold due date" input box is hidden - Select the item - In the "On hold due date" input box, select a due date for the item - Click "Renew or check in selected items" - TEST: Observe that the item is renewed as usual - In the "Renewal due date" input box, select a due date - Remove the contents of the "On hold due date" input box - Click "Renew or check in selected items" - TEST: Observe that the item is renewed by falling back to the "Renewal due date" value if a value is not specified in the "On hold due date" input box - Remove the contents of the "Renewal due date" input box - Click "Renew or check in selected items" - TEST: Observe that the standard loan period is used for the renewal period if no due date is specified in either box - In the "On hold due date" input box, select a due date for the item - In the "Renewal due date" input box, select a different due date - Click "Renew all" - TEST: Observe that all non on hold items are renewed using the value in "Renewal due date" and on hold items are renewed using the value in "On hold due date" - From the main staff client from page, choose "Circulation", then choose "Renew" - Enter the barcode of an item that you know to be on hold and submit - TEST: In the alert box that appears, observe that a date picker is displayed - Choose a due date for this item, then click "Override and renew" - TEST: In the "Item renewed" box, observe that the item has been renewed to the date specified -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '18

11 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60715|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21546] New: RomyGanz
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '18

11 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21546 Bug ID: 21546 Summary: RomyGanz Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: Romilala123(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 80384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80384&action=ed… Jajajb Jejjejsnnsn -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1