October 2018 - Koha-bugs - lists.koha-community.org

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #251 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Please also make sure to run the newest qa script on the code to check for missing filters! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #250 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry, this no longer applies, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11708: Change aqbasketgroups.closed to closeddate Applying: Bug 11708: New page for basket groups fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11708: New page for basket groups The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11708-New-page-for-basket-groups-maTm2R.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Can you please fix the issues pointed out by the QA script? I could fix the filtes, but not sure about the first: FAIL acqui/lateorders.pl FAIL critic # Variables::ProhibitUnusedVariables: Got 1 violation(s). FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt FAIL filters missing_filter at line 84 ( [% lateorder.ordernumber %]) missing_filter at line 143 ( <td><input name="vendornote" id="vendornote" type="text" value="[% lateorder.vendornote %]"></td>) missing_filter at line 144 ( <td>[% lateorder.isbn %]</td>) missing_filter at line 142 ( <td><input name="internalnote" id="internalnote" type="text" value="[% lateorder.internalnote %]"></td>) missing_filter at line 269 ( $("#savenotes").after("<span id=\"loading\" style=\"margin:4px;\"><img src=\"[% interface %]/[% theme %]/img/loading-small.gif\" alt=\"\" /> "+_("Loading")+"</span>");) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou <philippe.blouin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Blou <philippe.blouin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74848|0 |1 is obsolete| | --- Comment #146 from Blou <philippe.blouin(a)inlibro.com> --- Created attachment 80370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80370&action=ed… Bug 8000: Redirect all emails to SendAllEmailsTo Rebased and squashed after changes to master. Only difference from previous patches are small adjustements to conflicts in t/db_dependent/Letters.t Test plan: 1) Apply path 2) Run updatedatabase.pl 3) Clear all SendAllEmailsTo system preference 4) Send mail to a patron of your choosing, email will go to patron's email address as usual. 5) Set SendAllEmailsTo to a test email address 6) Send mail to the patron, email will be redirected to the email set in the systempreference. 7) Run prove -v t/db_dependent/Letters.t It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) Signed-off-by: Ed Veal <eveal(a)mckinneytexas.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21543] New: Advanced Notice cron will try to send advance phone notices in the Talking Tech Sending Notices File
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21543 Bug ID: 21543 Summary: Advanced Notice cron will try to send advance phone notices in the Talking Tech Sending Notices File Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: margaret(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The Advanced Notice (misc/cronjobs/advance_notices.pl) will try to send "advance notice of item due" phone notices which shouldn't be processed except by the Talking Tech Sending Notices File (misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl) In this case/to replicate: 1) A library is set up to use Advanced Notices and Talking Tech Sending/Receiving Notices File crons. 2) They want patrons to get advanced notice emails 7 days per week, but only get phone notices 5 days per week. 3) When Advanced Notices cron runs on those other two days it will try to send the "advance notice of item due phone notices" to Talking Tech, which fails because the i-tiva server is not making calls on that day. 4) The notices that Advanced Notice cron erroneously processed are forever stuck in pending status in the message queue. Can Advanced Notice cron be updated to not touch notices that are slated for processing by the Talking Tech Sending Notices File cron? TLDR: advance_notices.pl generates phone notices, these should only be generated by the talking tech crons. To recreate enable advanced messaging, set phone for advance notice for a patron and checkout an item that will trigger the notice, run advance_notices.pl, check the message queue and see a phone notice is pending. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #5 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 80352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80352 Bug 21311: Remove locked message from opac-auth.tt Review of attachment 80352: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=213…) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt @@ +57,5 @@ > [% END %] > > > + [% IF invalid_username_or_password || too_many_login_attempts %] > +  This is a very good security step. @@ -62,5 @@ > - This account has been locked! > - [% IF Koha.Preference('OpacResetPassword') %] > - <a href="/cgi-bin/koha/opac-password-recovery.pl">You must reset your password</a>. > - [% ELSE %] > - Please contact a library staff member. I think adding the "Please contact a library staff member if you continue to have problems." would be a good idea. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Add additional template filter methods and a filter presence test to Koha
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21541 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21541 [Bug 21541] HTML filter breaks HTML rendering of SQL output -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12488] bulkmarcimport.pl -d option should use DELETE instead of TRUNCATE
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 Andreas Roussos <arouss1980(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arouss1980(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

1 0