October 2018 - Koha-bugs - lists.koha-community.org

[Bug 21543] New: Advanced Notice cron will try to send advance phone notices in the Talking Tech Sending Notices File
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21543 Bug ID: 21543 Summary: Advanced Notice cron will try to send advance phone notices in the Talking Tech Sending Notices File Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: margaret(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The Advanced Notice (misc/cronjobs/advance_notices.pl) will try to send "advance notice of item due" phone notices which shouldn't be processed except by the Talking Tech Sending Notices File (misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl) In this case/to replicate: 1) A library is set up to use Advanced Notices and Talking Tech Sending/Receiving Notices File crons. 2) They want patrons to get advanced notice emails 7 days per week, but only get phone notices 5 days per week. 3) When Advanced Notices cron runs on those other two days it will try to send the "advance notice of item due phone notices" to Talking Tech, which fails because the i-tiva server is not making calls on that day. 4) The notices that Advanced Notice cron erroneously processed are forever stuck in pending status in the message queue. Can Advanced Notice cron be updated to not touch notices that are slated for processing by the Talking Tech Sending Notices File cron? TLDR: advance_notices.pl generates phone notices, these should only be generated by the talking tech crons. To recreate enable advanced messaging, set phone for advance notice for a patron and checkout an item that will trigger the notice, run advance_notices.pl, check the message queue and see a phone notice is pending. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #5 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 80352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80352 Bug 21311: Remove locked message from opac-auth.tt Review of attachment 80352: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=213…) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt @@ +57,5 @@ > [% END %] > > > + [% IF invalid_username_or_password || too_many_login_attempts %] > +  This is a very good security step. @@ -62,5 @@ > - This account has been locked! > - [% IF Koha.Preference('OpacResetPassword') %] > - <a href="/cgi-bin/koha/opac-password-recovery.pl">You must reset your password</a>. > - [% ELSE %] > - Please contact a library staff member. I think adding the "Please contact a library staff member if you continue to have problems." would be a good idea. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Add additional template filter methods and a filter presence test to Koha
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21541 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21541 [Bug 21541] HTML filter breaks HTML rendering of SQL output -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12488] bulkmarcimport.pl -d option should use DELETE instead of TRUNCATE
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 Andreas Roussos <arouss1980(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arouss1980(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 --- Comment #4 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 80352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80352&action=ed… Bug 21311: Remove locked message from opac-auth.tt We should not expose more information than needed when someone tries to login with invalid credentials. Saying that an account is locked reveals that the account exists (or perhaps an email address). Trivial fix. Keeping the var too_many_login_attempts for staff. Note: We do not remove this distinction for the staff client here (in the assumption that a library may well have additional security measures in place for staff client). But it could be done too (on another report). Test plan: Enable lockout feature. Enter invalid credentials until account locks out (on OPAC !!) Note that message does no longer change to 'Account is locked'. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21311] Remove locked message from opac-auth.tt
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Product|Koha security |Koha Assignee|chris(a)bigballofwax.co.nz |m.de.rooy(a)rijksmuseum.nl Component|Koha |Architecture, internals, | |and plumbing Summary|Should we tell that an |Remove locked message from |account has been locked ? |opac-auth.tt Group|Koha security | --- Comment #3 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Moving to regular Koha category. No real difference in keeping it here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '18

10 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Kelly McElligott <kelly(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0