October 2018 - Koha-bugs - lists.koha-community.org

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin(a)bugs.koha-community. |aleisha(a)catalyst.net.nz |org.xinxidi.net | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 --- Comment #41 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 80252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80252&action=ed… Bug 8628: (follow-up) Some template fixes This patch: - makes the stream name a required field - fixes the link to the OPAC sign view - fixes the toolbar in staff side Still have not fixed the overlapping of titles. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77145|0 |1 is obsolete| | --- Comment #40 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 80250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80250&action=ed… Bug 8628: [FOLLOW-UP] Fixing internal server error and rebase issues This patch addresses the comments in Comment 23 Test that 1) all qa test tools pass 2) datatable on tools/signs.pl is not broken 3) features uses report group "SIGN" instead of "SIG" 4) you can complete the main test plan (no server errors) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77144|0 |1 is obsolete| | --- Comment #39 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 80249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80249&action=ed… Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77143|0 |1 is obsolete| | --- Comment #38 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 80248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80248&action=ed… Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80119|0 |1 is obsolete| | --- Comment #71 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 80246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80246&action=ed… [SIGNED-OFF] Bug 8630: (follow-up) Template corrections This patch makes two corrections to templates: One to correct the case of a variable, an error which I introduced when adding html filters. The other removes a redundant image tag from the recent comments template. To test, apply the patch and log in to the OPAC as a user with checkouts. Cover images on the "your summar" page should appear correctly. View the "recent comments" page and confirm that images still appear correctly. Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80111|0 |1 is obsolete| | --- Comment #70 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 80245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80245&action=ed… [SIGNED-OFF] Bug 8630: (follow-up) Make Adlibris cover show on OPAC overdues tab and fix alignment of cover on Staff detail page. Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '18

08 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #66 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 79951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79951 Bug 11373: Show the difference between the amount collected and the amount paid of a fine payment. Review of attachment 79951: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=113…) ----------------------------------------------------------------- Can one still overpay when using this system? What if the librarian finds they don't have the appropriate change in the drawer, can they continue with the transaction inputting the full amount and as such creating a credit? ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ +108,5 @@ > + <input id="collected" value="[% amountoutstanding | $Price %]"/> > + </li> > + <li> > + <label>Change to give: </label> > + <input id="change" value="0.00" disabled/> This shouldn't be an 'input' in my opinion, rather it should be more clearly distinguished as information.. perhaps a span with a class highlighting in 'red' if the patron is owed change? @@ +220,5 @@ > + <input id="collected" value="[% total | $Price %]"/> > + </li> > + <li> > + <label>Change to give: </label> > + <input id="change" value="0.00" disabled/> As above -- You are receiving this mail because: You are watching all bug changes.

1 0