October 2018 - Koha-bugs - lists.koha-community.org

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80089|0 |1 is obsolete| | --- Comment #346 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80262&action=ed… Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80088|0 |1 is obsolete| | --- Comment #345 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80261&action=ed… Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80087|0 |1 is obsolete| | --- Comment #344 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80260&action=ed… Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com --- Comment #343 from Nick Clemens <nick(a)bywatersolutions.com> --- Minor conflict, please clear and convert atomic update to perl (as in skeleton.pl) and make sure to use TableExists and ensure update is idempotent -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #34 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Sorry chaps, I get a `sha1 information is lacking or useless` error when trying to apply this patchset.. seems to be the second patch it falls over on and a manual `patch -p1` < also fails Marking as 'Patch doesn't apply' for now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #33 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Hmm.. on second thoughts I think this needs a bit more thought around how it may need to handle the 'type' argument that can be passed to the script.. I can see cases where one would want multiple runs of the script running side by side with distinct caller options. I'll ponder that a little and perhaps add it as a qa followup. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15537] Hide records on Leader 05 = d in OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- David, what's the status for this one? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #32 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 80256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80256 Bug 15529: Altered logic for lockfile creation Review of attachment 80256: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- Thanks for the super quick followup.. some minor issue which I'm happy to take care of as a qa followup. I'm just getting another qa to take a quick look to varify my understanding of the packages scripts then I'll do the followup and pass. ::: misc/cronjobs/process_message_queue.pl @@ +40,4 @@ > my $help = 0; > my $verbose = 0; > my $type = q{}; > +my $use_flock; I don't think this is needed.. unless we want to allow optionally falling back to not using lock files at all. @@ +96,5 @@ > + last if defined $LockFH; > +} > +if( !defined $LockFH ) { > + print "WARNING: Could not create lock file $lockfile: $!\n"; > + print "Please check your koha-conf.xml for ZEBRA_LOCKDIR.\n"; ZEBRA_LOCKDIR should be cron_lockdir here ;) @@ +98,5 @@ > +if( !defined $LockFH ) { > + print "WARNING: Could not create lock file $lockfile: $!\n"; > + print "Please check your koha-conf.xml for ZEBRA_LOCKDIR.\n"; > + print "Verify file permissions for it too.\n"; > + $use_flock = 0; # we disable file locking now and will continue As above, we're not intending on allowing use of this script without lock files after this patch.. I might get a second qa opinion on that, but I can't currently see a reason why we'd need to support a no-lock version. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19922] New: Reordering of fields in elasticsearch mapping configuration does not work
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19922 Bug ID: 19922 Summary: Reordering of fields in elasticsearch mapping configuration does not work Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/searchengine/elasticsearch/mapping s.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org If I navigate to /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl and try reordering fields under the 'Biblios' or 'Authorities' tabs, after clicking 'Save' the fields are still where they are to begin with. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #31 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi Martin Thanks for testing. I have taken a look at rebuild_zebra.pl and the patches on bug report 11078 and have implemented that logic for where the lock file is created. Can you please take a look and let me know if further changes are required to my followup patch I have just attached. Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0