October 2018 - Koha-bugs - lists.koha-community.org

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #33 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Hmm.. on second thoughts I think this needs a bit more thought around how it may need to handle the 'type' argument that can be passed to the script.. I can see cases where one would want multiple runs of the script running side by side with distinct caller options. I'll ponder that a little and perhaps add it as a qa followup. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15537] Hide records on Leader 05 = d in OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- David, what's the status for this one? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #32 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 80256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80256 Bug 15529: Altered logic for lockfile creation Review of attachment 80256: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=155…) ----------------------------------------------------------------- Thanks for the super quick followup.. some minor issue which I'm happy to take care of as a qa followup. I'm just getting another qa to take a quick look to varify my understanding of the packages scripts then I'll do the followup and pass. ::: misc/cronjobs/process_message_queue.pl @@ +40,4 @@ > my $help = 0; > my $verbose = 0; > my $type = q{}; > +my $use_flock; I don't think this is needed.. unless we want to allow optionally falling back to not using lock files at all. @@ +96,5 @@ > + last if defined $LockFH; > +} > +if( !defined $LockFH ) { > + print "WARNING: Could not create lock file $lockfile: $!\n"; > + print "Please check your koha-conf.xml for ZEBRA_LOCKDIR.\n"; ZEBRA_LOCKDIR should be cron_lockdir here ;) @@ +98,5 @@ > +if( !defined $LockFH ) { > + print "WARNING: Could not create lock file $lockfile: $!\n"; > + print "Please check your koha-conf.xml for ZEBRA_LOCKDIR.\n"; > + print "Verify file permissions for it too.\n"; > + $use_flock = 0; # we disable file locking now and will continue As above, we're not intending on allowing use of this script without lock files after this patch.. I might get a second qa opinion on that, but I can't currently see a reason why we'd need to support a no-lock version. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19922] New: Reordering of fields in elasticsearch mapping configuration does not work
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19922 Bug ID: 19922 Summary: Reordering of fields in elasticsearch mapping configuration does not work Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/searchengine/elasticsearch/mapping s.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org If I navigate to /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl and try reordering fields under the 'Biblios' or 'Authorities' tabs, after clicking 'Save' the fields are still where they are to begin with. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #31 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi Martin Thanks for testing. I have taken a look at rebuild_zebra.pl and the patches on bug report 11078 and have implemented that logic for where the lock file is created. Can you please take a look and let me know if further changes are required to my followup patch I have just attached. Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19305] New: 16.11.11 patron search is broken
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19305 Bug ID: 19305 Summary: 16.11.11 patron search is broken Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: In Discussion Severity: critical Priority: P2 Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: liz(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 18551 16.11.11 is missing this patch.. https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63546 ..currently patron search seems broken But the good news is that Katrin has pushed this to 16.11.12 and all you need to do to fix it is make the changes in the above patch to your running Koha, if you can't wait a month for the next minor release. This bug is only a placeholder so searches come up with relevant information. Liz Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551 [Bug 18551] Hide with CSS dynamic elements in member search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #30 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 80256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80256&action=ed… Bug 15529: Altered logic for lockfile creation Implemented logic for creating lockfile preventing a lock file being added to a logging directory. This patch adds logic (outlined below) similar to what is in use in rebuild_zebra.pl. The logic is: Create lockfile in either: 1. Location defined in config (cron_lockdir) OR 2. A standard location (/var/koha/cron_<instancename>) OR 3. /tmp/cron_<instancename> Sponsored-By: New Zealand Parliamentary Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #76 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Christopher Brannon from comment #74) > It should be returned to the exact state it was originally. It should not > be modified in any way by this module when inactive. If it was null before, > is should be returned to null. If it was a blank entry, it should be > returned to a blank entry. Well, thats a point in my qa comment. So theoretically you are right, but pragmatically we could move into the right direction with these changes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #75 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Nick Clemens from comment #72) > (In reply to Marcel de Rooy from comment #70) > > @RM: > > > > Passed QA but a bit 'reluctant or restrained'? > > This patch set improves things but imo this area needs more attention. > > See comment58 and the earlier comments/discussion. > > Scenario: > 1 - Define a new authorised value for CCODE with authorised value "" and > description "Blank space" > 2 - Create two (or more) items on a bib record, neither with ccode defined > 3 - Add one of those items to an enabled course > 4 - Disable the course > 5 - View the record > 6 - One item has no collection, the other has 'Blank space' > > Do we think this is okay? Edge case; could live with that.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20616] New: Using "Edit serials" with no issues selected gives an ugly error
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20616 Bug ID: 20616 Summary: Using "Edit serials" with no issues selected gives an ugly error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com To test: - create a subscrpition - go to the serials collection page - don't check any checkboxes for serials - click 'Edit serials' There will be an internal server error: Use of uninitialized value $serstatus in split at /home/vagrant/kohaclone/serials/serials-edit.pl line 100. Can't call method "title" on an undefined value at /home/vagrant/kohaclone/serials/serials-edit.pl line 423. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13