October 2018 - Koha-bugs - lists.koha-community.org

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #64 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 80107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80107&action=ed… Bug 8630: Adlibris covers (intranet templates) Changes to staff interface (intranet) templates. Depends on new CSS clases defined in separate patch. Test plan: To test this particular patch (intranet templates) you need: * The syspref patch applied * The intranet CSS patch applied To test: * Apply this patch * Enable covers (if not done already) * Go to staff interface, log in as a priviliged user. * Select "More" -> "Administration" -> "Global system preferences" -> "Enhanced content". * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris". * Save changes * Add a book with a known cover/ISBN (if none exists) * Set MARC field 020 a, "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935 * Set MARC field 245 a, "Title" to: 1984 * Save changes * Test results.tt * From the main intranet page, select "Search the catalog" and enter the title we added, "1984" and press "Search". * You should end up with the url: http://127.0.1.1:8080/cgi-bin/koha/catalogue/search.pl?q=1984 * The cover image should be shown in the leftmost column. * If cover is clicked, the full cover image should be shown. * Test detail.tt (continue from the search results used in prev. test) * Click on the title text, you should be sent to: http://127.0.1.1:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=2 * The cover image should be shown on the right. * If clicked, the full cover should be shown. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8630] Add covers from AdLibris to the OPAC and Intranet
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79989|0 |1 is obsolete| | Attachment #79990|0 |1 is obsolete| | Attachment #79991|0 |1 is obsolete| | Attachment #79992|0 |1 is obsolete| | Attachment #79993|0 |1 is obsolete| | Attachment #79994|0 |1 is obsolete| | --- Comment #63 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 80106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80106&action=ed… Bug 8630: Adlibris covers (syspref files) This patch adds a system preference for cover images from Swedish book retailer Adlibris. Images are retrieved via http or https from an external web server. This might leak OPAC and Staff interface data to third parties and should thus be used with caution. Sponsored-By: Halland County Library Test plan: Test 1: Test upgrade procedure for clean installation. Start by removing existing sysprefs, if present: $ mysql -u kohaadmin -p -D koha > DELETE FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; * Apply this patch which will add a pref file, update the 'syspref' structure and add an atomic upgrade file. * Install the update: Koha$ perl installer/data/mysql/updatedatabase.pl * Once upgraded and logged in, Select 'More', 'Administration', 'Global Preferences' and finally 'Enhanced content'. There should be a new option called 'Adlibris'. The first option should default to "Don't show", if not the patch is broken. The second options should show the default URL: http://www.adlibris.com/se/organisationer/showimagesafe.aspx If not, the patch is broken. Test 2: Changing sysprefs * In the control panel, change the first value from "Don't show" to "Show" and save the changes. Use MySQL client to inspect changes: $ mysql -u kohaadmin -p -D koha > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; The column 'value' should now have the value '1', if not the patch is broken. Test 3: Apply update to existing data * Re-execute the installer now that the database has the data already: Koha$ perl installer/data/mysql/updatedatabase.pl If any errors occur the patch is broken. Examine the database contents: $ mysql -u kohaadmin -p -D koha > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; If the values were overwritten by the installer the patch is broken. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #71 from Christopher Brannon <cbrannon(a)cdalibrary.org> --- (In reply to Marcel de Rooy from comment #58) > I am requesting another signoff here. > The third patch has no signoff line yet. > And additionally please tell me explicitly what you tested! > > I have been looking more carefully at CourseReserves.pm and I am not really > impressed by what I saw unfortunately. I have the impression that this patch > set might improve things a bit, but I am not sure if we break something else > now. > > Saw tricky things like: > push( @values, $params{$_} || undef ); > Together with constructions like: > foreach (@FIELDS) { > if ( defined($params{$_}) ) { > push( @fields_to_update, $_ ); > push( @values_to_update, $params{$_} ); > } > } > ModCourseItem adds an course item without affecting items or updates it and > does affect items. EnableOrDisable etc. etc. > The way we handle the data between items and course items is unclear. > Including handling empty string and null values. > > I am not unwilling to pass QA after another signoff but the traffic lights > will not be green :) Can you explain with more detail. I'm not sure everyone understands the concern. If we have a little bit more understanding of what this piece of code is doing, more of us can weigh in. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #337 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80100&action=ed… Bug 11897: (QA follow-up) Move menu to 'Catalog' Originally this menu item was placed under the 'Patrons' section of the tools page, this patch moves it to the more appropriate 'Catalog' section. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #336 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80099&action=ed… Bug 11897: (QA follow-up) Update of tools-menu.js Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #335 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80098&action=ed… Bug 11897: (QA follow-up) Fixes for JS12 Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80068|0 |1 is obsolete| | --- Comment #334 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80097&action=ed… Bug 11897: 'superlibrarian' has 'stockrotation' perms Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79975|0 |1 is obsolete| | --- Comment #333 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80096&action=ed… Bug 11897: (QA follow-up) Template filter fixes Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79973|0 |1 is obsolete| | --- Comment #332 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80095&action=ed… Bug 11897: Add sample notices for all languages Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 05 Oct '18

05 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79972|0 |1 is obsolete| | --- Comment #331 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80094&action=ed… Bug 11897: Use 'stockrotation' permission for the endpoint This patch makes the tests for 'authorized' session use the 'stockrotation' permission instead of 'superlibrarian'. The path x-koha-permission is fixed accordingly. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0