October 2018 - Koha-bugs - lists.koha-community.org

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 04 Oct '18

04 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #27 from M. Tompsett <mtompset(a)hotmail.com> --- I signed off Alex's having tested with all three. Alex has signed off mine having tests with all three. Marking as signed off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 04 Oct '18

04 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79910|0 |1 is obsolete| | --- Comment #26 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 79913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79913&action=ed… Bug 15529: Followup to send without more libraries This uses the letter_code parameter to limit the current duplicate run of the process_message_queue.pl script to just this one message. We don't care about receiving duplicate warning messages as much as we care about sending patrons duplicate messages. Works as described, passes QA test tool. Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 04 Oct '18

04 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79649|0 |1 is obsolete| | --- Comment #25 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 79912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79912&action=ed… Bug 15529 - Wrapping email sending up in the verbose flag Thus the cron email telling the administrator or support company that a second execution of the process_message_queue.pl cron whilst it is already running is only sent if it is wanted and verbose is set. Sponsored-By: New Zealand Parliamentary Library Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 04 Oct '18

04 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78918|0 |1 is obsolete| | --- Comment #24 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 79911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79911&action=ed… Bug 15529 - Locking process_message_queue.pl cron whilst it is running This amended patch is called by koha-common. koha-common runs this process_message_queue.pl cronjob foreach enabled Koha instance on the server. As this cronjob is run for every Koha instance the retrival of all Koha instance names from debian/scripts/koha-scripts in previous obsolete patches on this bug report and the looping through every name to check if the lock file existed is redundant. Instead this patch retrieves the 'logdir' of the Koha instance being iterated over and checks if the messagequeue.lock file in that directory is locked. If the aforementioned file is not locked then the SendQueuedMessages() in C4/Letters.pm is called, otherwise an email is sent (to the manually inputted email server, and to/from addresses) and duplicate execution of the cronjob is prevented. Test plan: 1. In two terminals open koha-shell and try to run ./process_message_queue.pl and notice you can run the script multiple times simulataneously without a warning/error being displayed 2. Apply patch and input the email server, to/from email addresses you would like the email to be sent to. Also confirm your Koha instance is enabled to send emails. 3. Repeat step 1 and notice that the second of the two scripts to be run will output text saying './process_message_queue.pl is already running. Exiting' In this case the aforementioned text is displayed and the body of the cronjob is not run. 4. The first cronjob script to run, runs without issues 5. At the end of the execution of the first script a 15 second pause is run 6. Notice you have received an email Sponsored-By: New Zealand Parliamentary Library Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #23 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 79910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79910&action=ed… Bug 15529: Followup to send without more libraries This uses the letter_code parameter to limit the current duplicate run of the process_message_queue.pl script to just this one message. We don't care about receiving duplicate warning messages as much as we care about sending patrons duplicate messages. Works as described, passes QA test tool. Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79726|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #22 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi M. Tompsett I have tested and your patch, in combination with my first two patches, works nicely. I will sign off on your patch, can you please do the same on my two patches. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #46 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think making it work with other 7xx could be a next step on a separate bug report. Also for the other 7xx there is more information in the record already about the linked items. From a set you often don't see much if anything about the children, so this appears to be the most urgent. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20400] New: Add routing list tab to the patron account in OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Bug ID: 20400 Summary: Add routing list tab to the patron account in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: katrin.fischer(a)bsz-bw.de Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 62

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #428 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 79909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79909&action=ed… Bug 7143: Update about page for new dev - Cori Lynn Arnold` -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0