October 2018 - Koha-bugs - lists.koha-community.org

[Bug 15282] Switch default CHECKIN notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59615|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 79866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79866&action=ed… Bug 15282 - Switch default CHECKIN notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKIN notice to match the following: The following items have been checked in: ---- [% biblio.title %] ---- Thank you. 3) Generate a CHECKIN notice for a patron 4) Note there is no change to the generated notice Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15282] Switch default CHECKIN notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15282] Switch default CHECKIN notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15282 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57174|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15280] Switch default CHECKOUT notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59614|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 79864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79864&action=ed… Bug 15280 - Switch default CHECKOUT notice to Template Toolkit Test Plan: 1) Ensure dependancies are applied 2) Apply this patch 3) Update your CHECKOUT notice to match the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 3) Generate a CHECKOUT notice for a patron 4) Note there is not change to the generated notice Signed-off-by: Mirko Tietgen <mirko(a)abunchofthings.net> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15280] Switch default CHECKOUT notice to Template Toolkit
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #11) > Tests are missing anyhow. (In reply to Marcel de Rooy from comment #26) > See Comment11 too. We still need additional unit testing. And... still missing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9968] Fix Standard number search to use correct index
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9968 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75351|0 |1 is obsolete| | --- Comment #5 from Michal Denar <black23(a)gmail.com> --- Created attachment 79862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79862&action=ed… Bug 9968: Fix wrong index for Standard number in advanced and label search 'Standard number' indicates that you can search ISBN, ISSN and other standard numbers, but we are using the wrong index and only get a very limited search for biblionumber instead. This patch changes the index from sn to ident. To test: - Check both staff and OPAC advanced search: - Search for Standard number = ISBN - Search for Standard number = ISSN Both should work. Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences - Check the label creator - Add a new batch - Use 'add items' option and search for Standard number Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9968] Fix Standard number search to use correct index
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9968 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #43 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Olli-Antti Kivilahti from comment #41) Are you going to adopt this? It would be great! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '18

03 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #42 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Olli-Antti Kivilahti from comment #41) > (In reply to Josef Moravec from comment #38) > > Do not return explicit undef > > Could you elaborate a bit why returning undef is bad? It could lead to unexpected results, see: https://metacpan.org/pod/Perl::Critic::Policy::Subroutines::ProhibitExplici… https://perlmaven.com/how-to-return-undef-from-a-function We even have it in our guidelines (this policy is part of perlcritic severity 5): https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL4:_Perlcritic -- You are receiving this mail because: You are watching all bug changes.

1 0