October 2018 - Koha-bugs - lists.koha-community.org

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '18

02 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79790|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '18

02 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79796|0 |1 is obsolete| | --- Comment #61 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 79797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79797&action=ed… Bug 14715: (follow-up) some code changes 1) adds sysprefs to sysprefs.sql 2) removes a merge conflict error that should not have been added -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '18

02 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #60 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 79796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79796&action=ed… Bug 14715: (follow-up) some code changes 1) adds sysprefs to sysprefs.sql 2) removes a merge conflict error that should not have been added -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '18

02 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #102 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 79791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79791&action=ed… Bug 8367: Template fixes + fixes to C4/Reserves.pm and Koha/Hold.pm Fixed waitingreserves.tt template so the borrowernumber is successfully passed to waitingreserves.pl upon cancelling a hold, so users can now successfully cancel holds from the waitingreserves.pl interface. Removed check for ReserveMaxPickupdateDelay in Koha/Hold.pm as this syspref is removed in the previous patch. Instead the expirationdate is calculated the same way as the lastpickupdatedate that is retrieving the holdpickupwait value for the appropriate issuingrule and then adding that onto the waiting date. Same test plan as main patch Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '18

02 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #101 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 79790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79790&action=ed… Bug 8367: How long is a hold waiting for pickup at a more granular level You can now specify a pickup delay for an hold function of a patron category and/or a item type and/or a library. The lastpickupdate-column is set based on the given instruction and lands only on an open library day. Also cancel_expired_reserves.pl now cancels only on open library days after the last pickup date has expired. And waitingreserves.pl respects the new DB column. If ReservesMaxPickUpDelay is not set prior to the databaseupdate, the holdspickupwait-directive is never defined, thus disabling this feature until the holdspickupwait is set. If the issuingrules holdspickupwait is 0 or less, this feature is disabled. So each issuingrule can disable this feature for the material it matches, while being fully functional with other rules. This patch adds: - a new column in the issuing rules, including help topics. - a new column reserves.lastpickupdate (+old_reserves) It contains the waitingdate + the corresponding "holds pickup wait". Each time the waitingdate is modified, this value will be modified too. - a new field issuingrules.holdspickupwait - a new function C4::Reserves::MoveWaitingdate() to help in testing this feature. - a new function C4::Reserves::GetLastPickupDate() to calculate the proper date from Calendar. This patch removes: - the ReservesMaxPickUpDelay syspref. - the ExpireReservesOnHolidays syspref, because it became obsolete due to the changes in handling the last pickup date with Koha Calendar. - Also removes a code section from C4::Letters::_parseLetter() which worked blatantly disrespectfully towards Koha Calendar. - TODO figure out how to rename existing letter placeholders <<expirationdate>> with <<lastpickupdate>> Unit tests included. $$$$$$$$$$$$$ $ TEST PLAN $ $$$$$$$$$$$$$ 0. BEFORE UPDATING THE DATABASE! MAKE SURE THAT THE SYSPREF 'ReservesMaxPickUpDelay' is bigger than 0. Otherwise existing reserves won't get UPDATEd with the new lastpickupdate-values. ****** ****** *** *** *** TEST: BASIC WORKFLOW * ****** ****** 1. Check there is no regression with a normal reserve workflow. 2. Add one or more issuingrules. 3. Update the new column 'Holds pickup wait' in your issuing rules. 4. In the 3 templates of staff client, you can see the 'Last pickup date' for an hold (circ/circulation.pl, circ/waitingreserves.pl, members/moremember.pl) 5. In opac-user.pl the last pickup date is displayed in the status-column if available. 5. According to a library and an item type, the lastpickupdate value will be equal to the waiting date + the "holds pickup wait" defined moved to the next open library day. ****** ****** *** *** *** TEST: LETTER PLACEHOLDER (no code modifications here, just regression)* ****** ****** 1. Modify the RESERVESLIP->email Letter. Add "Last pickup date<<reserves.lastpickupdate>>" somewhere. 2. Make a hold for a borrower. 3. Catch the hold and print the reserve slip. Verify that the lastpickupdate is actually the (current date + the 'Holds pickup wait' in your issuing rules) in days. ** ** ** ** ** ** *** *** *** TEST: RESPECTING CALENDAR HOLIDAYS * ** ** ** ** ** ** 1) Note your ReservesMaxPickUpDelay setting. 2) Create and trap a hold 3) View waitingreserves.pl, note the last pickup date, and the pickup location 4) Cancel this hold 5) Edit the calendar for the given location, and make the pickup date a single, unrepeated, holiday. Then make the next day a weekly repeating holiday. Then make the next two days an annual holiday repeatable every year. 6) Repeat step 2 7) View waitingreserves.pl, the last pickup date for this new hold should now be increased by four days. ** ** ** ** ** ** *** *** *** TEST: LETTER lastpickupdate PLACEHOLDER AND REGRESSION * ** ** ** ** ** ** 1. Modify the HOLD-letter, add <<reserves.lastpickupdate>> and <<reserves.waitingdate>> somewhere. 2. Catch a hold for a borrower. 3. See the members/notices.pl for the message queued and verify that the lastpickupdate-placeholder is set in your desired datetime format and that it is not on a holiday. Verify that the waitingdate is today. Conflicts: installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '18

02 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42754|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '18

02 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley(a)catalyst.net.nz Status|Patch doesn't apply |ASSIGNED --- Comment #100 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi there I have gone through and rebased this, master had progressed quite a lot since this patch was added and so I had to make a few assumptions during the rebase. Please let me know if changes need to be made as a result of the rebase. I have also corrected the commit messages to the format 'Bug XXXX: ' I have also written two other patches which correct template issues, and remove the check for the value of the 'ReserveMaxPickupDelay' syspref in Koha/Hold.pm in the set_waiting() function. This check is unneccessary as the main patch on this bug report removes the ReserveMaxPickupDelay syspref, and so I replaced this with a retrieval of the appropriate issuingrule and setting the exprationdate = waitingdate + issuingrule.lastpickupwait I am currently working on the unit tests t/db_dependent/Hold.t and so I am assigning this the status of 'Assigned' until I have attached a commit with the corrected t/db_dependent/Hold.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Add additional template filter methods and a filter presence test to Koha
by bugzilla-daemon＠bugs.koha-community.org 02 Oct '18

02 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #260 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #259) > A new check to catch missing filters is not in the QA script, please update! s/not/now/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20899] New: Patron name not showing on issuehistory.pl
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '18

01 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 Bug ID: 20899 Summary: Patron name not showing on issuehistory.pl Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: liz(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Even with the prefs set to show the name, the name doesn't seem to be showing here since the feature for groups was pushed. To replicate: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is not showing here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 15139] Show non-public item note in overdues report
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '18

01 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79034|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 79784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79784&action=ed… Bug 15139: Add non-public item notes to overdue report Sometimes libraries want to see internal notes on the overdue reports page, this patch adds the notes. Additional fixes: - Library column was always empty, now library displays - Replacement price was not formatted according to CurrencyFormat To test: - Make sure you have some overdue issues in your system - Circulation > Overdues report - Make sure everything displays as it should - Verify internal item note shows - Verify price is correctly formatted (syspref CurrencyFormat) - Library shows - Download list of overdues - Verify the new column displays Signed-off-by: Spencer <ssmith3(a)mckinneytexas.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Amended patch: remove the branchcode line, added on its own bug report, see bug 21463 -- You are receiving this mail because: You are watching all bug changes.

1 0