October 2018 - Koha-bugs - lists.koha-community.org

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '18

01 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79211|0 |1 is obsolete| | --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> --- Created attachment 79777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79777&action=ed… Bug 9775: Unitprice should be hidden when creating an order The actual cost box is effectively hidden from the order page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '18

01 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 --- Comment #6 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- So, 'unitprice' is the database column name, 'actual cost' is the phrase used in the UI with default en language out of the box. Sorry for the confusion there, I should have added a clear testplan. As for decimal issues, I agree that is a terrible issue. I think there are a few bugs around it already though.. perhaps you could comment on bug 17098, 12310 or 18723..? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '18

01 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> --- Hi Martin, Sorry for the confusion. There were two points to my comment. 1) is unitprince and Actual Cost the same thing? I only see Actual Cost on my system, so I'm assuming it's the same 2) On the orderreceive.pl page, if I try to change the actual cost (which is set by default to the vendor price), no matter what decimal symbol I use, it is not taken into account. 20.99 becomes 2099.00 So if your patch is only to remove actual cost from the order form, it works. But the decimal problem is very serious, imo. Should I file another bug? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '18

01 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 --- Comment #4 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Slightly confused by your comment Caroline. This patch should just remove the 'actual cost' on the new order forms. The reasoning behind this is that this actual cost is intended to only be set at the point of invoice when it is definitive. Where are you entering numbers and finding decimal issues creeping in.. that may well be another bug.. in. The orderrecieve form perhaps? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '18

01 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #62 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- The code is simpler and the formating is only on new lines. The change comment is similar to the others and is not related to the bug, so it has not been changed. A dialog box has been added, it's possible to reconfirm or not the payment when the change isn't 0.00. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '18

01 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79549|0 |1 is obsolete| | --- Comment #61 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Created attachment 79759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79759&action=ed… Bug 11373: Show the difference between the amount collected and the amount paid of a fine payment. This patch adds a feature in the fine payment section. It allows to see the change due to patrons when the amount collected is higher than the amount paid. This includes also a new system preference called FineChange which enables or disables the feature. Test plan : - Apply patch. - Make sure FineChange is at ENABLE in System preferences > Patrons. - Select a patron with a fine. - Go to Fines > Pay fines. - Click the button pay. - Choose the amount paid equal to the outstanding amount (exemple : 3$). - Choose the amount collected to be more than the outstanding amount (exemple : 5$). - Confirm that the change is correct (example : 5$ - 3$ = 2$). - Click the button confirm. - Click on Yes in the dialog box. - Confirm that the payment has been made (example : last amount = 3$). - Make sure FineChange is at DISABLE in System preferences > Patrons. - Select a patron with a fine and go to Fines > Pay fines. - Confirm that the inputs paid and change are gone. - Choose an amount collected (exemple : 3$). - Click the button confirm. - Confirm that the payment has been made. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '18

01 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23(a)gmail.com --- Comment #54 from Michal Denar <black23(a)gmail.com> --- Please, rebase on master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '18

01 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79742|0 |1 is obsolete| | --- Comment #309 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 79750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79750&action=ed… Bug 11897: Stockrotation The stock rotation feature adds a batch process to automate rotation of catalgue items with a staff client page under tools to manage rotas/schedules. Once a rota is configured, and your staff user has the right permissions to allocate items, then an additional tab will appear on biblio records allowing the management of of which rota, if any, individual items belong to. It also includes a cron script to process the items on a daily basis. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '18

01 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79741|0 |1 is obsolete| | --- Comment #308 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 79749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79749&action=ed… Bug 11897: Add Boolean handling to dbic classes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 01 Oct '18

01 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79740|0 |1 is obsolete| | --- Comment #307 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 79748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79748&action=ed… Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0