December 2018 - Koha-bugs - lists.koha-community.org

[Bug 22003] New: Remove unused subroutines displaylog and GetLogStatus from in C4::Log
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '19

14 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22003 Bug ID: 22003 Summary: Remove unused subroutines displaylog and GetLogStatus from in C4::Log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org These two subroutines are not used in our codebase. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 21980] New: Add some new Exceptions for Koha::Account methods
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '19

14 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21980 Bug ID: 21980 Summary: Add some new Exceptions for Koha::Account methods Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org We aren't validating as much as we should in the add_credit and upcoming add_debut and adjust methods in the Koha::Account classes. This bug adds a couple of new exceptions for such cases. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 16666] New: TagsExternalDictionary is a rather confusing preference name
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16666 Bug ID: 16666 Summary: TagsExternalDictionary is a rather confusing preference name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com You do not pass an external dictionary (file) into this syspref. You actually pass the location of ispell on your box. If you have ispell but do not enter its path here, the pref does not trigger the spell check. So it is also enable/disable ispell. Tags.pm requires the Ispell module; it is not a mandatory depends. Furthermore the pref description says: Allow tags in the dictionary of the ispell executable on the server to be approved without moderation. So I would not mind a better name :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 21813] New: In-page JavaScript causes error on patron entry page
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21813 Bug ID: 21813 Summary: In-page JavaScript causes error on patron entry page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 19641 There is an in-page block of JavaScript which should have been dealt with when Bug 19641 moved the template's JavaScript to the footer. Its position on the page causes a JavaScript error because jQuery hasn't loaded yet. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 21796] New: Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '19

11 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21796 Bug ID: 21796 Summary: Patron Restriction do not restrict checkouts if patron also has a fee/fine on their account Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 82109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82109&action=ed… with both restriction and fine, checkout box is visible. Prior behavior: when a patron has a restriction added to their account, the ability of checking out has been removed. The checkout box is replaced by a "View restriction" box and an "Override Restriction Temporarily" box option. If Override is chosen, then the patron's checkout box will reappear for that session. Currently in Koha 18.05.05, when a patron has a restriction, this behavior described above happens correctly. However, if a patron also has a fine of a dollar amount in addition to the restriction, the checkout box is now visible allowing checkouts to occur. The fine/fee amount can be any amount- this does not seem to correlate with the noissuecharge system preference. For an example, system preference Noissuecharge set at 20.00, the value of $2.00 fine was attached to the patron and a restriction, the checkout box still appeared. If a fine/fee was above the noissuecharge, this same behavior occurred- the checkout box appears. See screenshot of bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 21436] New: Switch two-column templates to Bootstrap grid: Tools part 4
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21436 Bug ID: 21436 Summary: Switch two-column templates to Bootstrap grid: Tools part 4 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 20654 These two-column tools templates can be updated to use the Bootstrap grid. - tools/scheduler.tt - tools/showdiffmarc.tt - tools/stage-marc-import.tt - tools/upload-images.tt - tools/upload.tt - tools/viewlog.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 15899] New: Remove the use of recordpayment
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15899 Bug ID: 15899 Summary: Remove the use of recordpayment Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org With recordpayment now simply being a wrapper round Koha::Account::pay, we can remove the calls to recordpayment and replace them with direct calls to Koha::Account::pay. -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 18580] New: Account-pay does not apply credits / clear old fines as did recordpayment
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18580 Bug ID: 18580 Summary: Account-pay does not apply credits / clear old fines as did recordpayment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com the recordpayment routine in C4::Accounts cleared old paid fines and applied credit amounts as part of its pay routine. The behaviour was implicit and not signalled or commented in the code. The pay routine in Koha::Account which is now called by paycollect.pl instead of the old routine does not leaving these on the users fine display although they owe 0. Staff cannot manually remove these. For example a user has the following accountlines +-----------+-------------+-------------------+ | amount | accounttype | amountoutstanding | +-----------+-------------+-------------------+ | -1.300000 | C | -1.300000 | | 0.650000 | Res | 0.650000 | | 0.650000 | Res | 0.650000 | | 0.650000 | Res | 0.650000 | +-----------+-------------+-------------------+ after recordpayment has been called with an amount of 0.65 the lines are +-----------+-------------+-------------------+ | amount | accounttype | amountoutstanding | +-----------+-------------+-------------------+ | -1.300000 | C | 0.000000 | | 0.650000 | Res | 0.000000 | | 0.650000 | Res | 0.000000 | | 0.650000 | Res | 0.000000 | | -0.650000 | Pay | 0.000000 | +-----------+-------------+-------------------+ However now calling Account->pay for the same amount results in +-----------+-------------+-------------------+ | amount | accounttype | amountoutstanding | +-----------+-------------+-------------------+ | -1.300000 | C | -1.300000 | | 0.650000 | Res | 0.000000 | | 0.650000 | Res | 0.650000 | | 0.650000 | Res | 0.650000 | | -0.650000 | Pay | 0.000000 | +-----------+-------------+-------------------+ leaving the credit and two fines with an amountoutstanding although the user has nothing to pay (the amountoutstanding columns sum to 0) and leading to misleading displays. The difference is driven by the line where @outstanding_fines is retrieved the selection is amountoutstanding > 0. In recordpayment it was amountoutstanding <> 0 so that negative amounts were included and processed as part of the payment, rather than ignored. The fact that this implicit behaviour was not commented made it easy to miss. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 21788] New: C4::Circulation::ProcessOfflinePayment should pass library_id to ->pay
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21788 Bug ID: 21788 Summary: C4::Circulation::ProcessOfflinePayment should pass library_id to ->pay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Bug 19066 introduces the new column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 21786] New: Routes for credits should include library_id
by bugzilla-daemon＠bugs.koha-community.org 10 Jan '19

10 Jan '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21786 Bug ID: 21786 Summary: Routes for credits should include library_id Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26