December 2018 - Koha-bugs - lists.koha-community.org

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80248|0 |1 is obsolete| | --- Comment #44 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 82898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82898&action=ed… Bug 8628: (follow-up) More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77142|0 |1 is obsolete| | --- Comment #43 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 82897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82897&action=ed… Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8628] Add digital signs to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77141|0 |1 is obsolete| | --- Comment #42 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 82896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82896&action=ed… Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #82 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- (In reply to Aleisha Amohia from comment #74) > Also need to add a fail message for when authtypecodes do not match on > import. Upon further testing, I've realised that this is no longer an issue. You CAN import a file with unmatching authtypecodes and it will work and fix up the authtypecode in the import - it just takes a little while. I have added a note to the popup so the user expects to wait a few minutes. This is ready to test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #81 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 82895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82895&action=ed… Bug 13952: (follow-up) template filters, moving js to separate file This patch adds filters to the template file and moves the JS into a separate file. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '18

06 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21775] New: Lack of tests for audio alerts
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '18

05 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21775 Bug ID: 21775 Summary: Lack of tests for audio alerts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org This code is not reliable, we faced too many regressions. We need a Selenium test to cover it and prevent future regressions -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '18

05 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 --- Comment #5 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 82874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82874&action=ed… Bug 15422: Consider partial copies needed as whole numbers Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15422] Number of items to order on holds ratio report will not fulfill the holds ratio.
by bugzilla-daemon＠bugs.koha-community.org 05 Dec '18

05 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15422 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82718|0 |1 is obsolete| | Attachment #82842|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 82873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82873&action=ed… Bug 15422: Correct calculation of holds ratio report See comment 1 for a detailed explanation of current calculations and needed calculations Also removes an unnecessary variable To test: 1 - Place 4 holds on a biblio with one item 2 - go to /cgi-bin/koha/circ/reserveratios.pl (Circulation->Holds ratios) 3 - Run with 'Hold ratio'=3, it says order 1, ok 4 - Run with HR=4, it says order 1, wrong 5 - Run with HR=2, it syas order 2, wrong 6 - Run with HR=.5, it syas order 4, wrong 7 - Apply patch 8 - Run with HR=3, order 1, OK 9 - Run with HR=4, item does not appear (0 to order), OK 10 - Run with HR=2, order 1, OK 11 - Run with HR=.5, order 7, OK Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0