February 2018 - Koha-bugs - lists.koha-community.org

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65224|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71703&action=ed… Bug 15253 - Log stderr via Koha::Logger as well By logging stderr to the log file, we can much more easily find and debug errors in the SIP server. Stderr has its own category STDERR so these messages can easily be filtered out of the log if need be. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65223|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 71702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71702&action=ed… Bug 15253 - Add Koha::Logger based logging for SIP2 Original version from khall rebased and modified for Log::Log4perl MDC Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipser to the namespace so we can allow for separate files per sip user if wanted. Also modifies the log4perl.conf to lazy-open filehandles to log files, so the same config can be used with log-files needing different permissions. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Depends on| |18789 CC| |josef.moravec(a)gmail.com --- Comment #1 from Josef Moravec <josef.moravec(a)gmail.com> --- Should be removed and functionality added to Koha::Patron Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 [Bug 18789] Send a Koha::Patron object to the templates -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #28 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here now No reply from the author on the last comment! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20166] New: Untranslatable course reserves delete prompt
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20166 Bug ID: 20166 Summary: Untranslatable course reserves delete prompt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: pasi.kallinen(a)joensuu.fi QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Having a Template Toolkit statements inside the javascript translation function _() prevents it from being picked for translation. The only example of such is the course reserve delete prompt. To see if there are other such TT statements: rgrep -E '\b_\("[^"]*\[%' koha-tmpl/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 20156] New: Staff client header language menu doesn't show check mark for current language
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20156 Bug ID: 20156 Summary: Staff client header language menu doesn't show check mark for current language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The markup for the staff client header's language menu is supposed to show a check mark next to the currently-selected language. Because of copy-paste from the OPAC (which uses Glyphicons), the check mark doesn't appear. It should use Font Awesome. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 20134] New: Remove /api/v1/app.pl from the generated URLs
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20134 Bug ID: 20134 Summary: Remove /api/v1/app.pl from the generated URLs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com The REST api is exposed using /api/v1, but that is rewritten to hit /api/v1/app.pl/api/v1 (app.pl being a Mojolicious::Command wrapper for running in Mojolicious under Plack). The problem is that Mojolicious then creates URLs containing that unneeded /api/v1/app.pl prefix. We should strip that out. To reproduce: - Point your browser to http://your_host_name/api/v1/ (don't forget about the trailing slash) => FAIL: Notice basePath: "/api/v1/app.pl/api/v1" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 19928] New: Acquisitions' CSV exports should honor syspref "delimiter "
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Bug ID: 19928 Summary: Acquisitions' CSV exports should honor syspref "delimiter" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor.grousset(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org 1. Set syspref "delimiter" to "tabs" 2. Create a vendor with minimal info 3. Create a basket with minimal info 4. Go to the basket. URL should be /cgi-bin/koha/acqui/basket.pl?basketno=XXXXX 5. "Export as CSV" 6. You should see that the file contains commas "," This is the bug. 7. Create a basket group with minimal info 8. Close this basket group 9. Go to the "Closed" tab to see your basket group 10. "Export as CSV" 11. You should see that the file contains commas "," This is the bug. 12. Create a basket with minimal info 13. Add a item to the basket 14. Close the basket 15. Go to /cgi-bin/koha/acqui/lateorders.pl 16. "Export as CSV" 17. You should see that the file contains commas "," This is the bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 57

[Bug 20124] New: Allow translating did you mean config save message
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20124 Bug ID: 20124 Summary: Allow translating did you mean config save message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: pasi.kallinen(a)joensuu.fi QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr When saving the "Did you mean?" setting, a popup with the message "Successfully saved configuration" is shown, but it cannot be translated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 20109] New: Allow translating "Remove" in Add Fund
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20109 Bug ID: 20109 Summary: Allow translating "Remove" in Add Fund Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: pasi.kallinen(a)joensuu.fi QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr When a user has been added to the fund, the link to "Remove" that user is not translatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10