February 2018 - Koha-bugs - lists.koha-community.org

[Bug 15191] Serials display improvements
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '18

08 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15191 Chris Slone <cslone(a)camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '18

08 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 Jessie Zairo <jzairo(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10858] Browse selected biblios - OPAC
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '18

08 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '18

08 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #33 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches work as expected. I signed off the patches but I think another sign-off from a MARC21 expert would be great. A few comments on the code: - I think that the subroutine controlled_indicators doesn't belong in Koha::Authority. The FIXME added in C4::AuthoritiesMarc strengthens that opinion - In Koha::Authority::ControlledIndicators, there is a package variable $cached_indicators. Maybe this module should use Koha::Cache instead ? Also, I'm not sure if this is a problem, but it seems that there is no way to tell Koha to change only one of the two indicators. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '18

08 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71343|0 |1 is obsolete| | --- Comment #32 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71355&action=ed… Bug 14769: Put ControlledIndicators to work This patch does: [1] Adds Koha::Authority->controlled_indicators (with a test). [2] Adds a call to controlled_indicators in AuthoritiesMarc::merge. Unit test Merge.t is extended too. [3] Simplifies the code in authorities/blinddetail-biblio-search.pl by calling controlled_indicators. Test plan: [1] Run t/db_dependent/Koha/Authorities.t [2] Run t/db_dependent/Authority/Merge.t [3] Steps 3 to 7 for MARC21: Create a PERSO_NAME authority with 008/11=r and ind1=3 [4] Edit a biblio and add a 600 linked to the new authority. [5] Verify that the biblio has ind1==3 and ind2==7 and $2==aat. (If $2 is not visible, check the metadata in biblio_metadata.) [6] Edit the PERSO_NAME authority and change 008/11 to '|' (bar). [7] Verify that merge updated your biblio record: $ind2==4 and $2 gone. [8] UNIMARC: Follow the pattern from steps 3 to 7. Create authority, link it in a biblio, check indicators (they should be copied both). Edit authority, change indicators and verify the merge results in the biblio record. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested PERSO_NAME and UNIF_TITLE. For UNIF_TITLE the second authority indicator is copied to ind1 or ind2, depending on the biblio tag involved. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '18

08 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71342|0 |1 is obsolete| | --- Comment #31 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71354&action=ed… Bug 14769: Add preference AuthorityControlledIndicators Including: [1] Atomic update to add pref for existing installs [2] Add new pref to sysprefs.sql for new installs [3] Add description to authorities preference file. Test plan: [1] Run new install or upgrade to add pref. [2] Check value of pref via System preferences in staff interface. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '18

08 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71341|0 |1 is obsolete| | --- Comment #30 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71353&action=ed… Bug 14769: Add tests for _thesaurus_info in ControlledIndicators.t Apart from adding tests for this sub, we make the following change too and support it with a test. The fallback to $code in the construction $thes_mapping{ $code } // $code // '4' is removed by this patch. When $code is not in $thes_mapping, we cannot assume that it is a valid code for a biblio indicator. In this case it is more safe to mark it as 4 (Source not specified). Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '18

08 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71340|0 |1 is obsolete| | --- Comment #29 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71352&action=ed… Bug 14769: Biblio indicators based on authority's thesaurus code Original patch from Janusz Kaczmarek on November 24, 2017. Amended by Marcel de Rooy on February 6, 2018. Code moved from AuthoritiesMarc.pm to ControlledIndicators.pm. Special attention has been paid to the proper application of 008/11 while controlling 6XX in MARC 21, specially if 008/11 =~ /[rsz]/ (and if it is 'z' and 040 $f is defined). Test plan: See next patch. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> The construction $thes_mapping{ $code } // $code // '4' will still get some attention on a follow-up. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '18

08 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71339|0 |1 is obsolete| | --- Comment #28 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71351&action=ed… Bug 14769: Introduce Koha::Authority::ControlledIndicators This module reads its settings from pref AuthorityControlledIndicators. The get method allows you to retrieve indicator values for specific biblio fields. Test plan: Run t/Koha/Authority/ControlledIndicators.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 08 Feb '18

08 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #90 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes.

1 0