February 2018 - Koha-bugs - lists.koha-community.org

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '18

06 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #182 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '18

06 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61026|0 |1 is obsolete| | --- Comment #181 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71268&action=ed… Bug 11708: Move acq related Koha::Objects to Koha::Acquisition namespace and fix Koha::Acquisition::Order usage everywhere -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '18

06 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61025|0 |1 is obsolete| | --- Comment #180 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71267&action=ed… Bug 11708: UT: Use DateTime instead of localtime+sprintf -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '18

06 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61024|0 |1 is obsolete| | --- Comment #179 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71266&action=ed… Bug 11708: UT: Replace 'ok' by 'is' where appropriate -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '18

06 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61023|0 |1 is obsolete| | --- Comment #178 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71265&action=ed… Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. In the process, this patch adds 4 new "Koha::Object" modules: - Koha::Bookseller(s) - Koha::Basket(s) - Koha::Basketgroup(s) - Koha::Order(s) It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '18

06 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61022|0 |1 is obsolete| | --- Comment #177 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71264&action=ed… Bug 11708: Place "Basket groups" menu entry on top of the side navigation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '18

06 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61021|0 |1 is obsolete| | --- Comment #176 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71263&action=ed… Bug 11708: Remove column aqbasketgroups.closed It is redundant with aqbasketgroups.closeddate Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Patch updated: use atomic update -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '18

06 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61020|0 |1 is obsolete| | --- Comment #175 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71262&action=ed… Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '18

06 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61019|0 |1 is obsolete| | --- Comment #174 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71261&action=ed… Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '18

06 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61018|0 |1 is obsolete| | --- Comment #173 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 71260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71260&action=ed… Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Patch updated: Use atomic update -- You are receiving this mail because: You are watching all bug changes.

1 0