March 2018 - Koha-bugs - lists.koha-community.org

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18723 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 [Bug 18723] Dot not recognized as decimal separator -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20394] New: Koha hangs when importing a .koc file containing a non-existent barcode
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20394 Bug ID: 20394 Summary: Koha hangs when importing a .koc file containing a non-existent barcode Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: chris(a)stayawake.co.uk QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Koha hangs when importing a .koc file containing a non-existent barcode How to reproduce the bug: 1. Manually create an offline circulation file (.koc file) containing an item barcode that isn't in the database 2. Import it into koha (Circulation -> Upload offline circulation file (.koc)) The operation hangs indefinitely with CPU usage pinned around 80%. This behavior has been seen on Koha 17.05 and 17.11 This is a low-impact bug, but could occur if a barcode is mistyped when using the offline circulation tool. (Our bar codes aren't actually barcodes but 4-digit numbers which have to be entered manually) Chris Brown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 19771] New: Pending offline circulation actions page will crash on unknown barcode
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771 Bug ID: 19771 Summary: Pending offline circulation actions page will crash on unknown barcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: matthias.meusburger(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Test plan: Use the koct firefox plugin or a .koc file and make a return with an unknown barcode. Display the Pending offline circulation actions page: offline_circ/list.pl => The page crashes with a software error: Can't call method "biblio" on an undefined value at /home/koha/src/offline_circ/list.pl line 50. Apply the patch, repeat the test plan. => The page shows the list correctly. Click on process. The unknown barcode is marked as Item not found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 9290] Restricting patron category for online purchase suggestion
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '18

26 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 --- Comment #8 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Maybe instead of using a yes/no setting on patron category, you could use a number of allowed suggestions. There already is already a global setting for this, that might be extendable in this way: MaxOpenSuggestions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19999] New: use Modern::Perl in Labels perl scripts
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '18

25 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19999 Bug ID: 19999 Summary: use Modern::Perl in Labels perl scripts Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org use Modern::Perl should be used instead of use strict; use warnings; Relevant in: label-create-csv.pl label-create-pdf.pl label-create-xml.pl label-edit-batch.pl label-edit-layout.pl label-edit-profile.pl label-edit-template.pl label-home.pl label-item-search.pl label-print.pl spinelabel-home.pl spinelabel-print.pl -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 12227] Remove demo user functionality
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '18

25 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12227 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|remove demo user |Remove demo user |functionality |functionality CC| |katrin.fischer(a)bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '18

24 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #54 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Victor, should this be Needs Signoff? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '18

23 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73055|0 |1 is obsolete| | --- Comment #53 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 73215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73215&action=ed… Bug 12310 : Decimal separators issues: some fixes in fines and acquisitions The main aim is to prevent - x100 or /100 of the amounts - decimal part truncation Fixes Bug 19521 - Partial fine payment is not working with comma decimal separator But not Bug 18723 - Dot not recognized as decimal separator (aquisitions) It will be done in a follow up patch. This one is already too huge to test. Bonuses: - get rid of the spaces, currency symbols, names (EUR) It handles: - by default comma and dot as decimal separators on the same instance - dot or comma as thousands separators if choose to use only one of them as decimal separator. See DigitSeparator syspref. == Test plan == 1. In the manual invoice (cgi-bin/koha/members/maninvoice.pl) 2. Apply the annex 1 to the "Amount" field 3. When paying a fine (cgi-bin/koha/members/paycollect.pl) 4. Click on "Pay amount" to go to the page to pay all fines 5. Apply the annex 1 to the "Collect from patron" field 6. Click on "Pay" to go to the page to pay fine 7. Apply the annex 1 to the "Collect from patron" field 8. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl) 9. Apply the annex 1 to the "Amount" field 10. Go to the "Add budget" page staff://cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form 11. Apply the annex 1 to the "Total amount" field 12. Create an active budget 13. Go to the "Add Fund" page for this budget 14. Apply the annex 1 to the "Amount" field 15. Apply the annex 1 to the "Warning at (amount)" field 16. If you have ideas of stuff to try to find *regressions* from the previous versions, then try. You might spare librarian tears by finding something before it's released. 17. Express your happiness. This is important, otherwise the signoff spell won't work! The details of expressing your happinnes depends on your culture and habits. === Annex 1: Subpart for each concerned page === 1. Set DigitSeparator syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not changing the page. 4. Ensure that it's converted to 12.34 5. Do the same with "12.34 EUR" and ensure that it's converted to "12.34" 6. Same with "EUR 12.34" → "12.34" 7. "123 456,7" → "123456.7" 8. "EUR 12.34 hi lyon3" → "12.34" 9. "2" → "2" 10. "2,0" → "2.0" XX. TODO WIP thousands sep and other relevant cases XX. Finally validate the form and check that the final value with the dot was well handled. XX. Thinks about Koalas and smile. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7119] general code-cleaning, tidy/whitespace omnibus
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '18

23 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119 Bug 7119 depends on bug 7172, which changed state. Bug 7172 Summary: Omnibus for Plack variable scoping problems https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7172] Omnibus for Plack variable scoping problems
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '18

23 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Closed. -- You are receiving this mail because: You are watching all bug changes.

1 0