March 2018 - Koha-bugs - lists.koha-community.org

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 24 Mar '18

24 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #54 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Victor, should this be Needs Signoff? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '18

23 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73055|0 |1 is obsolete| | --- Comment #53 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 73215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73215&action=ed… Bug 12310 : Decimal separators issues: some fixes in fines and acquisitions The main aim is to prevent - x100 or /100 of the amounts - decimal part truncation Fixes Bug 19521 - Partial fine payment is not working with comma decimal separator But not Bug 18723 - Dot not recognized as decimal separator (aquisitions) It will be done in a follow up patch. This one is already too huge to test. Bonuses: - get rid of the spaces, currency symbols, names (EUR) It handles: - by default comma and dot as decimal separators on the same instance - dot or comma as thousands separators if choose to use only one of them as decimal separator. See DigitSeparator syspref. == Test plan == 1. In the manual invoice (cgi-bin/koha/members/maninvoice.pl) 2. Apply the annex 1 to the "Amount" field 3. When paying a fine (cgi-bin/koha/members/paycollect.pl) 4. Click on "Pay amount" to go to the page to pay all fines 5. Apply the annex 1 to the "Collect from patron" field 6. Click on "Pay" to go to the page to pay fine 7. Apply the annex 1 to the "Collect from patron" field 8. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl) 9. Apply the annex 1 to the "Amount" field 10. Go to the "Add budget" page staff://cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form 11. Apply the annex 1 to the "Total amount" field 12. Create an active budget 13. Go to the "Add Fund" page for this budget 14. Apply the annex 1 to the "Amount" field 15. Apply the annex 1 to the "Warning at (amount)" field 16. If you have ideas of stuff to try to find *regressions* from the previous versions, then try. You might spare librarian tears by finding something before it's released. 17. Express your happiness. This is important, otherwise the signoff spell won't work! The details of expressing your happinnes depends on your culture and habits. === Annex 1: Subpart for each concerned page === 1. Set DigitSeparator syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not changing the page. 4. Ensure that it's converted to 12.34 5. Do the same with "12.34 EUR" and ensure that it's converted to "12.34" 6. Same with "EUR 12.34" → "12.34" 7. "123 456,7" → "123456.7" 8. "EUR 12.34 hi lyon3" → "12.34" 9. "2" → "2" 10. "2,0" → "2.0" XX. TODO WIP thousands sep and other relevant cases XX. Finally validate the form and check that the final value with the dot was well handled. XX. Thinks about Koalas and smile. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7119] general code-cleaning, tidy/whitespace omnibus
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '18

23 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119 Bug 7119 depends on bug 7172, which changed state. Bug 7172 Summary: Omnibus for Plack variable scoping problems https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7172] Omnibus for Plack variable scoping problems
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '18

23 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Closed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20429] New: opac-privacy.pl display needs changed
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '18

23 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20429 Bug ID: 20429 Summary: opac-privacy.pl display needs changed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The opac-privacy.pl (privacy tab) displays either "Your reading history has been deleted" OR "NO reading history to delete". This is true even if the user has a reading history and hasn't deleted it. There should be a 3rd case where the display <span> class is hidden. Here is the code from the opac-privacy.tt file: <div id="userprivacy"> <h3>Your privacy management</h3> [% IF deleted %] <div class="alert alert-success">Your reading history has been deleted.</div> [% ELSE %] <div class="alert">No reading history to delete</div> [% END %] A 3rd clause that checks if there is a reading history or not and then hides the display if there is should be added. -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 4078] Add the ability to customize and display the symbol for a currency
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '18

23 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #48 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #47) > Created attachment 73196 [details] [review] > Bug 4078: Fix test when fr_FR.UTF-8 is installed Pushed to master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4078] Add the ability to customize and display the symbol for a currency
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '18

23 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #47 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 73196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73196&action=ed… Bug 4078: Fix test when fr_FR.UTF-8 is installed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4078] Add the ability to customize and display the symbol for a currency
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '18

23 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20466 [Bug 20466] Incorrect fixtures for active currency in t/Prices.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15323] ./t/Prices.t fails without a valid database
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '18

23 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15323 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20466 [Bug 20466] Incorrect fixtures for active currency in t/Prices.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 23 Mar '18

23 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #37 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #36) > And I think that is what is wrong here. We should have > default_circ_rules.max_holds on the interface, then call > GetBranchBorrowerCircRule from CanItemBeReserved > It sounds like a trivial change and so I think it should be added by this > patch set. I've been trying to understand your request and I just cannot figure it out. Considering it would be a trivial change, would you be able to submit the patch? -- You are receiving this mail because: You are watching all bug changes.

1 0