March 2018 - Koha-bugs - lists.koha-community.org

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #46 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- some QA feedback: - enforce JS9 coding guideline - JS10: use JQuery validation https://gitlab.com/koha-community/Koha/blob/master/koha-tmpl/intranet-tmpl/… - it might be acceptable to not have JS form validation (as there is none now). Is there is, it could be a follow up bug. - test if there is server-side validation. Check at least what happens. - "T_T" - "11.34,45.5" - "madness12.34" - "12.34nooooo" - "lol12.34why" - "1.000,000.56" - "1,000.000,56" -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10449] Suggestions pending approval should count only suggestions of current branch
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18743 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #45 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- After talking to cait: must support thousands separators After talking to BULAC and Lyon 3 and at least 2 other libraries: must support multiple decimal separators in **the same instance** (12.56 and 12,56 → 12.56) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9692] Add a checkbox to display statistical fields in basket.tt
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune(a)bulac.fr --- Comment #12 from Séverine Queune <severine.queune(a)bulac.fr> --- Second patch doesn't apply. Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9692: [FOLLOWUP] Add a checkbox to display statistical fields in basket.tt The copy of the patch that failed is found in: /var/repositories/koha/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-9692-FOLLOWUP-Add-a-checkbox-to-display-statis-W5i0Tj.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical --- Comment #44 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Critical: because it must address - bug 18723 - bug 19521 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #43 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Some QA feedback: - create a dedicated JS lib instead of an include -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances.
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances.
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Olivier <olivier.roure(a)enssib.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |olivier.roure(a)enssib.fr --- Comment #12 from Olivier <olivier.roure(a)enssib.fr> --- Try to test on sandbox 01 (https://wiki.koha-community.org/wiki/Sandboxes) Some problems occurred applying patches from bug 11361: <h1>Something went wrong !</h1>Applying: Bug 11361 - Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances fatal: sha1 information is lacking or useless (C4/Auth.pm). error: could not build fake ancestor Patch failed at 0001 Bug 11361 - Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #42 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- some QA feedback: - maybe hardcode the two decimal separators (,.) instead of creating a syspref - don't display a long hint message next to each field. Even display nothing might be okay. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15235] Add column filters to checkouts table
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen(a)joensuu.fi --- Comment #7 from paxed <pasi.kallinen(a)joensuu.fi> --- Comment on attachment 72908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72908 Bug 15235: Add column filters to checkouts table Shouldn't this be a translatable string? + sRangeFormat: "From {from}<br>to {to}", -- You are receiving this mail because: You are watching all bug changes.

1 0