March 2018 - Koha-bugs - lists.koha-community.org

[Bug 15235] Add column filters to checkouts table
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15235 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61160|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72908&action=ed… Bug 15235: Add column filters to checkouts table This adds a switch that allow to enable/disable column filters on checkouts table (disabled by default) Depends on bug 15219 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61546|0 |1 is obsolete| | --- Comment #22 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72906&action=ed… Bug 15219: Fix date sorting when server-side processing is disabled Use DataTables 'columns' option instead of 'aoColumns' This allow more control on what data is used for display, sorting, filtering, ... A large part of this patch is about rewording things to better match the DataTables documentation. The real change is that "mRender": renderingFunc becomes "render": { "display": renderingFunc } So the return value of renderingFunc is now only used for display (not for filtering, sorting, ...) Signed-off-by: Eric Gosselin <eric.gosselin(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61545|0 |1 is obsolete| | --- Comment #21 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72905&action=ed… Bug 15219: Server-side processing and pagination on checkouts tables Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by enabling server-side processing and pagination on checkouts tables. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. As server-side processing can be useless and cumbersome with small sets of data, a new system preference is introduced to control this behaviour (server-side processing is disabled by default). Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) Test plan: 1. Find (or create) a patron that have at least 10 checkouts and where the relatives checkouts table contain at least 10 checkouts. 2. Go to the patron's detail page and check everything works fine in both tables (sorting, pagination, the data itself, ...) 3. Do the same on circulation page (circulation.pl) 4. Enable system preference ServerSideCheckoutsTable 5. Repeat steps 2 and 3 Signed-off-by: Eric Gosselin <eric.gosselin(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #3 from M. Tompsett <mtompset(a)hotmail.com> --- Haven't written the tests yet, so feel free to take it, write them, and ask for sign off. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com Assignee|gmcharlt(a)gmail.com |mtompset(a)hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #2 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 72902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72902&action=ed… Bug 12159: Move borrower_add_additional_fields to Koha::Patron The same function was effectively coded twice. It was removed from members/pay.pl and members/paycollect.pl and placed in Koha/Patron.pm instead. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8897] Optional GnuPG encryption of outgoing emails
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897 --- Comment #47 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #45) > Another unrelated note... I wonder if there's anything we could do to help > people use TLS for email. Alas, Let's Encrypt doesn't provide certificates > for email, so that doesn't help. I think maybe it is all up to the sysadmin > on the final system to set that up... > > But that's a layer of security that I could see all libraries using quite > readily. Ohhh... looks like I misunderstood the Let's Encrypt certificate thing: https://community.letsencrypt.org/t/how-to-get-certificate-for-email-server… So we could be using TLS for email. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15439] Current Location incorrect when item in transit
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '18

15 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15439 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20419 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '18

14 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Roch D'Amour <roch.damour(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72706|0 |1 is obsolete| | --- Comment #68 from Roch D'Amour <roch.damour(a)inlibro.com> --- Created attachment 72898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72898&action=ed… Bug 12747 - Add extra column in Z3950 search This is a complete squash of previous patches, with additional code quality improvments following M. Tompsett's feedback. Squashing was done (as suggested) because many lines add be added and subsequently deleted, which made for confusing patches. New changes: * Major enhancement to _add_custom_rowdata(), as suggested by QA. The $_ variable is no longer used (at all), and the split() routine is used. * t/db_dependent/Breeding.t now uses the mocked preference logic to avoid sysprefs being affected. Functionality and test plan have not changed. -- This patch makes it possible to add an extra column to Z3950 search results. The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC field/subfields are displayed in the column. Testing: I Apply the patch II Run updatedatabase.pl ACQUISITIONS 0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch 1) Create a new basket or use an existing one 2) In -Add order to basket-, click "From an external source" 3) Select some search targets and enter a subject heading ex. house 4) Click Search bouton 5) Validate "Additional fields" column with the field/subfield value. CATALOGUING 0) Shares same syspref as above 1) Go to cataloguing, click New from z3950 2) Fill to result in a successful search 3) Validate column Addition Fields Sponsored-by: CCSR (https://ccsr.qc.ca) -- You are receiving this mail because: You are watching all bug changes.

1 0