March 2018 - Koha-bugs - lists.koha-community.org

[Bug 12020] Allow translating label-edit-batch hardcoded strings
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '18

13 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12020] Allow translating label-edit-batch hardcoded strings
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '18

13 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|label-edit-batch has |Allow translating |hardcoded error messages |label-edit-batch hardcoded | |strings -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12020] label-edit-batch has hardcoded error messages
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '18

13 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs(a)lists.koha-commun |pasi.kallinen(a)joensuu.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen(a)joensuu.fi> --- Created attachment 72730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72730&action=ed… Bug 12020: Allow translating label-edit-batch hardcoded strings Move the hardcoded error strings in the batch label edit into the template, so they can be translated. Test plan: 1) Apply patch 2) Go to Home -> Tools -> Label edit 3) Create a new batch with some items in it 4) Try to trigger any of the errors, check that the error messages look correct 5) Update a language xx-YY 5) Check that the error messages show up in xx-YY-staff-prog.po -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #56 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to M. Tompsett from comment #53) > Comment on attachment 71317 [details] [review] > Bug 15486: Extend CanItemBeReserved so it handles daily holds limits > > Review of attachment 71317 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Reserves.pm > @@ +300,4 @@ > > my $ruleitemtype; # itemtype of the matching issuing rule > > my $allowedreserves = 0; # Total number of holds allowed across all records > > my $holds_per_record = 1; # Total number of holds allowed for this one given record > > + my $holds_per_day = 0; # Total number of holds allowed per day for the given patron > > Shouldn't this default to undef? (i.e. unlimited) While it could make sense, I'm just following what's done already in the code. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #55 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to M. Tompsett from comment #54) > Comment on attachment 71314 [details] [review] > Bug 15486: DB structure change > > Review of attachment 71314 [details] [review]: > ----------------------------------------------------------------- > > ::: installer/data/mysql/atomicupdate/bug_15486_max_holds_per_day.perl > @@ +1,2 @@ > > +$DBversion = "XXX"; > > +if ( CheckVersion($DBversion) ) { > > no reserve date?! > > ::: installer/data/mysql/kohastructure.sql > @@ +1883,4 @@ > > CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha > > `reserve_id` int(11) NOT NULL auto_increment, -- primary key > > `borrowernumber` int(11) NOT NULL default 0, -- foreign key from the borrowers table defining which patron this hold is for > > + `reservedate` date default NULL, -- the date the hold was placed > > reservedate here... This is probably some formatting change. I'm not adding that column at all. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #54 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 71314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71314 Bug 15486: DB structure change Review of attachment 71314: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=154…) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_15486_max_holds_per_day.perl @@ +1,2 @@ > +$DBversion = "XXX"; > +if ( CheckVersion($DBversion) ) { no reserve date?! ::: installer/data/mysql/kohastructure.sql @@ +1883,4 @@ > CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha > `reserve_id` int(11) NOT NULL auto_increment, -- primary key > `borrowernumber` int(11) NOT NULL default 0, -- foreign key from the borrowers table defining which patron this hold is for > + `reservedate` date default NULL, -- the date the hold was placed reservedate here... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #53 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 71317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71317 Bug 15486: Extend CanItemBeReserved so it handles daily holds limits Review of attachment 71317: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=154…) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +300,4 @@ > my $ruleitemtype; # itemtype of the matching issuing rule > my $allowedreserves = 0; # Total number of holds allowed across all records > my $holds_per_record = 1; # Total number of holds allowed for this one given record > + my $holds_per_day = 0; # Total number of holds allowed per day for the given patron Shouldn't this default to undef? (i.e. unlimited) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12460] Search history: Combine to start a new search
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 --- Comment #26 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Lucie Gay from comment #24) > -> There are still two tabs in the search history : catalog / authority. So > it's not easy to combine both. In the authority's tab, there is no option > "combine queries". That is expected, the feature is only for biblios. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12460] Search history: Combine to start a new search
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 --- Comment #25 from Julian Maurice <julian.maurice(a)biblibre.com> --- Hi Lucie, The feature has changed and the test plan was not updated. Sorry about that. Here's an updated test plan: Test plan: 1. Login to intranet interface 2. Do some biblio searches 3. Go to the search history page 4. See you have a new textbox below the table 5. Type in the textbox a query using the IDs displayed in the table, like "(#1 or #2) and #3" and click on "Combine queries". You will be redirected to the catalogue search results. 6. Confirm that the results are correct. 7. Go to OPAC interface anonymously and repeat steps 2-6 8. Login to OPAC interface and repeat steps 2-6 9. Check that authority search history still works as before the patch (except that there is only one table instead of two) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71349|0 |1 is obsolete| | --- Comment #96 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 72725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72725&action=ed… Bug 12395: Use standard <fieldset> + <ol> markup for showorder.tt Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0