March 2018 - Koha-bugs - lists.koha-community.org

[Bug 7468] Add label to batch by barcode range
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '18

13 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468 Hugo Agud <hagud(a)orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |hagud(a)orex.es --- Comment #16 from Hugo Agud <hagud(a)orex.es> --- The patch applies fine 1. It prints propertly the range of barcode 2. It warns you if you use a to smaller than from 3. BUT doesn't warn you if you use non-numeric... it allow you to write A, B, C or A1000 to A20000... it only pop up a blank pdf -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15336] Script for merging vendors
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '18

13 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15336] Script for merging vendors
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '18

13 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Alex Arnaud <alex.arnaud(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72023|0 |1 is obsolete| | --- Comment #39 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- Created attachment 72734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72734&action=ed… Bug 15336 - New command-line script: misc/migration_tools/merge_vendors.pl Test plan (i.e. merge bookseller n° 3with the n° 6): run perl misc/migration_tools/merge_vendors.pl -f 3 -t 6 -v -c Check that basketgroups, baskets, contacts, contracts, invoices, deleteditems, items and subscriptions had moved into bookseller 6. Check that bookseller n° 3 has been deleted. Remove -c (confirm) parameter to run in test mode only. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12020] Allow translating label-edit-batch hardcoded strings
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '18

13 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12020] Allow translating label-edit-batch hardcoded strings
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '18

13 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|label-edit-batch has |Allow translating |hardcoded error messages |label-edit-batch hardcoded | |strings -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12020] label-edit-batch has hardcoded error messages
by bugzilla-daemon＠bugs.koha-community.org 13 Mar '18

13 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 paxed <pasi.kallinen(a)joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs(a)lists.koha-commun |pasi.kallinen(a)joensuu.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen(a)joensuu.fi> --- Created attachment 72730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72730&action=ed… Bug 12020: Allow translating label-edit-batch hardcoded strings Move the hardcoded error strings in the batch label edit into the template, so they can be translated. Test plan: 1) Apply patch 2) Go to Home -> Tools -> Label edit 3) Create a new batch with some items in it 4) Try to trigger any of the errors, check that the error messages look correct 5) Update a language xx-YY 5) Check that the error messages show up in xx-YY-staff-prog.po -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #56 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to M. Tompsett from comment #53) > Comment on attachment 71317 [details] [review] > Bug 15486: Extend CanItemBeReserved so it handles daily holds limits > > Review of attachment 71317 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Reserves.pm > @@ +300,4 @@ > > my $ruleitemtype; # itemtype of the matching issuing rule > > my $allowedreserves = 0; # Total number of holds allowed across all records > > my $holds_per_record = 1; # Total number of holds allowed for this one given record > > + my $holds_per_day = 0; # Total number of holds allowed per day for the given patron > > Shouldn't this default to undef? (i.e. unlimited) While it could make sense, I'm just following what's done already in the code. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #55 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to M. Tompsett from comment #54) > Comment on attachment 71314 [details] [review] > Bug 15486: DB structure change > > Review of attachment 71314 [details] [review]: > ----------------------------------------------------------------- > > ::: installer/data/mysql/atomicupdate/bug_15486_max_holds_per_day.perl > @@ +1,2 @@ > > +$DBversion = "XXX"; > > +if ( CheckVersion($DBversion) ) { > > no reserve date?! > > ::: installer/data/mysql/kohastructure.sql > @@ +1883,4 @@ > > CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha > > `reserve_id` int(11) NOT NULL auto_increment, -- primary key > > `borrowernumber` int(11) NOT NULL default 0, -- foreign key from the borrowers table defining which patron this hold is for > > + `reservedate` date default NULL, -- the date the hold was placed > > reservedate here... This is probably some formatting change. I'm not adding that column at all. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #54 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 71314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71314 Bug 15486: DB structure change Review of attachment 71314: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=154…) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_15486_max_holds_per_day.perl @@ +1,2 @@ > +$DBversion = "XXX"; > +if ( CheckVersion($DBversion) ) { no reserve date?! ::: installer/data/mysql/kohastructure.sql @@ +1883,4 @@ > CREATE TABLE `reserves` ( -- information related to holds/reserves in Koha > `reserve_id` int(11) NOT NULL auto_increment, -- primary key > `borrowernumber` int(11) NOT NULL default 0, -- foreign key from the borrowers table defining which patron this hold is for > + `reservedate` date default NULL, -- the date the hold was placed reservedate here... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #53 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 71317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71317 Bug 15486: Extend CanItemBeReserved so it handles daily holds limits Review of attachment 71317: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=154…) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +300,4 @@ > my $ruleitemtype; # itemtype of the matching issuing rule > my $allowedreserves = 0; # Total number of holds allowed across all records > my $holds_per_record = 1; # Total number of holds allowed for this one given record > + my $holds_per_day = 0; # Total number of holds allowed per day for the given patron Shouldn't this default to undef? (i.e. unlimited) -- You are receiving this mail because: You are watching all bug changes.

1 0