March 2018 - Koha-bugs - lists.koha-community.org

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72076|0 |1 is obsolete| | --- Comment #201 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 72698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72698&action=ed… Bug 11708: UT: Use DateTime instead of localtime+sprintf Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72075|0 |1 is obsolete| | --- Comment #200 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 72697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72697&action=ed… Bug 11708: UT: Replace 'ok' by 'is' where appropriate Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72074|0 |1 is obsolete| | --- Comment #199 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 72696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72696&action=ed… Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. In the process, this patch adds 4 new "Koha::Object" modules: - Koha::Bookseller(s) - Koha::Basket(s) - Koha::Basketgroup(s) - Koha::Order(s) It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72073|0 |1 is obsolete| | --- Comment #198 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 72695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72695&action=ed… Bug 11708: Place "Basket groups" menu entry on top of the side navigation Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72072|0 |1 is obsolete| | --- Comment #197 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 72694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72694&action=ed… Bug 11708: Remove column aqbasketgroups.closed It is redundant with aqbasketgroups.closeddate Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Patch updated: use atomic update Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72071|0 |1 is obsolete| | --- Comment #196 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 72693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72693&action=ed… Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72070|0 |1 is obsolete| | --- Comment #195 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 72692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72692&action=ed… Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72069|0 |1 is obsolete| | --- Comment #194 from Séverine Queune <severine.queune(a)bulac.fr> --- Created attachment 72691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72691&action=ed… Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Patch updated: Use atomic update Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Séverine Queune <severine.queune(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11512] Forced holds that violate issuing rules will never be filled
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11512 Jesse Maseto <jesse(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68595|0 |1 is obsolete| | --- Comment #6 from Jesse Maseto <jesse(a)bywatersolutions.com> --- Created attachment 72689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72689&action=ed… Bug 11512 - Forced holds that violate issuing rules will never be filled Currently in Koha, if you choose to force a hold from the staff side that would contravened the current issuing rules, that hold will never be filled, as it is always skipped over by CheckReserves. This patch disallows overrideing except for tooManyReserves which are the only overridden holds that will be trapped. Test Plan: 1) Apply this patch 2) Attempt to override hold placement, only placements where the patron has too many holds already should be allowed Signed-off-by: Jesse Maseto <jesse(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0