March 2018 - Koha-bugs - lists.koha-community.org

[Bug 11936] Consistent log message for item insert
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72619|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11936] Consistent log message for item insert
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 --- Comment #9 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72642&action=ed… Bug 11936: (QA follow-up) Consistent log message for item insert Fix the same error in another place Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11936] Consistent log message for item insert
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 --- Comment #8 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72641&action=ed… Bug 11936: Consistent log message for item insert If you use bulkmarcimport.pl to import records with items it looks like the successfull insert of the record is reported multiple time, but the second and subsequent "ok" is really related to importing the item(s). This patch changes the log message on successfully inserting an item to match the log message given when inserting an item fails. To test, the easy way: - Look at lines 530 and 536 of bulkmarcimport.pl, and note that the "op" in those two lines are different - Apply the patch - Look at lines 530 and 536 again, and note that the "op" is now identical, and that this makes sense, since they are both related to the same operation, specifically inserting an item To test, the hard way - Have some records with items - Import the records with bulkmarcimport.pl, and make sure to specify the -l option, to create a log of the actions taken - Look at the log and verify it looks something like this: id;operation;status 1;insert;ok 1;insert;ok 2;insert;ok 2;insert;ok - Apply this patch and import some more records with items. The log should now be similar to this: id;operation;status 1;insert;ok 1;insertitem;ok 2;insert;ok 2;insertitem;ok Signed-off-by: Maksim Sen <maksim.sen(a)inlibro.com> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7047] renewing serials note not visible
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 --- Comment #7 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 72639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72639&action=ed… Bug 7047 - Storing subscription renewal note in suggestion to be displayed on the suggestion page. Additionally I have added a library input field in case the librarian wants to set a library branch whilst renewing a subscription. With the use case being they may have ommitted to set the branchcode whilst creating the subscription. Test plan: 1. Create a subscription (if one does not already exist) 2. Set the RenewSerialAddsSuggestion syspref to 'Add' 3. Renew the item making sure to write in a value into the note field 3. Visit the suggestions page and notice that the note is not displayed for the newly created suggestion 4. Apply patch 5. Repeat step 3. Notice that there is now a new branchcode dropdown box. Select one of your libraries and write in the value into the note field 6. Visit suggestions and notice there is now a 'Suggestion note' column in the table containing the note. Also note that the suggestion has the correct branchcode associated with it Sponsored-By: Catalyst IT Signed-off-by: Maksim Sen <maksim(a)inlibro.com> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7047] renewing serials note not visible
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71168|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7047] renewing serials note not visible
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes(a)biblibre.com --- Comment #6 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 11936] Consistent log message for item insert
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 --- Comment #7 from Magnus Enger <magnus(a)libriotech.no> --- (In reply to Julian Maurice from comment #6) > There is a similar error at lines 490/496. Should it be fixed too ? Yes! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #109 from Aurélie <aurelie.berut(a)enssib.fr> --- Lucie et Aurélie : first test during Hackfest 2018 for us! A new dropdown select to chose the main contact method = OK The selected field appears in the patron's detail page = OK -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #108 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 72635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72635&action=ed… Bug 11879: Follow-up - code review Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 12 Mar '18

12 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #107 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 72634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72634&action=ed… Bug 11879: Follow-up - Streamline markup and make label corrections This patch makes minor markup corrections to the patron detail page template: - Simplify the SWITCH markup - Add "primary" to primary phone label - Correct case on label - Add IF statement to hide label if there is no primary contact method Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0