March 2018 - Koha-bugs - lists.koha-community.org

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '18

06 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #129 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72464&action=ed… Bug 11317: (Follow-up) Fix tab chars and move javascript to the footer Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '18

06 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #128 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72463&action=ed… Bug 11317: (Follow-up) File with same name in different directories now has distinct hash Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '18

06 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #127 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72462&action=ed… Bug 11317: (Follow-up) Fixing merge error and cosmetic changes Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '18

06 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #126 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72461&action=ed… Bug 11317: Update the link under reports Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '18

06 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #125 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72460&action=ed… Bug 11317: Move file access under Tools and add specific permission - Moves the .pl and .tt under tools/ instead of reports/ and adds tools/access_files permission. - Remove datatables-strings.inc from .tt - Allow sorting on date column in file access tool. For some reason, the table was blocking sorting based on timestamp, even though most users would probably want that since the feature is used primarily to access generated (daily) reports i and finding the last ones is very important. Testing -1) Having done requirements of previous patches, like adding 'accessdir' to koha-conf... 0) apply patch, update database to add permission option. 1) Login as NON-superadmin. Go under tools, see no Report/Log under the third column 2) Go to add tools/access_file permission to user 3) See new entry under tools third column. 4) validate link is ok. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '18

06 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #124 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72459&action=ed… Bug 11317: Allows for multiple directories to be accessible It is now possible to add as many <accessdir>SOMEDIR</accessdir> as needed to the config file. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '18

06 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #123 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72458&action=ed… Bug 11317: Rename config to 'accessdir' and fix qa Also translate date with datetime format preference and move to Tools. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '18

06 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #122 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72457&action=ed… Bug 11317: Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '18

06 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66094|0 |1 is obsolete| | Attachment #66095|0 |1 is obsolete| | Attachment #66096|0 |1 is obsolete| | Attachment #66097|0 |1 is obsolete| | Attachment #66098|0 |1 is obsolete| | Attachment #66099|0 |1 is obsolete| | Attachment #66100|0 |1 is obsolete| | Attachment #72309|0 |1 is obsolete| | --- Comment #121 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 72456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72456&action=ed… Bug 11317: Adds a page to access log files on the server from the intranet. The directory used is defined by the "publiclogdir" preference in koha-conf.xml. Test case : Preparation : * Add the "publiclogdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/koha-public" directory : <config> ... <publiclogdir>/tmp/koha-public</publiclogdir> ... </config> * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/koha-public * Add a test file in the log directory : $ cd /tmp/koha-public $ echo "Hello world!" > test.txt Test : * Go in the "Reports" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". Sponsored by : CCSR Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '18

06 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0