March 2018 - Koha-bugs - lists.koha-community.org

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70257|0 |1 is obsolete| | --- Comment #153 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 72446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72446&action=ed… Bug 14385 Followup: C4::Borrowers not found GetMember is in C4::Members, not C4::Borrowers Signed-off-by: Claire Gravely <c.gravely(a)arts.ac.uk> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #152 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 72445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72445&action=ed… Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Edit: Fixing merge conflicts in - t/db_dependent/Items.t - t/db_dependent/Search.t - C4/Search.pm Changes the API for calling GetHiddenItems and all the places in the code that call it. This is to allow borrower categories to be passed in. Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories to be able to see items, even if they are marked hidden by OpacHiddenItems To test: 1) Make two borrowers, one in a category that should see everything (ie Adult), and another in a category that should only see certain things (ie Adult - exceptions) 2) Add the borrower that can see everything (the Adult) to OpacHiddenItemsExceptions 3) To the OpacHiddenItems syspref, add an item type (ensure that you have some records that fall under this type in your library). 4) Log in as the borrower that should only see certain things (Adult - exception) 5) Do a search, filtered to show records which are the item type that you specified in the OpacHiddenItems syspref. No records should show for this borrower as this item type is hidden to them. 6) Log in as the borrower that should see everything (Adult) 7) Do the same search. There should be results from this search, as this borrower category has been specified as an exception to the hidden items Signed-off-by: Claire Gravely <c.gravely(a)arts.ac.uk> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #151 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 70259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70259 Bug 14385: A lot of patches Review of attachment 70259: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=143…) ----------------------------------------------------------------- ::: opac/opac-tags.pl @@ +310,5 @@ > + if (grep { $_->{term} eq $my_tag->{term} } @$results) { > + if (! $my_tag->{visible} ) { > + my $check_biblio = GetMarcBiblio({ > + biblionumber => $my_tag->{biblionumber}, > + embed_itesm => 1, Always good idea to re-check over and over. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #150 from M. Tompsett <mtompset(a)hotmail.com> --- Currently does not apply, reworking. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18525] New: Can't create order line from accepted suggestion
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Bug ID: 18525 Summary: Can't create order line from accepted suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When I try to create an order line from an accepted suggestion, I get an error: Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. Can someone confirm? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 16671] New: Wrong itemtype picked in HoldsQueue.t
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16671 Bug ID: 16671 Summary: Wrong itemtype picked in HoldsQueue.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org >From bug 14828: -my @item_types = C4::ItemType->all; -my @for_loan = grep { $_->{notforloan} == 0 } @item_types - or BAIL_OUT("No adequate itemtype"); -my $itemtype = $for_loan[0]->{itemtype}; +my $itemtype = Koha::ItemTypes->search({ notforloan => 1 })->next; +$itemtype or BAIL_OUT("No adequate itemtype"); #FIXME Should be $itemtype = $itemtype->itemtype (First you are allowed to wonder what this FIXME has not been done...) The wrong itemtypes are picked from the DB, we want itemtypes with notforloan == 0, not 1. -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 17657] New: Item type' s images could not be displayed correctly on the item types admin page
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Bug ID: 17657 Summary: Item type's images could not be displayed correctly on the item types admin page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com >From the ML https://lists.katipo.co.nz/pipermail/koha/2016-November/046616.html > When trying to configure an icon for an item type, the chosen icon won't > show in the Koha menu "Administration > Item types". I used to see the > icon in the first column entitled "Image" - now this column is empty. > Also the icon won't show in staff interface or OPAC. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 16449] New: unimarc_field_4XX raises a warning
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16449 Bug ID: 16449 Summary: unimarc_field_4XX raises a warning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 14828 Because of bug 14828, the unimarc_field_4XX now raises a warning: "No method selected!" There are no need to select an item type on this page, the default (all) is always selected. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 [Bug 14828] Move the item types related code to Koha::ItemTypes -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 16114] New: Regression: Bug 14828 broke display of localized item type descriptions
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16114 Bug ID: 16114 Summary: Regression: Bug 14828 broke display of localized item type descriptions Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/catalogue/itemsearch.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com If you have defined a translation for an item type (Administration -> Item types -> Edit -> Translate into other languages), the item type description is not displayed correctly in the item search form (catalogue/itemsearch.pl). Instead you see something like "Koha::Localization=HASH(0x849c980)" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 15306] Don't show translate link for item types if only one language is installed
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Bug 15306 depends on bug 14828, which changed state. Bug 14828 Summary: Move the item types related code to Koha::ItemTypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0