March 2018 - Koha-bugs - lists.koha-community.org

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70257|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #155 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 72448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72448&action=ed… Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70258|0 |1 is obsolete| | --- Comment #154 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 72447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72447&action=ed… Bug 14385: Followup: changes to sysprefs.sql and atomicupdate Run updatedatabase.pl when testing Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70257|0 |1 is obsolete| | --- Comment #153 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 72446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72446&action=ed… Bug 14385 Followup: C4::Borrowers not found GetMember is in C4::Members, not C4::Borrowers Signed-off-by: Claire Gravely <c.gravely(a)arts.ac.uk> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #152 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 72445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72445&action=ed… Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Edit: Fixing merge conflicts in - t/db_dependent/Items.t - t/db_dependent/Search.t - C4/Search.pm Changes the API for calling GetHiddenItems and all the places in the code that call it. This is to allow borrower categories to be passed in. Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories to be able to see items, even if they are marked hidden by OpacHiddenItems To test: 1) Make two borrowers, one in a category that should see everything (ie Adult), and another in a category that should only see certain things (ie Adult - exceptions) 2) Add the borrower that can see everything (the Adult) to OpacHiddenItemsExceptions 3) To the OpacHiddenItems syspref, add an item type (ensure that you have some records that fall under this type in your library). 4) Log in as the borrower that should only see certain things (Adult - exception) 5) Do a search, filtered to show records which are the item type that you specified in the OpacHiddenItems syspref. No records should show for this borrower as this item type is hidden to them. 6) Log in as the borrower that should see everything (Adult) 7) Do the same search. There should be results from this search, as this borrower category has been specified as an exception to the hidden items Signed-off-by: Claire Gravely <c.gravely(a)arts.ac.uk> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #151 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 70259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70259 Bug 14385: A lot of patches Review of attachment 70259: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=143…) ----------------------------------------------------------------- ::: opac/opac-tags.pl @@ +310,5 @@ > + if (grep { $_->{term} eq $my_tag->{term} } @$results) { > + if (! $my_tag->{visible} ) { > + my $check_biblio = GetMarcBiblio({ > + biblionumber => $my_tag->{biblionumber}, > + embed_itesm => 1, Always good idea to re-check over and over. :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #150 from M. Tompsett <mtompset(a)hotmail.com> --- Currently does not apply, reworking. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18525] New: Can't create order line from accepted suggestion
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18525 Bug ID: 18525 Summary: Can't create order line from accepted suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When I try to create an order line from an accepted suggestion, I get an error: Template process failed: undef error - The method selected is not covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. Can someone confirm? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 16671] New: Wrong itemtype picked in HoldsQueue.t
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16671 Bug ID: 16671 Summary: Wrong itemtype picked in HoldsQueue.t Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org >From bug 14828: -my @item_types = C4::ItemType->all; -my @for_loan = grep { $_->{notforloan} == 0 } @item_types - or BAIL_OUT("No adequate itemtype"); -my $itemtype = $for_loan[0]->{itemtype}; +my $itemtype = Koha::ItemTypes->search({ notforloan => 1 })->next; +$itemtype or BAIL_OUT("No adequate itemtype"); #FIXME Should be $itemtype = $itemtype->itemtype (First you are allowed to wonder what this FIXME has not been done...) The wrong itemtypes are picked from the DB, we want itemtypes with notforloan == 0, not 1. -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 17657] New: Item type' s images could not be displayed correctly on the item types admin page
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '18

05 Mar '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17657 Bug ID: 17657 Summary: Item type's images could not be displayed correctly on the item types admin page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com >From the ML https://lists.katipo.co.nz/pipermail/koha/2016-November/046616.html > When trying to configure an icon for an item type, the chosen icon won't > show in the Koha menu "Administration > Item types". I used to see the > icon in the first column entitled "Image" - now this column is empty. > Also the icon won't show in staff interface or OPAC. -- You are receiving this mail because: You are watching all bug changes.

1 12