April 2018 - Koha-bugs - lists.koha-community.org

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #35 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Lisette from comment #30) > I think it would be clearer to either say: > "Do not block permitted non-superlibrarians" > "Block permitted non-superlibrarians" > > OR > "Allow permitted non-superlibrarians" > "Allow only superlibrarians" > > The other way just seems mixed up to me. > Lisette Thx Lisette. Incorporated the two allows in the pref description on patch 6. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #34 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #29) > 1. The block reads weird, I would have written: > IF we are going to add or remove the librarian flag > THEN we check if the loggeed in patron is allowed to > > But not blocker. > > 2. I do not think we should shorten syspref's name. Not blocker > > 3. The descriptions of the 2 options are: > - "Do not block permitted non-superlibrarians" > - "Allow only superlibrarians" > It is negative for "yes" and positive for "no". > > Native English speakers, sounds ok for you? Point 2 fixed in patch 5. Points 1 and 3 are addressed in patch 6. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #33 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 74841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74841&action=ed… Bug 20100: (QA follow-up) Pref description and improve code in member-flags Two points as mentioned on Bugzilla comment29. [1] Improve pref description. Feedback from comment30 incorporated. [2] Improve code in member-flags. Check if we change librarian flag first. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested the die with "disable_superlibrarian_privs => 0" in member-flags. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #32 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 74840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74840&action=ed… Bug 20100: (QA follow-up) Change syspref name to full version As per RM request, changing the shorter name to its full form. Result of a git grep | sed. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> No occurrences to be found anymore with git grep -i. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #31 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #28) > Should not we enable this by default for new installations? My initial thought was to do this without a preference. But strong opposition forced me to do otherwise ;) So I would not dare to make it the default yet.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #91 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi all, retesting this, there are a few small glitches (tested with MARC21): - the label will show empty, if the subfield you asked for doesn't exist. Example: 035$a: will show, if there is a 035 with only a $9 in the data. - it will only show the first field from the data, making this not work for repeatable fields like 700$a - only the first entry is shown. The sys pref should be reworded a little, but that's minor and can be done easily (I would have done it, but got stuck on the other items) I am not entirely persuaded by the 2 line display using <dd> <dt>, but also non blocker. Plus: Works well for control fields without subfields, Example: 001. Maybe be good to add an example to the list of fields in the sys pref description. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74035|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17100] New: On summary print, "Account fines and payments" is displaid even if there is nothing to pay
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100 Bug ID: 17100 Summary: On summary print, "Account fines and payments" is displaid even if there is nothing to pay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: sophie.meynieux(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If a patron got fines but the total is null (lost items then returned for example), on print summary, there is a table "Account fines and payments" with no lines in it. There should be not table at all -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 13445] Clean up options for scheduled reports, remove URL, add HTML and Text/TSV
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13445 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- That's good, because pushed :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9290] Restricting patron category for online purchase suggestion
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com --- Comment #9 from Lisette <lisetteslatah(a)gmail.com> --- +1 (In reply to Katrin Fischer from comment #8) > Maybe instead of using a yes/no setting on patron category, you could use a > number of allowed suggestions. There already is already a global setting for > this, that might be extendable in this way: MaxOpenSuggestions Even better would be if it was part of circulation and fines rules so each library in a multi-branch setting could set it differently. -- You are receiving this mail because: You are watching all bug changes.

1 0