April 2018 - Koha-bugs - lists.koha-community.org

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72498|0 |1 is obsolete| | --- Comment #68 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 74855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74855&action=ed… Bug 14957 - Rule based permission for MARC fields Add a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Run updatedatabase.pl 3. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenbug University Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 David Bourgault <david.bourgault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74110|0 |1 is obsolete| | Attachment #74111|0 |1 is obsolete| | --- Comment #143 from David Bourgault <david.bourgault(a)inlibro.com> --- Created attachment 74848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74848&action=ed… Bug 8000: Redirect all emails to SendAllEmailsTo Rebased and squashed after changes to master. Only difference from previous patches are small adjustements to conflicts in t/db_dependent/Letters.t Test plan: 1) Apply path 2) Run updatedatabase.pl 3) Clear all SendAllEmailsTo system preference 4) Send mail to a patron of your choosing, email will go to patron's email address as usual. 5) Set SendAllEmailsTo to a test email address 6) Send mail to the patron, email will be redirected to the email set in the systempreference. 7) Run prove -v t/db_dependent/Letters.t It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) Signed-off-by: Ed Veal <eveal(a)mckinneytexas.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #38 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 74846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74846&action=ed… Bug 20100: Set ProtectSuperlibrarianPrivileges by default -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 74844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74844&action=ed… Bug 20100: Explain why the checkbox is disabled -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #35 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Lisette from comment #30) > I think it would be clearer to either say: > "Do not block permitted non-superlibrarians" > "Block permitted non-superlibrarians" > > OR > "Allow permitted non-superlibrarians" > "Allow only superlibrarians" > > The other way just seems mixed up to me. > Lisette Thx Lisette. Incorporated the two allows in the pref description on patch 6. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #34 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #29) > 1. The block reads weird, I would have written: > IF we are going to add or remove the librarian flag > THEN we check if the loggeed in patron is allowed to > > But not blocker. > > 2. I do not think we should shorten syspref's name. Not blocker > > 3. The descriptions of the 2 options are: > - "Do not block permitted non-superlibrarians" > - "Allow only superlibrarians" > It is negative for "yes" and positive for "no". > > Native English speakers, sounds ok for you? Point 2 fixed in patch 5. Points 1 and 3 are addressed in patch 6. -- You are receiving this mail because: You are watching all bug changes.

1 0