April 2018 - Koha-bugs - lists.koha-community.org

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 74846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74846&action=ed… Bug 20100: Set ProtectSuperlibrarianPrivileges by default -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #36 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 74844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74844&action=ed… Bug 20100: Explain why the checkbox is disabled -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #35 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Lisette from comment #30) > I think it would be clearer to either say: > "Do not block permitted non-superlibrarians" > "Block permitted non-superlibrarians" > > OR > "Allow permitted non-superlibrarians" > "Allow only superlibrarians" > > The other way just seems mixed up to me. > Lisette Thx Lisette. Incorporated the two allows in the pref description on patch 6. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #34 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #29) > 1. The block reads weird, I would have written: > IF we are going to add or remove the librarian flag > THEN we check if the loggeed in patron is allowed to > > But not blocker. > > 2. I do not think we should shorten syspref's name. Not blocker > > 3. The descriptions of the 2 options are: > - "Do not block permitted non-superlibrarians" > - "Allow only superlibrarians" > It is negative for "yes" and positive for "no". > > Native English speakers, sounds ok for you? Point 2 fixed in patch 5. Points 1 and 3 are addressed in patch 6. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #33 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 74841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74841&action=ed… Bug 20100: (QA follow-up) Pref description and improve code in member-flags Two points as mentioned on Bugzilla comment29. [1] Improve pref description. Feedback from comment30 incorporated. [2] Improve code in member-flags. Check if we change librarian flag first. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Tested the die with "disable_superlibrarian_privs => 0" in member-flags. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #32 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 74840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74840&action=ed… Bug 20100: (QA follow-up) Change syspref name to full version As per RM request, changing the shorter name to its full form. Result of a git grep | sed. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> No occurrences to be found anymore with git grep -i. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 25 Apr '18

25 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #31 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #28) > Should not we enable this by default for new installations? My initial thought was to do this without a preference. But strong opposition forced me to do otherwise ;) So I would not dare to make it the default yet.. -- You are receiving this mail because: You are watching all bug changes.

1 0