April 2018 - Koha-bugs - lists.koha-community.org

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #125 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 74818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74818&action=ed… Bug 11879: Remove unecessary code in controller - adds the field required is defined in BorrowerMandatoryField (staff only) - removes code from controller (not needed, we can follow existing pattern) - does not send patron's attribute separately (we have the 'patron' variable already) Need to be done: - same changes for the OPAC - remove extra changes made to moremember-brief.tt (if bugfix it needs to be moved on a separate bug report) - deal with PatronSelfModificationBorrowerUnwantedField and PatronSelfRegistrationBorrowerUnwantedField I first thought it would have replaced AutoEmailPrimaryAddress, but it actually only needed for display purpose, how/where can we explain that? Are release notes enough? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13445] Clean up options for scheduled reports, remove URL, add HTML and Text/TSV
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13445 --- Comment #12 from Eric Phetteplace <ephetteplace(a)cca.edu> --- (In reply to Katrin Fischer from comment #10) > Eric, I notice that your author line in the patch reads: > phette23 <phette23(a)gmail.com> > > Do you want to fix it to have your name? It will be listed in the release > notes then. I can do it for you if you want to. I actually prefer my phette23 handle, but thank you for offering. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine payments should show what was paid for
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #45 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 74817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74817&action=ed… Bug 2696 [QA Followup]: Add more test, move to subtest -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14546] Make staff client templates responsive
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20654 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #30 from Lisette <lisetteslatah(a)gmail.com> --- (In reply to Jonathan Druart from comment #29) > 3. The descriptions of the 2 options are: > - "Do not block permitted non-superlibrarians" > - "Allow only superlibrarians" > It is negative for "yes" and positive for "no". > > Native English speakers, sounds ok for you? I think it would be clearer to either say: "Do not block permitted non-superlibrarians" "Block permitted non-superlibrarians" OR "Allow permitted non-superlibrarians" "Allow only superlibrarians" The other way just seems mixed up to me. Lisette -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7910] Batch renewal of serials
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14610] Add ability to place article requests in Koha
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #270 from Pedro Amorim <pjamorim91(a)gmail.com> --- Jonathan thank you for your reply, it got me on the right track: Turns out the problem has nothing to do with this (what threw me off was the null in the database, because I always saw it defined for the password recovery e-mail for example). The problem I'm having is actually related to the cronjob itself, more precisely https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17717 it seems. Sorry for posting here as it turns out it's not related. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] A non-superlibrarian should not be able to add superlibrarian privileges
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine payments should show what was paid for
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #44 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Kyle, please move the tests to a separate subtest and also test the "return undef" parts. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14610] Add ability to place article requests in Koha
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #269 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pedro, the email is picked when the emails are going to be sent, see C4::Letters::_send_message_by_email: 1258 my $patron = Koha::Patrons->find( $message->{borrowernumber} ); 1259 my $to_address = $message->{'to_address'}; 1260 unless ($to_address) { Are you sure the user has a valid email address? If yes, please open a new bug report. -- You are receiving this mail because: You are watching all bug changes.

1 0