April 2018 - Koha-bugs - lists.koha-community.org

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74763|0 |1 is obsolete| | --- Comment #74 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 74770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74770&action=ed… Bug 1985: Send email alert when comment posted. Many blog systems have a feature where the admin gets an email when someone posts a new comment that needs to be moderated. It would be nice to incorporate this into Koha. Ideally, you could set an email address in system preferences where notifications should be sent (since the Koha administrator is probably not the one approving comments). The body of the email would contain the comments, and offer a direct link to approve or delete the comment. The authorship was corrected to Olli-Antti Kivilahti. In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <<reviews.reviewid>> is now usable in the letter, as is <<staffClientBaseURL>>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Koha/Reviews.t -- six new tests should run. 7) Run the koha qa test tool. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '18

24 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74760|0 |1 is obsolete| | --- Comment #73 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 74769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74769&action=ed… Bug 1985: Fix whitespace in opac/opac-review.pl $ git diff -w origin/master -- should have no differences Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine payments should show what was paid for
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #43 from Kyle M Hall <kyle(a)bywatersolutions.com> --- I have fixed everything except: -- @@ +42,5 @@ > + > +sub debit { > + my ( $self ) = @_; > + my $debit_rs = $self->_result->debit; > + return unless $debit_rs; I do not think we should "return unless" here, we do not do that for other methods. Is there a good reason? -- which I believe to be incorrect. Please refer to Koha::Item::checkout for precedence. What you write makes sense *if* the foreign key *must* exist ( such as the case of items.biblionumber ). However, in this case, a checkout may not exist for this item ). Without that line, you would return a perfectly value but empty Koha::Checkout object. In that case code such as "if ( my $c = $item->checkout )" would by true instead of false like everyone would expect it to be. In fact, $item->checkout would *always* return true since the you'd get a Koha::Checkout object every time, valid or not. (In reply to Jonathan Druart from comment #39) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine payments should show what was paid for
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #42 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 74765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74765&action=ed… Bug 2696 [QA Followup]: Fix POD, results sorting, permissions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine payments should show what was paid for
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine payments should show what was paid for
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #41 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #40) > It would also be great to use the new .inc in other parts of the code where > they are displayed, to avoid duplicated code (on a follow-up bug report?) Excellent idea. I'll file the bug report! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74762|0 |1 is obsolete| | --- Comment #72 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 74764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74764&action=ed… Bug 1985: Follow up - Add sample letter to other languages As per comment #36, the letter COMMENT_CREATED has been added to the other languages. TEST PLAN --------- 0) Back up your letters table 1) In your mysql client after selected your Koha database, Run this: SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; -- there should be 9 counts of 1. 2) Restore your letters table. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74761|0 |1 is obsolete| | --- Comment #71 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 74763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74763&action=ed… Bug 1985: Send email alert when comment posted. In comment #11, it was mentioned that title and biblionumber from the biblio table were not available as variables in the letter. This corrects this by converting the parameter list to a hashref, and adding the missing biblio number. It also cleans up the license on C4/Review.pm to be in line with the current coding guidelines license. Also strict and warning have been changed to the 'Use Modern::Perl;' now. Additionally, <<reviews.reviewid>> is now usable in the letter, as is <<staffClientBaseURL>>. These were required additions, because comment #1 expressly says there should be a direct link to approve or delete. I also included a review everything link, since there could be multiple comments outstanding. The default letter was tweaked as well to reflect these changes. Fixed bad URLs as noted in comment #26. TEST PLAN --------- 1) Create test branch and apply patch 2) run installer/data/mysql/updatedatabase.pl -- this will add the required default letter. 3) In the staff client: a) set the CommentModeratorsEmail system preference. -- not setting it will mean you won't get any queued letters. a) set the staffClientBaseURL system preference. -- not setting it will mean your email links won't be valid (i.e http:///...). b) modify the COMMENT_CREATED default letter as desired. -- feel free to add other things. 4) In the OPAC: a) Log in b) Find something c) Click on the 'Comments' tab -- Holdings/Title notes/Comments (#) is at the bottom d) Click 'Post or edit your comments on this item' e) In the window that pops up, type your comment. f) Click 'Submit and close this window'. g) Click 'Edit' and repeat steps e and f again. 5) In a mysql client: a) Open the koha database b) SELECT * FROM message_queue WHERE letter_code='COMMENT_CREATED'; -- There should be at least two. -- They should be able to contain the borrower number, biblio title, and other borrower and biblio related things. -- Comments are at a biblio level, so items, and issues don't make sense as variables for the letter. -- Confirm the URLs are valid by pasting into a browser. 6) prove -v t/db_dependent/Koha/Reviews.t -- six new tests should run. 7) Run the koha qa test tool. -- You are receiving this mail because: You are watching all bug changes.

1 0