April 2018 - Koha-bugs - lists.koha-community.org

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #65 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Kyle M Hall from comment #64) > > Can we use the is_boolean approach on the screens files? is_patron_id? > > We could be I don't think it solves the root problem. A developer who would > forget to add a new column to the merge patron's mapping is the same > developer that would forget to set is_patron_id in the schema file ; ) I just want to clarify I think that would be an excellent enhancement that would definitely simplify the code! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 --- Comment #27 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Nick Clemens from comment #25) > All looks good to me, the trick of enabling the button on submit didn't feel > right though. > > I attached an alternate patch that changes the form, adding a hidden input > for when the button is disabled. It forced a few more js changes, but I like > the concept better. > > Can you weigh in Marcel and either SO or obsolete my patch? you can then > mark as PQA Thx for QA, Nick. The 'trick' is needed to include the field in the submit. Could have added a hidden input too. I do not have a strong opinion about it. Your patch works. So fine with me. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74621|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 74721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74721&action=ed… Bug 20100: (QA follow-up) Use template logic instead of js to disable superlib box Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20100] Should a non-superlibrarian be able to add superlibrarian privileges?
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20100 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #64 from Kyle M Hall <kyle(a)bywatersolutions.com> --- > Can we use the is_boolean approach on the screens files? is_patron_id? We could be I don't think it solves the root problem. A developer who would forget to add a new column to the merge patron's mapping is the same developer that would forget to set is_patron_id in the schema file ; ) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #63 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Kyle M Hall from comment #62) > (In reply to Jonathan Druart from comment #60) > > (In reply to Kyle M Hall from comment #55) > > > (In reply to Jonathan Druart from comment #54) > > > > Thanks for the follow-ups. > > > > > > > > (In reply to Jonathan Druart from comment #38) > > > > > 1. How did you generate $RESULTSET_PATRON_ID_MAPPING? > > > > > How are we going to keep it up-to-date? > > > > > > I went through the tables looking for columns that represent > > > borrowernumbers. It's pretty easy for columns with foreign keys to > > > borrowers.borrowernumber, but not all the columns have a borrowernumber. We > > > should just add that to the qa process. If a new column is added that is a > > > borrowernumber, it should be added to the mapping. We could move the mapping > > > itself its own perl module to make it more obvious if you wish. > > > > I am going to push as it but I am not convinced by this approach. > > We will not have any tests to alert us if we forgot to update this mapping. > > I'm sure we can do two things with unit tests: > 1) Automate checking that all borrowernumber fields that are foreign keys to > borrowers.borrowernumber are in our mapping > 2) Automate testing all non-fk fields that are *named* borrowernumber are in > our mapping. > > As for non-fk fields that are not named bororwernumber, I don't think there > is anything we can do. Can we use the is_boolean approach on the screens files? is_patron_id? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20636 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20636 [Bug 20636] Add unit tests to verify borrowernumber columns are mapped for patron merging -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #62 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #60) > (In reply to Kyle M Hall from comment #55) > > (In reply to Jonathan Druart from comment #54) > > > Thanks for the follow-ups. > > > > > > (In reply to Jonathan Druart from comment #38) > > > > 1. How did you generate $RESULTSET_PATRON_ID_MAPPING? > > > > How are we going to keep it up-to-date? > > > > I went through the tables looking for columns that represent > > borrowernumbers. It's pretty easy for columns with foreign keys to > > borrowers.borrowernumber, but not all the columns have a borrowernumber. We > > should just add that to the qa process. If a new column is added that is a > > borrowernumber, it should be added to the mapping. We could move the mapping > > itself its own perl module to make it more obvious if you wish. > > I am going to push as it but I am not convinced by this approach. > We will not have any tests to alert us if we forgot to update this mapping. I'm sure we can do two things with unit tests: 1) Automate checking that all borrowernumber fields that are foreign keys to borrowers.borrowernumber are in our mapping 2) Automate testing all non-fk fields that are *named* borrowernumber are in our mapping. As for non-fk fields that are not named bororwernumber, I don't think there is anything we can do. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15273] Fines Payment receipt should include all account lines selected for this pay
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273 Sally Healey <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '18

23 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #45 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Staff is looking good so far, but ran into an error on the OPAC side: Error while transforming input: xmlXPathCompOpEval: function encode-uri bound to undefined prefix str xmlXPathCompiledEval: 1 objects left on the stack. runtime error: file /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slimUtils.xsl line 273 element value-of XPath evaluation returned no result. at /home/vagrant/kohaclone/Koha/XSLT_Handler.pm line 208. -- You are receiving this mail because: You are watching all bug changes.

1 0