April 2018 - Koha-bugs - lists.koha-community.org

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '18

18 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74439|0 |1 is obsolete| | --- Comment #42 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 74440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74440&action=ed… Bug 9302: Add ability to merge patron records It would be great if there were a merge patrons feature. If you accidentally end up with one patron with two cards it would be nice to merge their records together so that you don't lose their history or holds or anything. This patch adds a basic patron merge feature. It attempts to relink all patron related tables from the patron(s) to be merged. It does not attempt to relink librarian account related tables at this time. This feature does not attempt to automatically resolve issues such as duplicate holds. Such a feature could build upon this one though. Test Plan: 1) Apply this patch 2) Find two or more patrons 3) Perform a patron search that will bring them up on the same page of results, or add them all to a list of patrons. 4) Use the 'merge' button to begin the merging process 5) Choose a patron to keep 6) Verify the deleted patrons data ( checkouts, holds, etc ) are now linked to the kept patron Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Ed Veal <eveal(a)mckinneytexas.org> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '18

18 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73660|0 |1 is obsolete| | Attachment #73661|0 |1 is obsolete| | Attachment #73662|0 |1 is obsolete| | Attachment #73663|0 |1 is obsolete| | Attachment #73679|0 |1 is obsolete| | --- Comment #41 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 74439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74439&action=ed… Bug 9302: Add ability to merge patron records It would be great if there were a merge patrons feature. If you accidentally end up with one patron with two cards it would be nice to merge their records together so that you don't lose their history or holds or anything. This patch adds a basic patron merge feature. It attempts to relink all patron related tables from the patron(s) to be merged. It does not attempt to relink librarian account related tables at this time. This feature does not attempt to automatically resolve issues such as duplicate holds. Such a feature could build upon this one though. Test Plan: 1) Apply this patch 2) Find two or more patrons 3) Perform a patron search that will bring them up on the same page of results, or add them all to a list of patrons. 4) Use the 'merge' button to begin the merging process 5) Choose a patron to keep 6) Verify the deleted patrons data ( checkouts, holds, etc ) are now linked to the kept patron Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Ed Veal <eveal(a)mckinneytexas.org> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '18

18 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11870] Add more informations to histsearch.pl results
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '18

18 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset(a)biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '18

18 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 [Bug 20600] Provide the ability for users to filter ILL requests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #237 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry Julian, patches apply, but still some problems: 1) QA scripts Lots of those: FAIL Koha/Baskets.pm FAIL git manipulation The file has been added and deleted in the same patchset Maybe see if you can squash some with the same sign-offer? And: FAIL t/db_dependent/Acquisition/close_reopen_basket.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Global symbol "$order1" requires explicit package name Global symbol "$order2" requires explicit package name t/db_dependent/Acquisition/close_reopen_basket.t had compilation errors. FAIL t/db_dependent/Acquisition/Basketgroups.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid "AddBookseller" is not exported by the C4::Bookseller module Can't continue after import errors 2) Code review a) Koha/Acquisition/Baskets.pm -# Copyright 2017 Aleisha Amohia <aleisha(a)catalyst.net.nz> -# Why remove the Copyright statement? And POD? b) Similar: Koha/Acquisition/Orders.pm + my $pdfformatfile = './' . ($pdfformat =~ s,::,/,gr) . '.pm'; + require $pdfformatfile; Seems to be an unrelated change? I remember that we hardcoded the valid template names once for added security. could only find one mention of it tho: bug 11459#c11 c) admin/currency.pl +use Koha::Acquisition::Currency; Unrelated change? d) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroups.tt <th>Bookseller</th> Should be vendor! e) Generate EDIFACT Order Capitalization: Generate EDIFACT order f) Changes to koha-tmpl/intranet-tmpl/prog/js/datatables.js Do you remember why those changes were needed or was it not intentional? Trying to figure out what needs to be tested with this patch and it turns out a lot of code is touched. g) Merge atomicupdates? 3) Unit tests prove t/db_dependent/Acquisition/Basketgroups.t t/db_dependent/Acquisition/Basketgroups.t .. "AddBookseller" is not exported by the C4::Bookseller module Can't continue after import errors at t/db_dependent/Acquisition/Basketgroups.t line 9. BEGIN failed--compilation aborted at t/db_dependent/Acquisition/Basketgroups.t line 9. prove t/db_dependent/Acquisition/close_reopen_basket.t t/db_dependent/Acquisition/close_reopen_basket.t .. Global symbol "$order1" requires explicit package name at t/db_dependent/Acquisition/close_reopen_basket.t line 58. Global symbol "$order2" requires explicit package name at t/db_dependent/Acquisition/close_reopen_basket.t line 68. Execution of t/db_dependent/Acquisition/close_reopen_basket.t aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12759] Add ability to pass list contents to batch record modification/deletion tools
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think tabs. Could we keep the content or is that not possible? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Roch D'Amour <roch.damour(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72456|0 |1 is obsolete| | Attachment #72457|0 |1 is obsolete| | Attachment #72458|0 |1 is obsolete| | Attachment #72459|0 |1 is obsolete| | Attachment #72460|0 |1 is obsolete| | Attachment #72461|0 |1 is obsolete| | Attachment #72462|0 |1 is obsolete| | Attachment #72463|0 |1 is obsolete| | Attachment #72464|0 |1 is obsolete| | Attachment #72465|0 |1 is obsolete| | Attachment #74119|0 |1 is obsolete| | --- Comment #137 from Roch D'Amour <roch.damour(a)inlibro.com> --- Created attachment 74379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74379&action=ed… Bug 11317: Squash attachements to clean and fix merge errors: Add a way to access files from the intranet This squash contains all of these commits: - Adds a page to access log files on the server from the intranet - Update ID to allow for permalinking - Rename config to "'accessdir' and fix qa - Allows for multiple directories to be accessible - Update the link under reports - (Follow-up) Fixing merge error and cosmetic changes - (Follow-up) Fix tab chars and move javascript to the footer - (QA Follow-up) Fix datatable - Make filename unicode-proof, renamed accessdir to access_dir and fix update Test plans: - Apply patch, update database - Add to koha-conf: <access_dir>/tmp/koha-public/one</access_dir> <access_dir>/tmp/koha-public/two</access_dir> <access_dir>/tmp/koha-public</access_dir> - Create these directories ( mkdir /tmp/koha-public , etc...) - Create these files: echo "hello world!" > /tmp/koha-public/❤ echo "test" > /tmp/koha-public/one/samename.txt echo "this is not the same" > /tmp/koha-public/two/samename.txt - Login as Superadmin, go to tools > reports files - Click on ❤, make sure it's downloadable and readable - Click on both samename.txt, look inside and make sure the file is different - Login as NON-superadmin. Go under tools, see no Report/Log under the third column - Go to add tools/access_file permission to user - See new entry under tools third column. - validate link is ok. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Roch D'Amour <roch.damour(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11249] Add db indexes on borrowers names
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas(a)gmail.com --- Comment #8 from David Gustafsson <glasklas(a)gmail.com> --- Sorry, accidentally submitted new attachment by omitting HEAD with git bz apply for another patch. Please ignore this last change. -- You are receiving this mail because: You are watching all bug changes.

1 0