April 2018 - Koha-bugs - lists.koha-community.org

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #237 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry Julian, patches apply, but still some problems: 1) QA scripts Lots of those: FAIL Koha/Baskets.pm FAIL git manipulation The file has been added and deleted in the same patchset Maybe see if you can squash some with the same sign-offer? And: FAIL t/db_dependent/Acquisition/close_reopen_basket.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Global symbol "$order1" requires explicit package name Global symbol "$order2" requires explicit package name t/db_dependent/Acquisition/close_reopen_basket.t had compilation errors. FAIL t/db_dependent/Acquisition/Basketgroups.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid "AddBookseller" is not exported by the C4::Bookseller module Can't continue after import errors 2) Code review a) Koha/Acquisition/Baskets.pm -# Copyright 2017 Aleisha Amohia <aleisha(a)catalyst.net.nz> -# Why remove the Copyright statement? And POD? b) Similar: Koha/Acquisition/Orders.pm + my $pdfformatfile = './' . ($pdfformat =~ s,::,/,gr) . '.pm'; + require $pdfformatfile; Seems to be an unrelated change? I remember that we hardcoded the valid template names once for added security. could only find one mention of it tho: bug 11459#c11 c) admin/currency.pl +use Koha::Acquisition::Currency; Unrelated change? d) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroups.tt <th>Bookseller</th> Should be vendor! e) Generate EDIFACT Order Capitalization: Generate EDIFACT order f) Changes to koha-tmpl/intranet-tmpl/prog/js/datatables.js Do you remember why those changes were needed or was it not intentional? Trying to figure out what needs to be tested with this patch and it turns out a lot of code is touched. g) Merge atomicupdates? 3) Unit tests prove t/db_dependent/Acquisition/Basketgroups.t t/db_dependent/Acquisition/Basketgroups.t .. "AddBookseller" is not exported by the C4::Bookseller module Can't continue after import errors at t/db_dependent/Acquisition/Basketgroups.t line 9. BEGIN failed--compilation aborted at t/db_dependent/Acquisition/Basketgroups.t line 9. prove t/db_dependent/Acquisition/close_reopen_basket.t t/db_dependent/Acquisition/close_reopen_basket.t .. Global symbol "$order1" requires explicit package name at t/db_dependent/Acquisition/close_reopen_basket.t line 58. Global symbol "$order2" requires explicit package name at t/db_dependent/Acquisition/close_reopen_basket.t line 68. Execution of t/db_dependent/Acquisition/close_reopen_basket.t aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12759] Add ability to pass list contents to batch record modification/deletion tools
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I think tabs. Could we keep the content or is that not possible? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Roch D'Amour <roch.damour(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72456|0 |1 is obsolete| | Attachment #72457|0 |1 is obsolete| | Attachment #72458|0 |1 is obsolete| | Attachment #72459|0 |1 is obsolete| | Attachment #72460|0 |1 is obsolete| | Attachment #72461|0 |1 is obsolete| | Attachment #72462|0 |1 is obsolete| | Attachment #72463|0 |1 is obsolete| | Attachment #72464|0 |1 is obsolete| | Attachment #72465|0 |1 is obsolete| | Attachment #74119|0 |1 is obsolete| | --- Comment #137 from Roch D'Amour <roch.damour(a)inlibro.com> --- Created attachment 74379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74379&action=ed… Bug 11317: Squash attachements to clean and fix merge errors: Add a way to access files from the intranet This squash contains all of these commits: - Adds a page to access log files on the server from the intranet - Update ID to allow for permalinking - Rename config to "'accessdir' and fix qa - Allows for multiple directories to be accessible - Update the link under reports - (Follow-up) Fixing merge error and cosmetic changes - (Follow-up) Fix tab chars and move javascript to the footer - (QA Follow-up) Fix datatable - Make filename unicode-proof, renamed accessdir to access_dir and fix update Test plans: - Apply patch, update database - Add to koha-conf: <access_dir>/tmp/koha-public/one</access_dir> <access_dir>/tmp/koha-public/two</access_dir> <access_dir>/tmp/koha-public</access_dir> - Create these directories ( mkdir /tmp/koha-public , etc...) - Create these files: echo "hello world!" > /tmp/koha-public/❤ echo "test" > /tmp/koha-public/one/samename.txt echo "this is not the same" > /tmp/koha-public/two/samename.txt - Login as Superadmin, go to tools > reports files - Click on ❤, make sure it's downloadable and readable - Click on both samename.txt, look inside and make sure the file is different - Login as NON-superadmin. Go under tools, see no Report/Log under the third column - Go to add tools/access_file permission to user - See new entry under tools third column. - validate link is ok. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Roch D'Amour <roch.damour(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11249] Add db indexes on borrowers names
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas(a)gmail.com --- Comment #8 from David Gustafsson <glasklas(a)gmail.com> --- Sorry, accidentally submitted new attachment by omitting HEAD with git bz apply for another patch. Please ignore this last change. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11249] Add db indexes on borrowers names
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249 --- Comment #7 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 74372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74372&action=ed… Bug 11249: DBRev 3.15.00.006 Signed-off-by: Galen Charlton <gmc(a)esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12759] Add ability to pass list contents to batch record modification/deletion tools
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 --- Comment #16 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Jonathan Druart from comment #15) > why not tabs then? Tabs work too. But is it going to make someone mad if they paste a list of barcodes, switch tabs, switch back, and find their input gone? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12759] Add ability to pass list contents to batch record modification/deletion tools
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Owen Leonard from comment #14) > Would it make sense to completely reset the form if someone selects a > different input method (file/list/numbers) ? > > http://zivotdesign.com/p/#1/15239764835671 why not tabs then? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16976] New: Authorities searches with double quotes gives ZOOM error 20003
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16976 Bug ID: 16976 Summary: Authorities searches with double quotes gives ZOOM error 20003 Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: miguel.tuimil(a)xercode.es QA Contact: testopia(a)bugs.koha-community.org Any search on authorities(authorities/authorities-home.pl) that includes double quotes, for example "Enrico Fermi" gives: Software error: ZOOM error 20003 "can't set prefix query" (addinfo: "@or @attr 7=1 @attr 1=Heading 0 @attr 1=Heading-Main @attr 5=1 @attr 4=6 "\\"Enrico Fermi\\""") from diag-set 'ZOOM' -- You are receiving this mail because: You are watching all bug changes.

1 45

[Bug 12759] Add ability to pass list contents to batch record modification/deletion tools
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 --- Comment #14 from Owen Leonard <oleonard(a)myacpl.org> --- Would it make sense to completely reset the form if someone selects a different input method (file/list/numbers) ? http://zivotdesign.com/p/#1/15239764835671 -- You are receiving this mail because: You are watching all bug changes.

1 0