April 2018 - Koha-bugs - lists.koha-community.org

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #26 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72906|0 |1 is obsolete| | --- Comment #25 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74225&action=ed… Bug 15219: Fix date sorting when server-side processing is disabled Use DataTables 'columns' option instead of 'aoColumns' This allow more control on what data is used for display, sorting, filtering, ... A large part of this patch is about rewording things to better match the DataTables documentation. The real change is that "mRender": renderingFunc becomes "render": { "display": renderingFunc } So the return value of renderingFunc is now only used for display (not for filtering, sorting, ...) Signed-off-by: Eric Gosselin <eric.gosselin(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72905|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74224&action=ed… Bug 15219: Server-side processing and pagination on checkouts tables Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by enabling server-side processing and pagination on checkouts tables. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. As server-side processing can be useless and cumbersome with small sets of data, a new system preference is introduced to control this behaviour (server-side processing is disabled by default). Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) Test plan: 1. Find (or create) a patron that have at least 10 checkouts and where the relatives checkouts table contain at least 10 checkouts. 2. Go to the patron's detail page and check everything works fine in both tables (sorting, pagination, the data itself, ...) 3. Do the same on circulation page (circulation.pl) 4. Enable system preference ServerSideCheckoutsTable 5. Repeat steps 2 and 3 Signed-off-by: Eric Gosselin <eric.gosselin(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #215 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 --- Comment #214 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74222&action=ed… Bug 11708: Use Asset plugin in acqui/basketgroups.tt -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72699|0 |1 is obsolete| | --- Comment #213 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74221&action=ed… Bug 11708: Move acq related Koha::Objects to Koha::Acquisition namespace and fix Koha::Acquisition::Order usage everywhere Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72698|0 |1 is obsolete| | --- Comment #212 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74220&action=ed… Bug 11708: UT: Use DateTime instead of localtime+sprintf Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72697|0 |1 is obsolete| | --- Comment #211 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74219&action=ed… Bug 11708: UT: Replace 'ok' by 'is' where appropriate Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72696|0 |1 is obsolete| | --- Comment #210 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74218&action=ed… Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. In the process, this patch adds 4 new "Koha::Object" modules: - Koha::Bookseller(s) - Koha::Basket(s) - Koha::Basketgroup(s) - Koha::Order(s) It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '18

16 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72695|0 |1 is obsolete| | --- Comment #209 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 74217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74217&action=ed… Bug 11708: Place "Basket groups" menu entry on top of the side navigation Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0