April 2018 - Koha-bugs - lists.koha-community.org

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74209|0 |1 is obsolete| | --- Comment #108 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 74278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74278&action=ed… Bug 12395: Display created_by even if firstname is missing on receiving On receiving orders, "no name" was displayed if the firstname of creator was not filled. The surname should be displayed. Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74208|0 |1 is obsolete| | --- Comment #107 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 74277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74277&action=ed… Bug 12395: Add unit test to check created_by is correctly set Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74207|0 |1 is obsolete| | --- Comment #106 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 74276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74276&action=ed… Bug 12395: Save order line's creator New MySQL column: aqorders.createdby Creator's name is displayed on order's receive pages (acqui/orderreceive.pl and acqui/parcel.pl) On acqui/orderreceive.pl it replace the name of basket's creator On acqui/parcel.pl, to avoid adding more data in the table of pending orders, it is shown in a popup like MARC and Card views Test plan: 1/ Run updatedatabase.pl 2/ Create a new order and go to the receipt page (acqui/parcel.pl) 3/ Click on "Order" link in column "More" (previously "View record") 4/ A javascript popup should appear with your name in it. Close the popup. 5/ Click on "Receive" link 6/ Your name should appear in front of "Created by" label, to the right of the page. Patch updated with use of atomic update. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12395] Save order line's creator
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #105 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 1) Should showorder.pl, I think it should be: use CGI qw ( -utf8 ); 2) I was wondering why the order lines creator didn't show on /cgi-bin/koha/acqui/basket.pl?basketno=1. Neither does it when editing an order line. Maybe a follow-up (separate bug?) 3) Make both 'Order' information and orderreceive.pl use 'Ordered by'. Nothing else. I'll fix 1) and 3) in a follow-up. Please check! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #216 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Julian, can you give it another go? I think your branch might have been missing the latest commits (bug 18791). Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11708: Add aqbasketgroups.closeddate Applying: Bug 11708: Unit tests for aqbasketgroups.closeddate Applying: Bug 11708: basketgroup.pl can now display basketgroups for all suppliers Applying: Bug 11708: Remove column aqbasketgroups.closed Applying: Bug 11708: Place "Basket groups" menu entry on top of the side navigation Applying: Bug 11708: New page for basket groups Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc M koha-tmpl/intranet-tmpl/prog/js/datatables.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/datatables.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/datatables.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc Failed to merge in the changes. Patch failed at 0001 Bug 11708: New page for basket groups The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11708-New-page-for-basket-groups-pzWRYQ.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9302] Add ability to merge patron records
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #39 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- 4. on /members/merge-patrons.pl?id=19&id=5&id=45&id=21 the [+][-] links in the header do nothing (https://screenshots.firefox.com/kq2LyGsluEr0ir7F/pro.kohadev.org) 5. After this confirmation screen: https://screenshots.firefox.com/h9NQITzesVqeVQm6/pro.kohadev.org I see these 3 holds: https://screenshots.firefox.com/ZfjbD6PZWOBYv3Je/pro.kohadev.org It's not clear to me what happened. 6. On this screen (result of the merge), we are left alone (back/return button is missing?) 7. flagsrequired => { borrowers => 1 } must be borrowers => 'edit_borrowers' 8. <td>[% p.firstname | html %] [% p.surname | html %]</td> and <a href="moremember.pl?borrowernumber=[% keeper.id %]">[% keeper.firstname %] [% keeper.surname %] ([% keeper.cardnumber | html %])</a> must be replaced with a call to patron-include.inc 9. TT, in the display_names block, you need to surround the strings with a html tag (for translation) 10. Not sure about that part, I am going to ping Owen: 60 <div id="doc2" class="yui-t7"> 61 <div id="bd"> 62 <div id="yui-main"> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #68 from Charles Farmer <charles.farmer(a)inlibro.com> --- Rebased on current master. Should apply cleanly now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73818|0 |1 is obsolete| | --- Comment #67 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 74273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74273&action=ed… Bug 8643: (follow-up) Move input field up below mandatory Changes sequence of input fields to be more logical by grouping repeatable, mandatory, important, like it's already done for the subfield configuration. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74271|0 |1 is obsolete| | --- Comment #66 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 74272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74272&action=ed… Bug 8643: (QA follow-up) Use paler yellow and better column order Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to MARC tags and subfields
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '18

17 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73817|0 |1 is obsolete| | --- Comment #65 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 74271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74271&action=ed… Bug 8643: (QA follow-up) Use paler yellow and better column order Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0