April 2018 - Koha-bugs - lists.koha-community.org

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74003|0 |1 is obsolete| | --- Comment #197 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 74008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74008&action=ed… Bug 11897: (QA Followup) Implement review feedback. - Update Table declarations - Add permissions checks - Remove unused code - Fix language & naming - Make templates translation friendly -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72127|0 |1 is obsolete| | --- Comment #196 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 74007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74007&action=ed… Bug 11897: Add bulk of Stockrotation module. This commit replaces a set of about 20 commits into one large commit. This makes working with the module way easier from bugzilla. As it stands the patches on this bug provide a fully functioning stock rotation feature set for Koha. All previous patches that added functionality were signed off, so I'm retaining that flag. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72126|0 |1 is obsolete| | --- Comment #195 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 74006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74006&action=ed… Bug 11897: DBIX::Class::Ordered in Stockrotationstage. * Koha/Schema/Result/Stockrotationstage.pm: Load `Ordered`, add grouping_column. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72125|0 |1 is obsolete| | --- Comment #194 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 74005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74005&action=ed… Bug 11897: DO NOT PUSH: Add stock rotation schema files. * Koha/Schema/Result/Branch.pm: New file. * Koha/Schema/Result/Item.pm: New file. * Koha/Schema/Result/Stockrotationitem.pm: New file. * Koha/Schema/Result/Stockrotationrota.pm: New file. * Koha/Schema/Result/Stockrotationstage.pm: New file. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72124|0 |1 is obsolete| | --- Comment #193 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 74004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74004&action=ed… Bug 11897: Add Stock Rotation atomic update schema. * installer/data/mysql/atomicupdate/stockrot_tables.sql: New file. * installer/data/mysql/kohastructure.sql (stockrotationrotas) (stockrotationstages, stockrotationitems): New tables. * installer/data/mysql/sysprefs.sql: Add Stockrotation sysprefs. * installer/data/mysql/userflags.sql: Add Stockrotaiton userflag. * installer/data/mysql/userpermissions.sql: Add Stockrotation userpermissions. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref: Add Stockrotation menu. Signed-off-by: Kathleen Milne <kathleen.milne(a)cne-siar.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72128|0 |1 is obsolete| | --- Comment #192 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 74003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74003&action=ed… Bug 11897: (QA Followup) Implement review feedback. - Update Table declarations - Add permissions checks - Remove unused code - Fix language & naming - Make templates translation friendly -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20566] New: Remove 'single' method from Koha::Objects
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20566 Bug ID: 20566 Summary: Remove 'single' method from Koha::Objects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org We're exposing ourselves to terrible bugs which dbix::class goes to lengths to inform the developer about before they're added by circumventing the protections built into dbic here. By hard coding a 'rows => 1' into this method instead of just using the method from DBIC we are ensuring the developer will never be informed of their stupidity if they have not added any form or ordering to their database clauses. As such, the order of the results returned and as such the result of the 'single' call is now entirely random. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #137 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- And what about NoticeBcc? Failing QA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #136 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (very) Quick at the code, I'd say there is one missing: C4::Letters::SendAlerts, this block does not use Koha::Email 467 elsif ( $type eq 'claimacquisition' or $type eq 'claimissues' or $type eq 'orderacquisition' ) { -- You are receiving this mail because: You are watching all bug changes.

1 0