April 2018 - Koha-bugs - lists.koha-community.org

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #135 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I do not think the test coverage is enough. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #134 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #133) > (In reply to Jonathan Druart from comment #131) > > (In reply to ByWaterSandboxes from comment #130) > > > It does not affect messages in the message_queue. > > > > So it's not "all emails" :) > > I was going to fail QA this patch because I was testing overdue notices. > > > > However it seems that is was the first intention of this patch (see first > > patch, in comment 3). Why did you change your mind? > > Why do you think it would not affect overdue notices? > > It changes Koha::Email create_message_headers which is used by: > SendAlerts (emails sent directly) > _send_message_by_emai (processes emails from the message_queue) > > Actually I think it should cover all emails and if not, other emails not > using Koha::Email would be a bug. > > Maybe the commit message is wrong? (or I am) Indeed, sounds like it would work. I cannot remember what I tested 3 months ago however. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #76 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I cannot imagine pushing something with caching issues, even if the issue will be hard to show up. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #75 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #74) > (In reply to Marcel de Rooy from comment #73) > > Hmm. Must say that I have been thinking about using Koha::Cache for it, but > > it would not be a real benefit in time. Problem with > > Koha::Cache::Memory::Lite is the same as handling it in the module; the L1 > > cache and also the cached_indicators are kept per Plack worker for some > > time. So would still be buggy. > > Nope, there is the following statement in psgi file: > 47 Koha::Caches->flush_L1_caches(); > 48 Koha::Cache::Memory::Lite->flush(); In view of my comment73 I personally do not see the need for moving to Lite here immediately. I am happy to do it on a new report. What do you think? Is it a requirement for 18.05 ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #74 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #73) > Hmm. Must say that I have been thinking about using Koha::Cache for it, but > it would not be a real benefit in time. Problem with > Koha::Cache::Memory::Lite is the same as handling it in the module; the L1 > cache and also the cached_indicators are kept per Plack worker for some > time. So would still be buggy. Nope, there is the following statement in psgi file: 47 Koha::Caches->flush_L1_caches(); 48 Koha::Cache::Memory::Lite->flush(); -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72454|0 |1 is obsolete| | --- Comment #163 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 74001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74001&action=ed… Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! Rebased again -- my fault for being slow on this. The test plan is in comment #112 last I checked. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Niamh <niamh.walker-headon(a)it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #73 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #72) > I do not have time to test but I am pretty sure the way you cache > $cached_indicators in Koha::Authority::ControlledIndicators is buggy. > You should use Koha::Cache::Memory::Lite instead. Hmm. Must say that I have been thinking about using Koha::Cache for it, but it would not be a real benefit in time. Problem with Koha::Cache::Memory::Lite is the same as handling it in the module; the L1 cache and also the cached_indicators are kept per Plack worker for some time. So would still be buggy. But note that this is strictly hypothetical. The pref is not expected to change on a regular basis. I decided not to add a clear statement at pref change event but to add it in the new method. This effectively makes it a minimal issue. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 --- Comment #79 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Please also fix your commit messages on the first 2 patches as pointed out by the QA tools: Bug 12747 - Add extra column in Z3950 search result -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #78 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Please double check the Z39.05 search, MARC, ISBD, etc. have been moved into a pull down menu a whlie ago and your patch adds back the initial separate columns. -- You are receiving this mail because: You are watching all bug changes.

1 0