April 2018 - Koha-bugs - lists.koha-community.org

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72128|0 |1 is obsolete| | --- Comment #192 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 74003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74003&action=ed… Bug 11897: (QA Followup) Implement review feedback. - Update Table declarations - Add permissions checks - Remove unused code - Fix language & naming - Make templates translation friendly -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20566] New: Remove 'single' method from Koha::Objects
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20566 Bug ID: 20566 Summary: Remove 'single' method from Koha::Objects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org We're exposing ourselves to terrible bugs which dbix::class goes to lengths to inform the developer about before they're added by circumventing the protections built into dbic here. By hard coding a 'rows => 1' into this method instead of just using the method from DBIC we are ensuring the developer will never be informed of their stupidity if they have not added any form or ordering to their database clauses. As such, the order of the results returned and as such the result of the 'single' call is now entirely random. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #137 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- And what about NoticeBcc? Failing QA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7607] Advanced search: Index and search term don't match when leaving fields empty
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Marjorie Barry-Vila <marjorie.barry-vila(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #136 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (very) Quick at the code, I'd say there is one missing: C4::Letters::SendAlerts, this block does not use Koha::Email 467 elsif ( $type eq 'claimacquisition' or $type eq 'claimissues' or $type eq 'orderacquisition' ) { -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #135 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I do not think the test coverage is enough. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #134 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #133) > (In reply to Jonathan Druart from comment #131) > > (In reply to ByWaterSandboxes from comment #130) > > > It does not affect messages in the message_queue. > > > > So it's not "all emails" :) > > I was going to fail QA this patch because I was testing overdue notices. > > > > However it seems that is was the first intention of this patch (see first > > patch, in comment 3). Why did you change your mind? > > Why do you think it would not affect overdue notices? > > It changes Koha::Email create_message_headers which is used by: > SendAlerts (emails sent directly) > _send_message_by_emai (processes emails from the message_queue) > > Actually I think it should cover all emails and if not, other emails not > using Koha::Email would be a bug. > > Maybe the commit message is wrong? (or I am) Indeed, sounds like it would work. I cannot remember what I tested 3 months ago however. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #76 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I cannot imagine pushing something with caching issues, even if the issue will be hard to show up. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #75 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #74) > (In reply to Marcel de Rooy from comment #73) > > Hmm. Must say that I have been thinking about using Koha::Cache for it, but > > it would not be a real benefit in time. Problem with > > Koha::Cache::Memory::Lite is the same as handling it in the module; the L1 > > cache and also the cached_indicators are kept per Plack worker for some > > time. So would still be buggy. > > Nope, there is the following statement in psgi file: > 47 Koha::Caches->flush_L1_caches(); > 48 Koha::Cache::Memory::Lite->flush(); In view of my comment73 I personally do not see the need for moving to Lite here immediately. I am happy to do it on a new report. What do you think? Is it a requirement for 18.05 ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 11 Apr '18

11 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #74 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #73) > Hmm. Must say that I have been thinking about using Koha::Cache for it, but > it would not be a real benefit in time. Problem with > Koha::Cache::Memory::Lite is the same as handling it in the module; the L1 > cache and also the cached_indicators are kept per Plack worker for some > time. So would still be buggy. Nope, there is the following statement in psgi file: 47 Koha::Caches->flush_L1_caches(); 48 Koha::Cache::Memory::Lite->flush(); -- You are receiving this mail because: You are watching all bug changes.

1 0