April 2018 - Koha-bugs - lists.koha-community.org

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset(a)hotmail.com Status|Needs Signoff |Failed QA --- Comment #67 from M. Tompsett <mtompset(a)hotmail.com> --- Using DecimalSeparator as ',.', we should be able to enter #,###,###.## and get #######.## back. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #66 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 73873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73873 Bug 12310 : Decimal separator issues: fixes in fines Review of attachment 73873: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=123…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/includes/decimal-input-js.inc @@ +19,5 @@ > + // remove everything except digits, minuses, and the chars in DecimalSeparators syspref > + var formatted_decimal = formatted_decimal > + .replace(/[^0-9-[% Koha.Preference('DecimalSeparators') %]]/g, ''); > + var decimal = formatted_decimal > + .replace(/[[% Koha.Preference('DecimalSeparators') %]]/g, '.'); Sorry, but this doesn't quite work. 5,123.12 -> 5.123.12 The decimal point is likely the LAST one that matches the DecimalSeparators. While everything else is either noise or thousands separators. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #65 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 73880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73880&action=ed… Bug 12310: Follow up to prevent updatedatabase noise Added IGNORE into the SQL statement. TEST PLAN --------- run the atomic update multiple times. -- noise apply patch run the atomic update multiple times. -- no noise -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13958] Add a suspensionsCalendar syspref
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19204 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19204 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 [Bug 19204] Fines in days restriction calculation is not taking calender into account -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73785|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73874|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73874|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #64 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 73874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73874&action=ed… Bug 12310 : Follow up to keep the example text in fines This puts the example text back in with the correct decimal separator. The example uses the first char of the syspref. TEST PLAN --------- 1) set the I18N/L10N DecimalSeparators syspref to "," 2) go to a patron's fines tab. 3) open Create manual invoice and Create manual credit tabs 4) check both tabs -- Example: 5.00 appears 5) apply this patch 6) reload the page and check both create tabs. -- Example: 5,12 appears 7) set the I18N/L10N DecimalSeparators syspref to ".," 8) go back and check both tabs. -- Example: 5.12 appears (only the first separator is picked) 9) optionnal: run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.

1 0