April 2018 - Koha-bugs - lists.koha-community.org

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |nick(a)bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #68 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #66) > Blocked by bug 9701 In the history of this report we had a dependency, but the current solution is not dependent. Note that 9701 still needs an authority counterpart which 14769 is not. I remember posting a remark about that on Bugzilla before, but could not find it here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #47 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Marcel de Rooy from comment #42) > Comment on attachment 73781 [details] [review] > Bug 9701: (QA follow-up) Fix indentation and some strings > > This patch continually generates malloc errors and other git problems with > me. It seems that we do not need it too. I have no qa warnings about tabs. Strange, but I am not attached to it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14769] Authorities merge: Set correct indicators in biblio field
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769 --- Comment #67 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Nick Clemens from comment #65) > Everything seesm to work as expected - I would consider putting a big > warning on AuthorityControlledIndicators to specify you shouldn't touch it > if you don't know what you are doing Thx for QAing, Nick. If you do not know what you are doing, you should better stay out of preferences all together ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #46 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 73845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73845&action=ed… Bug 9701: (QA follow-up) DBIx schema changes Changes in MarcTagStructure.pm Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #45 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 73844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73844&action=ed… Bug 9701: (follow-up) Adjust tests Test plan: prove t/db_dependent/Biblio.t should be green Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73780|0 |1 is obsolete| | Attachment #73782|0 |1 is obsolete| | Attachment #73783|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 73843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73843&action=ed… Bug 9701: Configure default indicator This patch adds the possibility to define default indicators in the MARC frameworks. It adds 2 columns in the marc_tag_structure table in the database in order to accomplish this. All files that reference this table have also been updated to reflect these added fields. Test: Add or edit a MARC framework. In the Field list should be 2 extra columns. It should be possible to add default indicators (1 character) in these fields. Nothing else should have changed in the meantime. The default indicator values are not yet visible in the cataloguing module. The default values are also loaded in the cataloguing form. Test: Define default values in some MARC framework. Go to cataloguing and create a new record using this framework. Verify that the defined defaults are visible when set. Verify the default is empty (as before) if no default was set. Verify that if the default is changed, the record is saved with the manually changed value. Verify that upon changing such a new record, the manually set indicator value is used and not the default one from the framework. Don't forget to run database and database schema update Signed-off-by: Eugene Jose Espinoza <eugenegf(a)yahoo.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to M. Tompsett from comment #34) > t/db_dependent/Biblio.t is failing... there is a difference between unsafe > and empty call to GetMarcStructure for some reason. Haven't traced it back > enough. This is a side issue that is failing this bug. I'm having the impression that the third patch changing forlibrarian to 1 is not needed. We only need to flush the cache once ? -- You are receiving this mail because: You are watching all bug changes.

1 0