April 2018 - Koha-bugs - lists.koha-community.org

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #46 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 73845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73845&action=ed… Bug 9701: (QA follow-up) DBIx schema changes Changes in MarcTagStructure.pm Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #45 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 73844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73844&action=ed… Bug 9701: (follow-up) Adjust tests Test plan: prove t/db_dependent/Biblio.t should be green Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73780|0 |1 is obsolete| | Attachment #73782|0 |1 is obsolete| | Attachment #73783|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 73843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73843&action=ed… Bug 9701: Configure default indicator This patch adds the possibility to define default indicators in the MARC frameworks. It adds 2 columns in the marc_tag_structure table in the database in order to accomplish this. All files that reference this table have also been updated to reflect these added fields. Test: Add or edit a MARC framework. In the Field list should be 2 extra columns. It should be possible to add default indicators (1 character) in these fields. Nothing else should have changed in the meantime. The default indicator values are not yet visible in the cataloguing module. The default values are also loaded in the cataloguing form. Test: Define default values in some MARC framework. Go to cataloguing and create a new record using this framework. Verify that the defined defaults are visible when set. Verify the default is empty (as before) if no default was set. Verify that if the default is changed, the record is saved with the manually changed value. Verify that upon changing such a new record, the manually set indicator value is used and not the default one from the framework. Don't forget to run database and database schema update Signed-off-by: Eugene Jose Espinoza <eugenegf(a)yahoo.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to M. Tompsett from comment #34) > t/db_dependent/Biblio.t is failing... there is a difference between unsafe > and empty call to GetMarcStructure for some reason. Haven't traced it back > enough. This is a side issue that is failing this bug. I'm having the impression that the third patch changing forlibrarian to 1 is not needed. We only need to flush the cache once ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73781|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Comment on attachment 73781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73781 Bug 9701: (QA follow-up) Fix indentation and some strings This patch continually generates malloc errors and other git problems with me. It seems that we do not need it too. I have no qa warnings about tabs. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9701] Configure default indicators
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #40) > Hi Marcel, can you please take care of QA here as your patch builds on it? Yes I will. They are related but do not really depend on each other. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14567] Browse interface for OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14567] Browse interface for OPAC
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #38 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 69614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69614 Bug 14567: Add a browse interface to the OPAC Review of attachment 69614: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=145…) ----------------------------------------------------------------- It's quite basic still, but that makes it easy to test and it's really fast on my system. Some mostly small things that should be easy to check/fix: 1) There is currently no way to access the page from the OPAC if you don't know the address. Should we not add it to the top navigation? Maybe with an id to make it easy to hide? 2) Will long lists be paged? I couldn't get it to page on my system but wonder how it will look for a really long list. ::: Koha/SearchEngine/Elasticsearch/Browse.pm @@ +178,5 @@ > +=head1 AUTHOR > + > +=over 4 > + > +=item Robin Sheat C<< <robin(a)catalyst.net.nz> >> 5) Was the C intentional? ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browse.tt @@ +83,5 @@ > + </div> > +</div> > +[% INCLUDE 'opac-bottom.inc' %] > +[% BLOCK jsinclude %] > +<script type="text/javascript" src="[% interface %]/[% theme %]/js/browse.js"> 3) FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browse.tt FAIL forbidden patterns forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive (line 87) Not a false one here I think! ::: opac/opac-browse.pl @@ +91,5 @@ > + ); > + print to_json( \@output ); > +} > + > +# This is a temporary, MARC21-only thing that will grab titles, and authors 4) Still MARC21 only? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13560] Add an 'Add' option in MARC modification templates
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '18

09 Apr '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|need an add option in marc |Add an 'Add' option in MARC |modification templates |modification templates -- You are receiving this mail because: You are watching all bug changes.

1 0